-
Notifications
You must be signed in to change notification settings - Fork 181
bugfix: release calendar logic #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe PR modifies the GitHub Actions release calendar workflow to enable authenticated git operations. It adds PAT-based authentication by sourcing a token from Changes
Sequence DiagramsequenceDiagram
participant GH as GitHub Actions
participant Git as Git Remote
participant Repo as Repository
rect rgb(245, 245, 245)
Note over GH,Repo: Previous Flow (GITHUB_TOKEN)
GH->>Git: git push (default token)
Note over Git: May fail if insufficient permissions
end
rect rgb(240, 248, 255)
Note over GH,Repo: New Flow (PAT Authentication)
GH->>GH: Load GH_TOKEN from secrets.SELFXYZ_INTERNAL_REPO_PAT
GH->>Git: git remote set-url origin<br/>(PAT-based URL)
GH->>Git: git push (authenticated via PAT)
Git->>Repo: Push release branch
Repo-->>Git: ✓ Success
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Requires careful review of PAT token usage, conditional logic gating, and verification that authentication only triggers during release branch creation to avoid unnecessary token exposure. Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1).github/workflows/**/*.{yml,yaml}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 17
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| echo "Creating release branch ${BRANCH_NAME} from dev" | ||
| # Configure git to use the PAT for pushing | ||
| git remote set-url origin https://x-access-token:${GH_TOKEN}@github.com/selfxyz/self.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
seems like opening pull requests works as expected. example: |
Summary by CodeRabbit