-
Notifications
You must be signed in to change notification settings - Fork 180
custom circuit build #1238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom circuit build #1238
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughAdds parameterized CI workflow inputs to selectively build circuits by type or name, with validation and artifact handling. Introduces a new Bash script to build a single circuit by name, deriving type, validating presence, compiling Circom to C++, and building the generated code, preserving artifact upload. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant GH as GitHub Actions
participant WF as circuits-build.yml
participant SH as build_single_circuit.sh
participant Circom as circom
participant CPP as g++/make
participant Art as Artifacts
Dev->>GH: workflow_dispatch (circuit-name or circuit-type)
GH->>WF: Run workflow
WF->>WF: Validate inputs (mutual exclusivity)
alt circuit-name provided
WF->>Art: Download previous artifacts (best-effort)
loop for each name
WF->>SH: ./build_single_circuit.sh <name>
SH->>SH: Derive type, resolve paths, validate existence
SH->>Circom: Compile .circom -> C++ (with includes)
SH->>CPP: Build generated C++ (cpp dir)
CPP-->>SH: Build result
SH-->>WF: Exit code
end
else circuit-type provided
WF->>Art: Download previous artifacts (best-effort)
WF->>WF: Invoke existing type-based build (build_cpp.sh)
else no inputs
WF->>WF: Build all circuits (default set)
end
WF->>Art: Upload build artifacts
note over WF,Art: Preserve final artifact upload regardless of path
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Nesopie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary by CodeRabbit