-
Notifications
You must be signed in to change notification settings - Fork 193
Merge Feat/update contract scripts #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f1f4308
chore: add a verifier script
Nesopie adb654b
chore: remove expirty and add update registry script
6ce87d7
chore: change script to the new aadhaar contract
bb2e6c3
chore: add new deployed addresses
Nesopie ea68b6e
fix: tests
Nesopie e8bc5e1
feat: add scripts for registries and the hub
02e6e1f
feat: add aadhaar registry
Nesopie b4566c0
feat: add more scripts
Nesopie a41a350
chore: rm logs
Nesopie 4dfe34f
fix: hardhat config
Nesopie 11757f8
update scripts
Nesopie 991ef42
Merge branch 'dev' into feat/update-contract-scripts
Nesopie 3ebaf10
fix: test
Nesopie e63089e
accept proofs 1 day in the future
Nesopie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Date Validation Error Extends Future Range
The date validation in
_performCurrentDateCheckand_performNumericCurrentDateCheckincorrectly extends the valid range. Changing the upper bound fromstartOfDay + 1 days - 1toendOfDay + 1 days(whereendOfDayisstartOfDay + 1 days - 1) effectively allows proofs with dates one day further in the future than intended.Additional Locations (1)
contracts/contracts/IdentityVerificationHubImplV2.sol#L1017-L1019