Skip to content

fix: use elliptic DER bytes directly for ECDSA signatures #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

fix: use elliptic DER bytes directly for ECDSA signatures #1210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f80aa5
Merge pull request #1160 from selfxyz/dev
transphorm Sep 30, 2025
86b1589
Merge pull request #1167 from selfxyz/dev
transphorm Oct 1, 2025
4e8b311
Merge pull request #1169 from selfxyz/dev
transphorm Oct 1, 2025
1ab97c3
Merge pull request #1179 from selfxyz/dev
transphorm Oct 2, 2025
48f8d79
Merge pull request #1194 from selfxyz/justin/chore-update-staging-wit…
transphorm Oct 3, 2025
71d617b
fix: use elliptic DER bytes directly for ECDSA signatures
radik878 Oct 5, 2025
0e05c5c
fix: use elliptic DER bytes directly for ECDSA signatures
radik878 Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions common/src/utils/passports/genMockIdDoc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,7 @@ function sign(
const msgHash = hash(hashAlgorithm, eContent, 'hex');

const signature = keyPair.sign(msgHash, 'hex');
// @ts-ignore-error toDer gives number[] what is fine for Buffer.from
const signatureBytes = Array.from(Buffer.from(signature.toDER(), 'hex'));

const signatureBytes = Array.from(signature.toDER() as number[]);
return signatureBytes;
} else {
const privKey = forge.pki.privateKeyFromPem(privateKeyPem);
Expand Down
4 changes: 1 addition & 3 deletions common/src/utils/passports/genMockPassportData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,7 @@ function sign(
const msgHash = hash(hashAlgorithm, eContent, 'hex');

const signature = keyPair.sign(msgHash, 'hex');
// @ts-ignore-error this seems wrong
const signatureBytes = Array.from(Buffer.from(signature.toDER(), 'hex'));

const signatureBytes = Array.from(signature.toDER() as number[]);
return signatureBytes;
} else {
const privKey = actualForge.pki.privateKeyFromPem(privateKeyPem);
Expand Down
Loading