fix: ofac

[Nesopie]

Summary by CodeRabbit

• Bug Fixes
  • Corrected the OFAC validation flag in verification results. When OFAC checks are not configured or enabled, the flag now returns false instead of true, resulting in consistent API responses.
  • Clarified the meaning of the OFAC validation flag in responses to reduce ambiguity.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The verification result’s isOfacValid flag behavior was changed: when OFAC verification is not configured or disabled, it now returns false instead of true. A clarifying comment was added. No other logic paths or error handling were modified.

Changes

Cohort / File(s)	Summary of edits
Verifier result semantics sdk/core/src/SelfBackendVerifier.ts	In verify(...), changed isOfacValid default from true to false when OFAC is undefined/disabled; kept cumulativeOfac when enabled. Added a comment describing the intended meaning of isOfacValid.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: ofac logic #1124 — Also adjusts OFAC handling in SelfBackendVerifier.ts, modifying logic around cumulativeOfac and the isOfacValid return value.

Poem

A switch flipped quiet in the verifier’s hall,
OFAC’s default no longer “true” by call.
Flags now speak plain, no shadow or mask,
Config decides the answer we ask.
Tiny change, precise and neat—
Logic’s compass finds its beat.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/ofac

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c55112d and b4d5a08.

📒 Files selected for processing (1)

• sdk/core/src/SelfBackendVerifier.ts (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}