Skip to content

Conversation

@transphorm
Copy link
Member

Summary

  • update the mobile demo wrapper to reuse the SelfClientProvider exported by the SDK instead of the bespoke SelfMobileSdk wrapper

Testing

  • yarn workspace mobile-sdk-demo test (fails: Cannot find module '@react-native-picker/picker' from 'jest.setup.js')

https://chatgpt.com/codex/tasks/task_b_68dc2c26cd64832d8591f09e02c02e57

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • main
  • dev
  • staging

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/integrate-mock-document-generation-with-document-store-p4v413

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm marked this pull request as ready for review September 30, 2025 22:05
@transphorm transphorm merged commit 296d757 into codex/review-mobile-sdk-demo-app-for-polish-suggestions Sep 30, 2025
6 of 7 checks passed
@transphorm transphorm deleted the codex/integrate-mock-document-generation-with-document-store-p4v413 branch September 30, 2025 22:05
transphorm added a commit that referenced this pull request Oct 1, 2025
* Improve demo app safe area handling

* refactor: centralize mobile demo screen navigation

* update lock

* update podfile lock

* fix pipelines

* fix tests

* save wip polish

* polish app

* simplify and standardize screens

* small fixes

* fix tests

* Use SDK SelfClientProvider in demo (#1162)

* fix types

* Fix mobile SDK demo Jest mock

* force react-native-svg to 15.12.1

* fix tests

* add types script

* fix document list

* fix types and metro config

* add ignore files to speed up watchman and eslint

* save wip tweaks

* save mock doc screen wip

* use persistant document store

* save polish work in progress

* add polish to screens

* save wip secure storage

* allow cursor to examine react configs

* convert tests to vitest and fix

* fix tests

* prettier

* cr feedback

* fix tests and remove skipped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants