Skip to content

Conversation

@aaronmgdr
Copy link
Contributor

probably not for merging just for ideas

aaronmgdr and others added 23 commits September 22, 2025 11:37
This reverts commit 3397fcf. which reverted merging proving machine migration
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…rding flow.

extract out logic from ConfirmBelongingScreen to usePrepareRegistration hook in mobile sdk
@aaronmgdr aaronmgdr changed the base branch from main to dev September 30, 2025 09:58
@gitguardian
Copy link

gitguardian bot commented Sep 30, 2025

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
20511340 Triggered Generic Private Key ec732da common/src/mock_certificates/sha256_rsa_130689_4096/mock_csca.key View secret
20511341 Triggered Generic Private Key ec732da common/src/mock_certificates/sha1_rsa_64321_4096/mock_csca.key View secret
20511342 Triggered Generic Private Key ec732da common/src/mock_certificates/sha256_rsa_107903_4096/mock_dsc.key View secret
20511343 Triggered Generic Private Key ec732da common/src/constants/mockCertificates.ts View secret
20511344 Triggered Generic Private Key ec732da common/src/mock_certificates/sha256_rsa_130689_4096/mock_dsc.key View secret
21022104 Triggered Generic Private Key 2df4dc4 common/src/mock_certificates/aadhaar/mockAadhaarCert.ts View secret
20511345 Triggered Generic Private Key ec732da common/src/mock_certificates/sha256_rsa_56611_4096/mock_dsc.key View secret
20511346 Triggered Generic Private Key ec732da common/src/mock_certificates/sha256_rsa_107903_4096/mock_csca.key View secret
20511347 Triggered Generic Private Key ec732da common/src/constants/mockCertificates.ts View secret
20511348 Triggered Generic Private Key ec732da common/src/mock_certificates/sha256_rsa_122125_4096/mock_csca.key View secret
20511349 Triggered Generic Private Key ec732da common/src/mock_certificates/sha256_rsa_56611_4096/mock_csca.key View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aaronmgdr/high-level-msdk-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants