-
Notifications
You must be signed in to change notification settings - Fork 180
chore: rename android-passport-reader to android-passport-nfc-reader #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
transphorm
merged 2 commits into
dev
from
justin/chore-rename-android-passport-reader-repo
Sep 29, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,40 +87,40 @@ cd "$PROJECT_ROOT" | |
|
|
||
| log "Working directory: $(pwd)" | ||
|
|
||
| # Clone android-passport-reader if it doesn't exist (for local development) | ||
| # Clone android-passport-nfc-reader if it doesn't exist (for local development) | ||
| # Note: In CI, this is usually handled by GitHub action, but we keep this as fallback | ||
| if [[ ! -d "app/android/android-passport-reader" ]]; then | ||
| log "Cloning android-passport-reader for build..." | ||
| if [[ ! -d "app/android/android-passport-nfc-reader" ]]; then | ||
| log "Cloning android-passport-nfc-reader for build..." | ||
| cd app/android | ||
|
|
||
| # Use different clone methods based on environment | ||
| if is_ci && [[ -n "${SELFXYZ_INTERNAL_REPO_PAT:-}" ]]; then | ||
| # CI environment with PAT (fallback if action didn't run) | ||
| git clone "https://${SELFXYZ_INTERNAL_REPO_PAT}@github.com/selfxyz/android-passport-reader.git" || { | ||
| log "ERROR: Failed to clone android-passport-reader with PAT" | ||
| git clone "https://${SELFXYZ_INTERNAL_REPO_PAT}@github.com/selfxyz/android-passport-nfc-reader.git" || { | ||
| log "ERROR: Failed to clone android-passport-nfc-reader with PAT" | ||
| exit 1 | ||
| } | ||
| elif [[ -n "${SSH_AUTH_SOCK:-}" ]] || [[ -f "${HOME}/.ssh/id_rsa" ]] || [[ -f "${HOME}/.ssh/id_ed25519" ]]; then | ||
| # Local development with SSH | ||
| git clone "[email protected]:selfxyz/android-passport-reader.git" || { | ||
| log "ERROR: Failed to clone android-passport-reader with SSH" | ||
| git clone "[email protected]:selfxyz/android-passport-nfc-reader.git" || { | ||
| log "ERROR: Failed to clone android-passport-nfc-reader with SSH" | ||
| log "Please ensure you have SSH access to the repository or set SELFXYZ_INTERNAL_REPO_PAT" | ||
| exit 1 | ||
| } | ||
| else | ||
| log "ERROR: No authentication method available for cloning android-passport-reader" | ||
| log "ERROR: No authentication method available for cloning android-passport-nfc-reader" | ||
| log "Please either:" | ||
| log " - Set up SSH access (for local development)" | ||
| log " - Set SELFXYZ_INTERNAL_REPO_PAT environment variable (for CI)" | ||
| exit 1 | ||
| fi | ||
|
|
||
| cd ../../ | ||
| log "✅ android-passport-reader cloned successfully" | ||
| log "✅ android-passport-nfc-reader cloned successfully" | ||
| elif is_ci; then | ||
| log "📁 android-passport-reader exists (likely cloned by GitHub action)" | ||
| log "📁 android-passport-nfc-reader exists (likely cloned by GitHub action)" | ||
| else | ||
| log "📁 android-passport-reader already exists - preserving existing directory" | ||
| log "📁 android-passport-nfc-reader already exists - preserving existing directory" | ||
| fi | ||
|
|
||
| # Build and package the SDK with timeout | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.