Skip to content

Conversation

@transphorm
Copy link
Member

@transphorm transphorm commented Sep 26, 2025

Summary by CodeRabbit

  • Style

    • Buttons are consistently full-width and arranged vertically.
    • Description text is always centered with a larger, uniform font.
    • Additional text uses standard size and casing for consistent typography.
  • Refactor

    • Removed the Aesop redesign toggle and related conditional logic.
    • Retired the Aesop Document Onboarding screen and removed it from navigation, simplifying app flow.
  • Tests

    • Removed tests related to the Aesop redesign and onboarding screens.
  • Chores

    • Cleaned up build chunking and documentation references for the removed feature.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 26, 2025

Walkthrough

Removes the Aesop redesign feature flag and all Aesop-related navigation/screens. Simplifies multiple UI components by deleting conditional styles tied to the redesign toggle. Navigation no longer registers the Aesop onboarding screen; the redesign hook, its tests, and AESOP navigation module are deleted.

Changes

Cohort / File(s) Change summary
Feature flag removal
app/src/hooks/useAesopRedesign.ts
Deleted shouldShowAesopRedesign and useAesopRedesign exports and implementation; removed tests referencing them.
Navigation: remove Aesop flow
app/src/navigation/aesop.ts
Deleted the AESOP navigation module and its exports; removed build chunk entry referencing it.
Navigation registration update
app/src/navigation/index.tsx, docs/development-patterns.md
Removed import and spread of getAesopScreens(); navigationScreens no longer includes Aesop overrides; docs updated to reflect removal.
Screen removal
app/src/screens/aesop/DocumentOnboardingScreen.tsx
Deleted the DocumentOnboarding screen, its UI, analytics calls, and default export.
Buttons layout normalization
app/src/components/ButtonsContainer.tsx, app/src/components/buttons/AbstractButton.tsx
Removed redesign-dependent layout logic and imports; fixed layout to column and button/container width to 100%.
Typography normalization
app/src/components/typography/Additional.tsx, app/src/components/typography/Description.tsx
Removed redesign-based conditional styles; typography now uses consistent base font sizes, alignment, and textTransform.
Tests removed
app/tests/src/hooks/useAesopRedesign.test.ts, app/tests/src/navigation.test.ts
Deleted tests covering the redesign toggle and Aesop screen overrides.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant App
  participant Nav as Navigation
  participant Aesop as Aesop Module (removed)
  participant Screens as Remaining Screens

  App->>Nav: initialize navigation
  alt Before (with Aesop)
    Nav->>Aesop: import & register Aesop screens
    App->>Aesop: navigate to DocumentOnboarding (conditional)
  else After (this change)
    Note right of Aesop: module/file deleted
    Nav->>Screens: register remaining screens only
    App->>Screens: navigate within existing flows
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

codex

Suggested reviewers

  • remicolin
  • shazarre

Poem

Toggle retired, old screens unwind,
Buttons align, designs left behind.
Navigation trimmed, tests take their leave,
Cleaner paths now easy to perceive.
Code breathes lighter — onward we weave.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly indicates that the pull request’s primary change is the temporary removal of all AESOP features, succinctly matching the extensive deletions across components, hooks, navigation, tests, and documentation.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch justin/fix-onboarding-camera-screen

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98cbe71 and 472b726.

📒 Files selected for processing (4)
  • app/tests/src/hooks/useAesopRedesign.test.ts (0 hunks)
  • app/tests/src/navigation.test.ts (0 hunks)
  • app/vite.config.ts (0 hunks)
  • docs/development-patterns.md (0 hunks)
💤 Files with no reviewable changes (4)
  • app/tests/src/hooks/useAesopRedesign.test.ts
  • docs/development-patterns.md
  • app/vite.config.ts
  • app/tests/src/navigation.test.ts
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: analyze-android
  • GitHub Check: analyze-ios
  • GitHub Check: e2e-ios
  • GitHub Check: android-build-test
  • GitHub Check: build-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm changed the title SELF-763: clean onboarding camera screens SELF-763: remove aesop features Sep 28, 2025
@transphorm transphorm changed the title SELF-763: remove aesop features SELF-763: remove aesop features for now Sep 28, 2025
@transphorm transphorm merged commit bd8d425 into dev Sep 28, 2025
22 checks passed
@transphorm transphorm deleted the justin/fix-onboarding-camera-screen branch September 28, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants