-
Notifications
You must be signed in to change notification settings - Fork 181
SELF-763: remove aesop features for now #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRemoves the Aesop redesign feature flag and all Aesop-related navigation/screens. Simplifies multiple UI components by deleting conditional styles tied to the redesign toggle. Navigation no longer registers the Aesop onboarding screen; the redesign hook, its tests, and AESOP navigation module are deleted. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant App
participant Nav as Navigation
participant Aesop as Aesop Module (removed)
participant Screens as Remaining Screens
App->>Nav: initialize navigation
alt Before (with Aesop)
Nav->>Aesop: import & register Aesop screens
App->>Aesop: navigate to DocumentOnboarding (conditional)
else After (this change)
Note right of Aesop: module/file deleted
Nav->>Screens: register remaining screens only
App->>Screens: navigate within existing flows
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Style
Refactor
Tests
Chores