Skip to content

Conversation

@Nesopie
Copy link
Collaborator

@Nesopie Nesopie commented Sep 25, 2025

Summary by CodeRabbit

  • New Features

    • Introduced ATTESTATION_ID, a public constant exposing stable identifiers for attestation types (Passport, Biometric ID Card, Aadhaar). Now importable directly from the core package.
  • Chores

    • Bumped SDK Core version to 1.1.0-beta.5.

@cursor
Copy link

cursor bot commented Sep 25, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 17.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Expose a new public constant ATTESTATION_ID via utils/constants.ts and re-export it from sdk/core/src/index.ts. Bump sdk/core package version from 1.1.0-beta.4 to 1.1.0-beta.5. No other code, control flow, or API changes.

Changes

Cohort / File(s) Summary
Version bump
sdk/core/package.json
Increment version: 1.1.0-beta.4 → 1.1.0-beta.5.
Public API exports
sdk/core/src/index.ts
Add export: ATTESTATION_ID from ./utils/constants.js; existing exports unchanged.
Constants: attestation IDs
sdk/core/src/utils/constants.ts
Add exported const ATTESTATION_ID = { PASSPORT: 1, BIOMETRIC_ID_CARD: 2, AADHAAR: 3 } as const.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • fix: aadhaar verifier abi #1096 — Implements Aadhaar-specific verifier logic keyed on attestationId === 3; aligns with newly exported ATTESTATION_ID.AADHAAR.
  • fix: sdk #1085 — Branches on attestationId values (1/2/3); directly related to the introduced ATTESTATION_ID mapping.
  • Feat/aadhaar sdk #1082 — Extends/uses the same attestation ID constants; overlaps with the new ATTESTATION_ID export.

Suggested reviewers

  • 0xturboblitz

Poem

New constants rise, three flags to guide,
Passport, Biometrics, Aadhaar side-by-side.
A tidy bump, a public face,
One index door to every place.
Ship the beta, identifiers aligned.

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/export-attestation-ids

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd6d9ce and 3802a59.

📒 Files selected for processing (3)
  • sdk/core/package.json (1 hunks)
  • sdk/core/src/index.ts (1 hunks)
  • sdk/core/src/utils/constants.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nesopie Nesopie merged commit 8abcb15 into dev Sep 25, 2025
16 checks passed
@Nesopie Nesopie deleted the feat/export-attestation-ids branch September 25, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants