-
Notifications
You must be signed in to change notification settings - Fork 188
Update main with staging 09/21/25 #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
f163367
SDK Go version (#920)
Vishalkulkarni45 bf718d5
Moving proving Utils to common (#935)
aaronmgdr cc28f07
Move proving inputs to the common package (#937)
aaronmgdr af3adbc
Fix mock passport flow (#942)
transphorm a918b45
fix: extractMRZ (#938)
seshanthS d8bf5f9
Move Proving attest and cose (#950)
aaronmgdr 610f195
SELF-253 feat: add user email feedback (#889)
seshanthS 431f556
chore: centralize license header checks (#952)
transphorm cf75bfa
update unsupported passport screen (#953)
remicolin 4367780
Migrate Analytics (#951)
aaronmgdr 6c3cd97
Read document catalog from selfClient (#936)
shazarre 590f188
[SELF-676] feat: upgrade React Native from 0.75.4 to 0.76.9 (#943)
transphorm ebf5d51
fix mobile ci (#964)
transphorm dba8ee1
feat: improve mixpanel flush strategy (#960)
transphorm fc47291
refactor: remove namespace imports (#969)
transphorm 7536875
Mixpanel tweaks (#971)
transphorm 09ad70b
Add DSC parsing check (#836)
transphorm 39976c3
chore(app): upgrade dependencies (#968)
transphorm d9f80f8
Auth Adapter + (#958)
aaronmgdr 0e3e5de
Fix nfc configuration scanning issue (#978)
transphorm 3b53408
Chore fix ios nfc scanning and compiling (#979)
transphorm 39610c3
large runner (#980)
transphorm f98effe
chore: update to macos latest large runner (#981)
transphorm b8f3505
Move loadSelectedDocument to SDK (#967)
shazarre 18697f0
docs: update mobile SDK migration progress (#982)
transphorm ac745bb
moves validateDocument functions into the common package. (#977)
aaronmgdr dc9804f
chore: update yarn.lock
seshanthS 12aff53
chore(app): resolve lint warnings (#990)
transphorm c895396
[SELF-703] feat: Migrate mock generator to mobile sdk (#992)
transphorm e3b5e2e
[SELF-698] scaffold mobile sdk demo app (#993)
transphorm 520c05d
SELF-702: Refactor navigation structure and dev utilities (#994)
transphorm ce58283
feat: clarify proof verification analytics (#996)
transphorm ec732da
feat: increase sha256 byte size and add new rsa circuits (#986)
Nesopie 5a61425
chore: implement google play suggestions (#997)
transphorm b72d909
chore: address yarn lock issues (#1004)
transphorm 145cc89
skip postinstall for ci (#1005)
transphorm ec93ad5
[SELF-654] feat: add native modules (#919)
seshanthS b6d526e
chore: update dev with staging 09/06/25 (#1007)
transphorm ff678b3
chore: fix yarn format (#1009)
transphorm 78b2341
add new home screen (#1019)
remicolin 44bc719
chore: update the cpp build script (#1021)
Nesopie 94651a8
chore: install node (#1022)
Nesopie 48cadcf
chore: use node v22 (#1023)
Nesopie 2200c85
chore: install yarn (#1024)
Nesopie a7d9f05
chore: yarn cache (#1025)
Nesopie b62df10
chore: sanitise node version (#1026)
Nesopie a1c6998
remove lazy loading (#1018)
transphorm 75dee90
chore(ci): improve mobile e2e caching (#1010)
transphorm 3aabfc9
moves ofac and protocol store (#1012)
aaronmgdr 3b93831
chore: remove register id from register circuits (#1028)
Nesopie 5de4aa8
Feat/build cpp (#1029)
Nesopie 99c5612
Remove navigationRef from provingMachine (#1011)
shazarre c1042f5
SDK: minimize amount of data sent through PROVING_PASSPORT_NOT_SUPPOR…
shazarre 990bee0
Fix mock passport generation (#1031)
transphorm b50a289
Feat/aadhaar (#949)
Nesopie 5702f55
fix: CLA not supported (#1027)
seshanthS 5a65afa
chore: bump app version v2.6.5 (#1034)
transphorm f343cbb
chore: fix nfc passport reader private repo access (#1042)
transphorm e9ae259
build(android): support 16KB page size (#1043)
transphorm 45ba5bc
chore: bump v2.6.5 for release (#1036)
transphorm 87424d9
Feat/build aadhaar (#1044)
Nesopie b26aca0
fix aadhaar register output after building the cpp circuit (#1045)
Nesopie 88848ef
fix: metro js crypto module build issues (#1047)
transphorm 054cfaf
feat: add new verifiers (#1049)
Nesopie 2ef955a
fix: ofac check to aadhaar (#1050)
Nesopie 0518217
fix: hub-v2 (#1051)
Nesopie 4db3734
Add DisclosureVerified event for comprehensive verification tracking …
kevinsslin f416211
move clearPassportData, markCurrentDocumentAsRegistered, reStorePassp…
shazarre 1f362b3
Move self app store to mobile sdk (#1040)
aaronmgdr c2ec367
chore(mobile-sdk-alpha): remove unused tslib dependency (#1053)
aaronmgdr 00a0967
remove unused imports (#1055)
aaronmgdr 36ffe36
fix: sha256 signed attr tests (#1058)
Nesopie 5b02868
fix mock screen launch (#1059)
transphorm 85df676
Hotfix: Belgium ID cards (#1061)
seshanthS 94d8fca
fix: OFAC trees not found (#1060)
transphorm 99165c9
[SELF-723] feat: add structured NFC and Proof logging (#1048)
transphorm 51a12a1
skip on dev (#1063)
transphorm 3d0a5b4
don't get fancy just disable (#1064)
transphorm be2b52a
saw it building so gonna try (#1065)
transphorm e464bde
Merge branch 'dev' into staging
transphorm 4cf5b5f
Dev (#1074)
remicolin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,44 @@ | ||
| version: 2 | ||
| exclusion_globs: | ||
| # GitGuardian configuration for ggshield | ||
| # This file configures which files and secrets to ignore during scanning | ||
|
|
||
| # Ignore specific file patterns | ||
| paths-ignore: | ||
| # Mock certificates for testing (these are intentionally committed test data) | ||
| - "**/mock_certificates/**/*.key" | ||
| - "**/mock_certificates/**/*.crt" | ||
| - "**/mock_certificates/**/*.pem" | ||
| - "**/constants/mockCertificates.ts" | ||
| - "common/src/mock_certificates/**" | ||
| - "common/src/constants/mockCertificates.ts" | ||
| - "common/src/mock_certificates/aadhaar/mockAadhaarCert.ts" | ||
| - "common/src/utils/passports/genMockIdDoc.ts" | ||
|
|
||
| # Test data files | ||
| - "**/test/**/*.key" | ||
| - "**/test/**/*.crt" | ||
| - "**/test/**/*.pem" | ||
| - "**/tests/**/*.key" | ||
| - "**/tests/**/*.crt" | ||
| - "**/tests/**/*.pem" | ||
|
|
||
| # Mock data files | ||
| - "**/mock/**/*.key" | ||
| - "**/mock/**/*.crt" | ||
| - "**/mock/**/*.pem" | ||
|
|
||
| # Demo app test data | ||
| - "**/demo-app/**/mock/**" | ||
| - "**/demo-app/**/test-data/**" | ||
| - "**/test-data/**" | ||
| - "**/mock-data/**" | ||
|
|
||
| # Generated test files | ||
| - "**/generated/**/*.key" | ||
| - "**/generated/**/*.crt" | ||
| - "**/generated/**/*.pem" | ||
|
|
||
| # Ignore specific secret types for mock files | ||
| secrets-ignore: | ||
| - "Generic Private Key" # For mock certificate keys | ||
| - "Generic Certificate" # For mock certificates | ||
| - "RSA Private Key" # For mock RSA keys | ||
| - "EC Private Key" # For mock EC keys |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: cache-built-deps | ||
| description: Cache built JS artifacts (common + mobile-sdk-alpha) | ||
| inputs: | ||
| cache-version: | ||
| description: Cache version string for cache key | ||
| required: true | ||
| outputs: | ||
| cache-hit: | ||
| description: Whether cache was hit during restore | ||
| value: ${{ steps.restore.outputs.cache-hit }} | ||
| runs: | ||
| using: composite | ||
| steps: | ||
| - id: restore | ||
| name: Restore Built Dependencies | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: | | ||
| common/dist | ||
| packages/mobile-sdk-alpha/dist | ||
| key: built-deps-${{ inputs.cache-version }}-${{ hashFiles('common/**/*', 'packages/mobile-sdk-alpha/**/*', '!common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }} | ||
| fail-on-cache-miss: false | ||
| - name: Save Built Dependencies | ||
| if: steps.restore.outputs.cache-hit != 'true' | ||
| uses: actions/cache/save@v4 | ||
| with: | ||
| path: | | ||
| common/dist | ||
| packages/mobile-sdk-alpha/dist | ||
| key: built-deps-${{ inputs.cache-version }}-${{ hashFiles('common/**/*', 'packages/mobile-sdk-alpha/**/*', '!common/dist/**', '!packages/mobile-sdk-alpha/dist/**') }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| name: Clone android-passport-reader | ||
| description: "Clones the android-passport-reader repository if it does not exist" | ||
|
|
||
| inputs: | ||
| working_directory: | ||
| description: "Working directory path (where android/ subdirectory is located)" | ||
| required: false | ||
| default: "." | ||
| selfxyz_internal_pat: | ||
| description: "SELFXYZ internal repository PAT for private repository access" | ||
| required: false | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Clone android-passport-reader | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| # Check if PAT is available for private module cloning | ||
| if [ -z "${{ inputs.selfxyz_internal_pat }}" ]; then | ||
| echo "🔒 Skipping private module cloning (no PAT provided)" | ||
| echo "ℹ️ This is expected for forked PRs - build will continue without private modules" | ||
| exit 0 | ||
| fi | ||
|
|
||
| cd "${{ inputs.working_directory }}" | ||
|
|
||
| if [ ! -d "android/android-passport-reader" ]; then | ||
| echo "📦 Cloning android-passport-reader for build..." | ||
| cd android | ||
|
|
||
| # Clone using PAT (embed temporarily, then scrub) | ||
| if git clone --depth 1 --quiet "https://${{ inputs.selfxyz_internal_pat }}@github.com/selfxyz/android-passport-reader.git"; then | ||
| echo "✅ android-passport-reader cloned successfully" | ||
| # Immediately scrub the credential from remote URL for security | ||
| git -C android-passport-reader remote set-url origin https://github.com/selfxyz/android-passport-reader.git || true | ||
| else | ||
| echo "❌ Failed to clone android-passport-reader" | ||
| echo "Please ensure a valid SELFXYZ internal PAT is provided to this action" | ||
| exit 1 | ||
| fi | ||
| elif [ "$CI" = "true" ]; then | ||
| echo "⚠️ android-passport-reader exists in CI - this is unexpected" | ||
| echo "📁 Directory contents:" | ||
| ls -la android/android-passport-reader/ || true | ||
| else | ||
| echo "📁 android-passport-reader already exists - preserving existing directory" | ||
| echo "ℹ️ Local development environment detected - your changes are safe" | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical security concern: PAT exposure in git clone URL.
The PAT is embedded directly in the git clone URL, which could potentially expose it in logs or process lists. While you do scrub the credential afterward, this creates a window of vulnerability.
Consider using git credential helper or environment variables:
📝 Committable suggestion
🤖 Prompt for AI Agents