chore update mobile app types

[transphorm]

Summary by CodeRabbit

• New Features

  • No user-facing changes.

• Refactor

  • Improved SVG mock behavior for more consistent rendering.
  • Optimized NFC scan screen with memoized context for more consistent analytics and logging.
  • Switched a component to a named export and removed unused safe-area handling to simplify UI code.

• Tests

  • Cleaned up test imports to remove unused dependencies.

• Style

  • Minor formatting-only updates.

• Chores

  • Removed unused type-only imports and commented out redundant extraction of unused fields.

[coderabbitai]

Caution

Review failed

The head commit changed during the review from e710611 to cd0e5ee.

Walkthrough

Refactors the react-native-svg mock to use named forwardRef/createElement, removes unused imports, adjusts imports for ProofHistoryList to a named export, memoizes baseContext in NFC scan screen and updates hook dependencies, comments out unused NFC parsing fields, streamlines a test import, and reformats a date construction.

Changes

Cohort / File(s)	Summary
SVG mock refactor app/src/mocks/react-native-svg.ts	Switched to named forwardRef and createElement; updated Circle, Path, Rect, Svg, and SvgXml to use these; no API shape changes beyond internal wrapping style.
Navigation import cleanup app/src/navigation/index.tsx	Removed unused type-only import ProofHistory from @/stores/proof-types.
NFC scan context memoization app/src/screens/document/DocumentNFCScanScreen.tsx	Added useMemo for baseContext and propagated it to hooks/callback dependencies (mount/unmount logs, error modal, NFC support checks, focus effects, verify press, long scan handler).
Home screens: imports and exports app/src/screens/home/IdDetailsScreen.tsx, app/src/screens/home/ProofHistoryList.tsx	IdDetailsScreen: switched ProofHistoryList to named import; removed unused ScrollView and useRoute. ProofHistoryList: removed useSafeAreaInsets usage.
NFC parsing cleanup app/src/utils/nfcScanner.ts	Commented out unused parsed fields for iOS and Android; retained certificate/PEM extraction and returned shape.
Tests import simplification app/tests/utils/proving/provingMachine.disclose.stateless.test.ts	Removed top-level useProtocolStore import; kept useSelfAppStore; test behavior unchanged.
SDK formatting sdk/core/src/SelfBackendVerifier.ts	Reformatted Date(...) initialization across multiple lines; no logic changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Screen as DocumentNFCScanScreen
  participant NFC as NFC Module
  participant Analytics as Analytics/Logger

  Note over Screen: baseContext = useMemo(route.params)
  User->>Screen: Open screen
  activate Screen
  Screen->>Analytics: log("screen_mount", baseContext)
  Screen->>NFC: checkNfcSupport(baseContext)
  NFC-->>Screen: supportStatus
  Screen-->>User: UI updates

  User->>Screen: Tap Verify
  Screen->>NFC: startScan(baseContext)
  NFC-->>Screen: scanResult / error
  alt success
    Screen->>Analytics: log("nfc_success", baseContext)
    Screen-->>User: Show result
  else error
    Screen->>Analytics: log("nfc_error", baseContext)
    Screen-->>User: Open error modal
  end

  User->>Screen: Navigate away
  Screen->>Analytics: log("screen_unmount", baseContext)
  deactivate Screen

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• remove lazy loading #1018 — Modifies app/src/mocks/react-native-svg.ts with similar forwardRef/createElement edits.

Suggested labels

codex

Suggested reviewers

• remicolin
• aaronmgdr

Poem

In circuits of ink and NFC’s hum,
Refs now forward, elements come.
Contexts memoized, tidy and keen,
Proofs march neatly across the screen.
Unused bits silenced, timers aligned—
A cleaner path for code refined. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "chore update mobile app types" is concise and reasonably reflects the PR's primary focus on TypeScript/type-related changes (for example, react-native-svg mock signatures and removal of a type-only import), although the changeset also includes some refactors and behavioral edits; overall the title is acceptably related to the changes.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/src/mocks/react-native-svg.ts (1)

42-62: Sanitize XML, prevent prop override of innerHTML, and fix width/height fallback.

• Raw dangerouslySetInnerHTML is an XSS risk; mirror the DOMPurify behavior used in SvgXmlWrapper.web.tsx.
• Don’t allow callers to override dangerouslySetInnerHTML via ...props.
• Using || for numeric width/height treats 0 as falsy; use nullish coalescing so 0 remains valid.

Apply this diff:

@@
-import React, { createElement, forwardRef } from 'react';
+import React, { createElement, forwardRef } from 'react';
+import DOMPurify from 'dompurify';
@@
-export const SvgXml = forwardRef<
+export const SvgXml = forwardRef<
   HTMLDivElement,
   {
     xml: string;
     width?: number;
     height?: number;
     style?: React.CSSProperties;
   }
 >(({ xml, width, height, style, ...props }, ref) => {
-  return createElement('div', {
-    ref,
-    style: {
-      width: width || 'auto',
-      height: height || 'auto',
-      display: 'inline-block',
-      ...style,
-    },
-    dangerouslySetInnerHTML: { __html: xml },
-    ...props,
-  });
+  const safe =
+    typeof window !== 'undefined'
+      ? DOMPurify(window).sanitize(xml, { USE_PROFILES: { svg: true, svgFilters: true } })
+      : xml;
+  // Prevent callers from overriding the sanitized HTML.
+  const { dangerouslySetInnerHTML: _ignored, ...rest } = props as { dangerouslySetInnerHTML?: unknown };
+  return createElement('div', {
+    ...rest,
+    ref,
+    style: {
+      width: width ?? 'auto',
+      height: height ?? 'auto',
+      display: 'inline-block',
+      ...style,
+    },
+    dangerouslySetInnerHTML: { __html: safe },
+  });
 });

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d648ef and 309c19e.

📒 Files selected for processing (8)

• app/src/mocks/react-native-svg.ts (2 hunks)
• app/src/navigation/index.tsx (0 hunks)
• app/src/screens/document/DocumentNFCScanScreen.tsx (7 hunks)
• app/src/screens/home/IdDetailsScreen.tsx (1 hunks)
• app/src/screens/home/ProofHistoryList.tsx (0 hunks)
• app/src/utils/nfcScanner.ts (2 hunks)
• app/tests/utils/proving/provingMachine.disclose.stateless.test.ts (1 hunks)
• sdk/core/src/SelfBackendVerifier.ts (1 hunks)

💤 Files with no reviewable changes (2)

• app/src/navigation/index.tsx
• app/src/screens/home/ProofHistoryList.tsx

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/technical-specification.mdc)

**/*.{ts,tsx}: Define IdentityCommitment with fields: commitment (Poseidon hash), nullifier (domain-separated), timestamp (UTC number), version (circuit version), documentType ('passport' | 'eu_id_card')
Define DSCKeyCommitment with fields: publicKeyHash (Poseidon hash), certificateChain (hashes), revocationStatus (boolean), issuer (country code)
Define VerificationConfig with fields: circuitVersion (semver), complianceRules array, timeWindow (seconds, 24h), clockDrift (±5 min), trustAnchors, revocationRoots, timeSource (NTP), nullifierScope (domain separation)

Files:

• sdk/core/src/SelfBackendVerifier.ts
• app/tests/utils/proving/provingMachine.disclose.stateless.test.ts
• app/src/utils/nfcScanner.ts
• app/src/screens/home/IdDetailsScreen.tsx
• app/src/screens/document/DocumentNFCScanScreen.tsx
• app/src/mocks/react-native-svg.ts

sdk/**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

sdk/**/*.{ts,tsx,js,jsx}: Review SDK packages for:

• Public API design and stability
• Asynchronous flows and error handling
• Security and input validation
• Compatibility across environments

Files:

• sdk/core/src/SelfBackendVerifier.ts

**/*.{test,spec}.{ts,js,tsx,jsx}

⚙️ CodeRabbit configuration file

**/*.{test,spec}.{ts,js,tsx,jsx}: Review test files for:

• Test coverage completeness
• Test case quality and edge cases
• Mock usage appropriateness
• Test readability and maintainability

Files:

• app/tests/utils/proving/provingMachine.disclose.stateless.test.ts

app/src/**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

app/src/**/*.{ts,tsx,js,jsx}: Review React Native TypeScript code for:

• Component architecture and reusability
• State management patterns
• Performance optimizations
• TypeScript type safety
• React hooks usage and dependencies
• Navigation patterns

Files:

• app/src/utils/nfcScanner.ts
• app/src/screens/home/IdDetailsScreen.tsx
• app/src/screens/document/DocumentNFCScanScreen.tsx
• app/src/mocks/react-native-svg.ts

🧠 Learnings (14)

📚 Learning: 2025-08-24T18:55:07.940Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/technical-specification.mdc:0-0
Timestamp: 2025-08-24T18:55:07.940Z
Learning: Applies to **/*.{ts,tsx} : Define VerificationConfig with fields: circuitVersion (semver), complianceRules array, timeWindow (seconds, 24h), clockDrift (±5 min), trustAnchors, revocationRoots, timeSource (NTP), nullifierScope (domain separation)

Applied to files:

• sdk/core/src/SelfBackendVerifier.ts

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Use actual imports from selfxyz/mobile-sdk-alpha in tests

Applied to files:

• app/tests/utils/proving/provingMachine.disclose.stateless.test.ts

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Do NOT mock selfxyz/mobile-sdk-alpha in tests (avoid jest.mock('selfxyz/mobile-sdk-alpha') and replacing real functions with mocks)

Applied to files:

• app/tests/utils/proving/provingMachine.disclose.stateless.test.ts

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Never use real user PII in tests; use only synthetic, anonymized, or approved test vectors

Applied to files:

• app/tests/utils/proving/provingMachine.disclose.stateless.test.ts

📚 Learning: 2025-08-26T14:49:11.190Z

Learnt from: shazarre
PR: selfxyz/self#936
File: app/src/screens/passport/PassportNFCScanScreen.tsx:28-31
Timestamp: 2025-08-26T14:49:11.190Z
Learning: SelfClientProvider is wrapped in app/App.tsx, providing context for useSelfClient() hook usage throughout the React Native app navigation stacks.

Applied to files:

• app/tests/utils/proving/provingMachine.disclose.stateless.test.ts
• app/src/screens/home/IdDetailsScreen.tsx

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to native/ios/**/*.{swift} : iOS NFC: implement custom PassportReader as a Swift module

Applied to files:

• app/src/utils/nfcScanner.ts

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Ensure parseNFCResponse() works with representative, synthetic NFC data

Applied to files:

• app/src/utils/nfcScanner.ts

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Test isPassportDataValid() with realistic synthetic passport data (never real user data)

Applied to files:

• app/src/utils/nfcScanner.ts

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to native/android/**/*.{kt,kts} : Android NFC: implement RNPassportReaderModule in Kotlin

Applied to files:

• app/src/utils/nfcScanner.ts

📚 Learning: 2025-09-10T14:47:40.945Z

Learnt from: shazarre
PR: selfxyz/self#1041
File: app/src/providers/passportDataProvider.tsx:297-301
Timestamp: 2025-09-10T14:47:40.945Z
Learning: In app/src/providers/passportDataProvider.tsx: The deleteDocumentDirectlyFromKeychain function is a low-level utility used by the DocumentsAdapter and should not include error handling since callers like deleteDocument() already implement appropriate try/catch with logging for Keychain operations.

Applied to files:

• app/src/utils/nfcScanner.ts

📚 Learning: 2025-08-29T15:31:15.924Z

Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Verify extractMRZInfo() using published sample MRZ strings (e.g., ICAO examples)

Applied to files:

• app/src/utils/nfcScanner.ts

📚 Learning: 2025-08-26T14:41:41.821Z

Learnt from: shazarre
PR: selfxyz/self#936
File: app/src/screens/aesop/PassportOnboardingScreen.tsx:0-0
Timestamp: 2025-08-26T14:41:41.821Z
Learning: When verifying provider hierarchies in React Native apps, always check the main App.tsx file at the app root, not just navigation/index.tsx and layout files, as providers are often configured at the top-level App component.

Applied to files:

• app/src/screens/home/IdDetailsScreen.tsx

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to src/**/*.{tsx} : Ensure proper cleanup in useEffect and on component unmount

Applied to files:

• app/src/screens/document/DocumentNFCScanScreen.tsx

📚 Learning: 2025-08-24T18:52:25.796Z

Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Use custom hooks for complex state (useModal, useHapticNavigation)

Applied to files:

• app/src/screens/document/DocumentNFCScanScreen.tsx

🧬 Code graph analysis (2)

app/src/utils/nfcScanner.ts (1)

app/ios/PassportReader.swift (6)

• iOS (32-364)
• scanPassport (78-239)
• convertDataGroupHashToSerializableFormat (335-342)
• convertDataGroupToSerializableFormat (352-358)
• iOS (13-23)
• serializeSignature (279-287)

app/src/mocks/react-native-svg.ts (2)

app/src/components/homeScreen/SvgXmlWrapper.web.tsx (1)

• SvgXml (20-39)

app/src/components/homeScreen/SvgXmlWrapper.native.tsx (1)

• SvgXml (16-16)

🪛 GitHub Actions: Common CI

app/src/screens/document/DocumentNFCScanScreen.tsx

[error] 134-134: TypeScript error TS2345: Argument of type '{ stage: string; sessionId: string; platform: 'ios' | 'android'; scanType: string; }' is not assignable to parameter of type 'NFCScanContext'.

🪛 GitHub Actions: Workspace CI

app/src/screens/document/DocumentNFCScanScreen.tsx

[error] 134-134: TS2345: Argument of type '{ stage: string; sessionId: string; platform: "ios" | "android"; scanType: string; }' is not assignable to parameter of type 'NFCScanContext'.

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: e2e-ios
• GitHub Check: build-deps
• GitHub Check: analyze-ios
• GitHub Check: analyze-android

🔇 Additional comments (11)

sdk/core/src/SelfBackendVerifier.ts (1)

271-273: Formatting-only EOD computation — OK

No behavior change; the EOD math remains 23:59:59 local. Safe to merge.

app/tests/utils/proving/provingMachine.disclose.stateless.test.ts (1)

6-6: Import cleanup keeps SDK store usage intact — OK

Tests still seed state via useSelfAppStore and isolate useProtocolStore per test. No risk.

app/src/utils/nfcScanner.ts (2)

156-165: iOS: Commenting optional fields doesn’t alter returned shape — OK

The PassportData payload keys consumed downstream are unchanged.

---

206-212: Android: Optional field comments are no-ops — OK

Return structure remains stable; parsers keep working.

app/src/screens/home/IdDetailsScreen.tsx (1)

16-16: Switch to named export for ProofHistoryList — OK

Matches module’s updated export; no runtime impact.

app/src/screens/document/DocumentNFCScanScreen.tsx (5)

200-201: Open-error modal logging context

Good use of shared baseContext; ensure userId is present per the fix above to avoid repeat TS2345s.

---

245-245: Capability check logging context

Same note: with userId in baseContext, this satisfies NFCScanContext.

---

495-495: onVerifyPress deps include baseContext

Correct to keep analytics/logging aligned with scan type toggles; ensure the baseContext typing fix is applied.

---

590-590: useFocusEffect deps include baseContext

Looks good; avoids stale values in focus/blur logs once baseContext is typed and complete.

---

118-125: Incorrect — userId is optional on BaseContext; don't add useSelfAppStore import

app/src/Sentry.ts declares BaseContext.userId?: string and NFCScanContext extends it, and DocumentNFCScanScreen already supplies sessionId/platform/scanType and adds stage at each log call (see app/src/screens/document/DocumentNFCScanScreen.tsx ~lines 118–125). Adding useSelfAppStore is unnecessary for type-safety; if TS still complains, annotate baseContext with a type instead (e.g. useMemo<Omit<NFCScanContext,'stage'>>(...)) to satisfy the compiler.

Likely an incorrect or invalid review comment.

app/src/mocks/react-native-svg.ts (1)

5-5: No action needed on import line.
Import style is fine; leave as-is unless your TS config enforces type‑only imports.

[coderabbitai]

⚠️ Potential issue

Forwarded ref can be shadowed by a user-provided prop. Place ref last.

Spreading ...props after ref lets a stray ref prop override the forwarded ref, breaking ref wiring. Put ref last across these elements.

Apply this diff:

-  return createElement('circle', { ref, ...props });
+  return createElement('circle', { ...props, ref });

-    return createElement('path', { ref, ...props });
+    return createElement('path', { ...props, ref });

-    return createElement('rect', { ref, ...props });
+    return createElement('rect', { ...props, ref });

-    return createElement('svg', { ref, ...props });
+    return createElement('svg', { ...props, ref });

Also applies to: 16-20, 24-28, 33-37

🤖 Prompt for AI Agents

In app/src/mocks/react-native-svg.ts around lines 7-12 (and also apply same
change to ranges 16-20, 24-28, 33-37), the forwarded ref is being passed before
spreading props which allows a user-provided ref in ...props to shadow the
forwarded ref; update each createElement call so the ref property is placed
after the spread (i.e., spread props first, then set ref last) to ensure the
forwarded ref cannot be overridden.

[coderabbitai]

⚠️ Potential issue

All logNFCEvent calls must pass NFCScanContext

Once baseContext includes userId, spreading with stage should satisfy the type at every call site (this one included). If TS still complains, cast per call: { ...baseContext, stage: 'mount' } as NFCScanContext.

🤖 Prompt for AI Agents

In app/src/screens/document/DocumentNFCScanScreen.tsx around line 141, the
logNFCEvent call is missing an NFCScanContext-typed object; update the call to
pass { ...baseContext, stage: 'mount' } so the staged spread satisfies the
NFCScanContext type (if TypeScript still complains, cast each call as {
...baseContext, stage: 'mount' } as NFCScanContext).