Skip to content

address version mismatches and package resolutions #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 19, 2025
Merged

address version mismatches and package resolutions #1081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e40179
fix package version mismatches and resolutions
transphorm Sep 17, 2025
b1bce3a
fixes
transphorm Sep 17, 2025
a0de75d
update lock
transphorm Sep 17, 2025
72e29dc
Merge branch 'dev' into justin/address-package-dependency-warnings
transphorm Sep 18, 2025
78d04ec
Merge branch 'dev' into justin/address-package-dependency-warnings
transphorm Sep 18, 2025
45d826b
fix comma
transphorm Sep 18, 2025
e4fdd5f
fixes
transphorm Sep 18, 2025
bd2300b
fix packages
transphorm Sep 18, 2025
0312a8b
update packages
transphorm Sep 18, 2025
03cc947
remove firebase analytics. not needed
transphorm Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ target "Self" do
pod "Firebase", :modular_headers => true
pod "FirebaseCore", :modular_headers => true
pod "FirebaseCoreInternal", :modular_headers => true
pod "FirebaseAnalytics", :modular_headers => true
pod "GoogleUtilities", :modular_headers => true
pod "FirebaseMessaging"

Expand Down
3 changes: 2 additions & 1 deletion app/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2130,6 +2130,7 @@ DEPENDENCIES:
- fast_float (from `../../node_modules/react-native/third-party-podspecs/fast_float.podspec`)
- FBLazyVector (from `../../node_modules/react-native/Libraries/FBLazyVector`)
- Firebase
- FirebaseAnalytics
- FirebaseCore
- FirebaseCoreInternal
- FirebaseMessaging
Expand Down Expand Up @@ -2571,6 +2572,6 @@ SPEC CHECKSUMS:
SwiftyTesseract: 1f3d96668ae92dc2208d9842c8a59bea9fad2cbb
Yoga: 1259c7a8cbaccf7b4c3ddf8ee36ca11be9dee407

PODFILE CHECKSUM: 11b5d4e7ed4c53b5020678593b6ec1015cbd3f47
PODFILE CHECKSUM: 8a63cefda7649b1efdae9ada9addff179eae4375

COCOAPODS: 1.16.2
7 changes: 3 additions & 4 deletions app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@
"web:build": "yarn build:deps && vite build",
"web:preview": "vite preview"
},
"resolutions": {
"punycode": "npm:punycode.js@^2.3.1"
},
"overrides": {
"punycode": "npm:punycode.js@^2.3.1"
},
Expand Down Expand Up @@ -159,13 +156,13 @@
"@react-native/typescript-config": "0.76.9",
"@tamagui/types": "1.126.14",
"@tamagui/vite-plugin": "1.126.14",
"@testing-library/react-hooks": "^8.0.1",
"@testing-library/react-native": "^13.3.3",
"@tsconfig/react-native": "^3.0.6",
"@types/add": "^2",
"@types/dompurify": "^3.2.0",
"@types/elliptic": "^6",
"@types/jest": "^29.5.14",
"@types/node": "^22.18.3",
"@types/node-forge": "^1.3.14",
"@types/path-browserify": "^1",
"@types/react": "^18.3.4",
Expand All @@ -191,9 +188,11 @@
"eslint-plugin-prettier": "^5.2.6",
"eslint-plugin-simple-import-sort": "^12.1.1",
"eslint-plugin-sort-exports": "^0.9.1",
"hermes-eslint": "^0.19.1",
"jest": "^29.6.3",
"path-browserify": "^1.0.1",
"prettier": "^3.5.3",
"prop-types": "^15.8.1",
"react-native-svg-transformer": "^1.5.1",
"react-test-renderer": "^18.3.1",
"rollup-plugin-visualizer": "^6.0.3",
Expand Down
2 changes: 1 addition & 1 deletion circuits/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"@types/chai-as-promised": "^7.1.6",
"@types/circomlibjs": "^0.1.6",
"@types/mocha": "^10.0.10",
"@types/node": "^22.0.0",
"@types/node": "^22.18.3",
"@types/node-forge": "^1.3.5",
"@yarnpkg/sdks": "^3.2.0",
"chai": "^4.4.1",
Expand Down
2 changes: 1 addition & 1 deletion common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@
},
"devDependencies": {
"@types/js-sha1": "^0.6.3",
"@types/node": "^22.0.0",
"@types/node": "^22.18.3",
"@types/node-forge": "^1.3.10",
"@typescript-eslint/eslint-plugin": "^8.0.0",
"@typescript-eslint/parser": "^8.0.0",
Expand Down
2 changes: 2 additions & 0 deletions contracts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
"@types/circomlibjs": "^0.1.6",
"@types/jest": "^29.5.14",
"@types/mocha": "^10.0.6",
"@types/node": "^22.18.3",
"@types/snarkjs": "^0.7.7",
"chai": "^4.4.1",
"dotenv-cli": "^7.4.2",
Expand All @@ -120,6 +121,7 @@
"prettier": "3.5.3",
"prettier-plugin-solidity": "^2.1.0",
"solidity-coverage": "^0.8.14",
"ts-node": "^10.9.2",
"tsup": "^8.5.0",
"typechain": "^8.3.2",
"typescript": "^5.9.2"
Expand Down
9 changes: 4 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"scripts": {
"build": "yarn workspaces foreach --topological-dev --parallel --exclude @selfxyz/contracts -i --all run build",
"check:versions": "node scripts/check-package-versions.mjs",
"reinstall-app": "rm -rf node_modules app/node_modules && yarn install && yarn workspace @selfxyz/mobile-app run install-app",
"format": "SKIP_BUILD_DEPS=1 yarn format:root && yarn format:github && SKIP_BUILD_DEPS=1 yarn workspaces foreach --parallel -i --all --exclude self-workspace-root run format",
"format:github": "yarn prettier --parser yaml --write .github/**/*.yml --single-quote false",
"format:root": "echo 'format markdown' && yarn prettier --parser markdown --write *.md && echo 'format yaml' && yarn prettier --parser yaml --write .*.{yml,yaml} --single-quote false && yarn prettier --write scripts/**/*.{js,mjs,ts} && yarn prettier --parser json --write scripts/**/*.json",
Expand All @@ -24,6 +23,7 @@
"lint:headers": "node scripts/check-duplicate-headers.cjs . && node scripts/check-license-headers.mjs . --check",
"lint:headers:fix": "node scripts/check-duplicate-headers.cjs . && node scripts/check-license-headers.mjs . --fix",
"prepare": "husky",
"reinstall-app": "rm -rf node_modules app/node_modules && yarn install && yarn workspace @selfxyz/mobile-app run install-app",
"sort-package-jsons": "find . -name 'package.json' -not -path './node_modules/*' -not -path './*/node_modules/*' | xargs npx sort-package-json",
"test": "yarn workspaces foreach --parallel -i --all run test",
"test:license-headers": "cd scripts/tests && node check-license-headers.test.mjs",
Expand All @@ -32,13 +32,12 @@
"resolutions": {
"@babel/core": "^7.28.4",
"@babel/runtime": "^7.28.4",
"@tamagui/animations-react-native": "1.126.14",
"@tamagui/toast": "1.126.14",
"@types/node": "^22.18.3",
"@types/react": "^18.3.4",
"@types/react-dom": "^18.3.0",
"@typescript-eslint/eslint-plugin": "^8.43.0",
"@typescript-eslint/parser": "^8.43.0",
"punycode": "npm:punycode.js@^2.3.1",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-native": "0.76.9"
},
"devDependencies": {
Expand Down
4 changes: 3 additions & 1 deletion packages/mobile-sdk-alpha/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,15 @@
"eslint-plugin-sort-exports": "^0.9.1",
"jsdom": "^24.0.0",
"prettier": "^3.5.3",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"tsup": "^8.0.1",
"typescript": "^5.9.2",
"vitest": "^1.6.0"
},
"peerDependencies": {
"react": "^18.3.1",
"react-native": "^0.76.9",
"react-native": "0.76.9",
"tamagui": "^1.126.0"
},
Comment on lines +98 to 100
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Pinning react-native to an exact version will break consumers on patch releases

Switching peerDependency react-native from ^0.76.9 to 0.76.9 forces an exact match and will cause npm/yarn/pnpm conflicts for apps on 0.76.x patch updates. Keep the caret to allow patch alignment within 0.76.x.

Apply:

 "peerDependencies": {
   "react": "^18.3.1",
-  "react-native": "0.76.9",
+  "react-native": "^0.76.9",
   "tamagui": "^1.126.0"
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"react-native": "0.76.9",
"tamagui": "^1.126.0"
},
"react-native": "^0.76.9",
"tamagui": "^1.126.0"
},
🤖 Prompt for AI Agents 
packages/mobile-sdk-alpha/package.json lines 98-100: the react-native
peerDependency was pinned to an exact version ("0.76.9"); change it back to a
caret range by updating the value to "^0.76.9" so consumers on 0.76.x patch
releases can resolve correctly; update the package.json entry and run a quick
install/lockfile update to ensure the change is reflected.

"packageManager": "[email protected]",
Expand Down
5 changes: 4 additions & 1 deletion scripts/check-package-versions.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ const hardhatPackages = [

// Testing framework
const testingPackages = [
'@testing-library/react-hooks',
'@testing-library/react-native',
'@babel/core',
'@babel/runtime',
Expand Down Expand Up @@ -152,6 +151,9 @@ const pmVersions = new Map();
const workflowVersions = new Map();
const engineVersions = new Map();

// Packages that are intentionally different for technical reasons
const intentionallyDifferentPackages = [];

Comment on lines +154 to +156
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

“Intentional differences” still counted as mismatches, causing confusing output

Packages listed in intentionallyDifferentPackages are not excluded in the “OTHER VERSION MISMATCHES” section and still flip hasOtherIssues=true. Compute hasIntentionalDifferences dynamically and skip them in the first pass to avoid noise and incorrect CI summaries.

Apply:

 // Packages that are intentionally different for technical reasons
-const intentionallyDifferentPackages = [];
+const intentionallyDifferentPackages = [];
@@
-let hasIntentionalDifferences = intentionallyDifferentPackages.length > 0;
+// Only true if at least one intentionally-different package actually has a mismatch
+let hasIntentionalDifferences = intentionallyDifferentPackages.some(pkg => {
+  const versions = depVersions.get(pkg);
+  return versions && versions.size > 1;
+});
@@
 for (const category of categories) {
   let categoryHasIssues = false;
 
   for (const pkg of category.packages) {
-    if (criticalPackages.includes(pkg)) continue; // Skip critical packages, already shown above
+    if (
+      criticalPackages.includes(pkg) ||
+      intentionallyDifferentPackages.includes(pkg)
+    ) {
+      continue; // Skip critical and intentional differences in this section
+    }
 
     const versions = depVersions.get(pkg);
     if (versions && versions.size > 1) {

Also applies to: 330-331, 344-374

function record(map, key, version, filePath) {
if (!version) return;
if (!map.has(key)) map.set(key, new Map());
Expand Down Expand Up @@ -325,6 +327,7 @@ if (pm && pm.size > 1) {

// Check for other package mismatches
let hasOtherIssues = false;
let hasIntentionalDifferences = intentionallyDifferentPackages.length > 0;
const categories = [
{ name: 'React Native', packages: reactNativePackages },
{ name: 'Tamagui UI', packages: tamaguiPackages },
Expand Down
5 changes: 3 additions & 2 deletions sdk/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@types/circomlibjs": "^0.1.6",
"@types/expect": "^24.3.0",
"@types/mocha": "^10.0.6",
"@types/node": "^22.0.0",
"@types/node": "^22.18.3",
"@types/node-forge": "^1.3.5",
"@types/snarkjs": "^0.7.8",
"axios": "^1.7.2",
Expand All @@ -72,7 +72,8 @@
"ts-node": "^10.9.2",
"tsup": "^8.5.0",
"typechain": "^8.3.2",
"typescript": "^5.9.2"
"typescript": "^5.9.2",
"webpack": "^5.0.0"
},
"engines": {
"node": ">=22 <23"
Expand Down
5 changes: 3 additions & 2 deletions sdk/qrcode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
},
"devDependencies": {
"@size-limit/preset-big-lib": "^11.2.0",
"@types/node": "^22.0.0",
"@types/node": "^22.18.3",
"@types/node-forge": "^1",
"@types/react": "^18.3.4",
"@types/react-dom": "^18.3.0",
Expand All @@ -109,7 +109,8 @@
"ts-mocha": "^10.0.0",
"ts-node": "^10.9.2",
"tsup": "^8.5.0",
"typescript": "^5.9.2"
"typescript": "^5.9.2",
"webpack": "^5.0.0"
},
"peerDependencies": {
"lottie-react": "^2.4.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/qrcode/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"exclude": [
"node_modules",
"**/__tests__/*",
"dist",
"dist"
],
"references": [
{
Expand Down
Loading
Loading