Remove navigationRef from provingMachine #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughReplaces in-process navigation in the proving flow with a typed SDK event system: adds Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant App as App (RN)
participant Prover as ProvingMachine
participant SDK as SelfClient
participant Nav as Navigation
App->>Prover: init(selfClient)
Prover-->>SDK: emit(SdkEvents.PROGRESS,...)
alt passport data not found
Prover-->>SDK: emit(SdkEvents.PROVING_PASSPORT_DATA_NOT_FOUND)
SDK->>App: invoke listener
App->>Nav: navigate(DocumentDataNotFound)
else unsupported passport
Prover-->>SDK: emit(SdkEvents.PROVING_PASSPORT_NOT_SUPPORTED, {passportData})
SDK->>App: invoke listener
App->>Nav: navigate(UnsupportedDocument, passportData)
else verified success
Prover-->>SDK: emit(SdkEvents.PROVING_ACCOUNT_VERIFIED_SUCCESS)
SDK->>App: invoke listener
App->>Nav: navigate(AccountVerifiedSuccess) after delay
else register error/failure
Prover-->>SDK: emit(SdkEvents.PROVING_REGISTER_ERROR_OR_FAILURE, {hasValidDocument})
SDK->>App: invoke listener
App->>Nav: navigate(Home|Launch) after delay
else account recovery required
Prover-->>SDK: emit(SdkEvents.PROVING_ACCOUNT_RECOVERY_REQUIRED)
SDK->>App: invoke listener
App->>Nav: navigate(AccountRecoveryChoice)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~55 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 11
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
packages/mobile-sdk-alpha/src/context.tsx (1)
48-52: Pass listeners into the client and contextWithout forwarding listeners, emitted SDK events will not reach app handlers.
-export function SelfClientProvider({ config, adapters, children }: PropsWithChildren<SelfClientProviderProps>) { - const client = useMemo(() => createSelfClient({ config, adapters }), [config, adapters]); +export function SelfClientProvider({ config, adapters, listeners, children }: PropsWithChildren<SelfClientProviderProps>) { + const client = useMemo( + () => createSelfClient({ config, adapters, listeners }), + [config, adapters, listeners], + );packages/mobile-sdk-alpha/src/index.ts (1)
104-108: Fix export order to satisfy sort-exports lint and unblock CIsort-exports expects SdkEvents before webScannerShim.
-export { webScannerShim } from './adapters/web/shims'; - -export { SdkEvents } from './types/events'; +export { SdkEvents } from './types/events'; +export { webScannerShim } from './adapters/web/shims';packages/mobile-sdk-alpha/src/browser.ts (1)
68-71: Fix export order to satisfy sort-exports lint and unblock CIPlace SdkEvents before webScannerShim in the export list.
-export { webScannerShim } from './adapters/web/shims'; - -export { SdkEvents } from './types/events'; +export { SdkEvents } from './types/events'; +export { webScannerShim } from './adapters/web/shims';packages/mobile-sdk-alpha/src/client.ts (2)
110-128: Timeout emission is not cancelable; can fire after success/cancel.The scheduled timeout will emit
ERROReven if the proof was canceled or completed. Wire it to anAbortControllerand gate emission on!signal.aborted. Also emit a structured error (see events.ts comment).): Promise<ProofHandle> { if (!adapters.network) throw notImplemented('network'); if (!adapters.crypto) throw notImplemented('crypto'); const timeoutMs = opts.timeoutMs ?? cfg.timeouts?.proofMs ?? defaultConfig.timeouts.proofMs; - void _adapters.clock.sleep(timeoutMs!, opts.signal).then(() => emit(SdkEvents.ERROR, new Error('timeout'))); + const timeoutCtrl = new AbortController(); + // Link external signal (if any) to our internal controller + if (opts.signal) { + const forwardAbort = () => timeoutCtrl.abort(); + opts.signal.addEventListener('abort', forwardAbort, { once: true }); + } + void _adapters.clock.sleep(timeoutMs!, timeoutCtrl.signal).then(() => { + if (!timeoutCtrl.signal.aborted) { + emit(SdkEvents.ERROR, { code: 'SDK_TIMEOUT', message: 'Proof generation timed out' }); + } + }); return { id: 'stub', status: 'pending', result: async () => ({ ok: false, reason: 'SELF_ERR_PROOF_STUB' }), - cancel: () => {}, + cancel: () => { + timeoutCtrl.abort(); + }, }; }
76-86: Harden event-listener error logging to avoid leaking secrets.When logging listener errors, ensure the logger implementation scrubs sensitive data (keys, PII). If your
loggeradapter forwards to analytics/crash endpoints, enforce redaction at that layer.
🧹 Nitpick comments (1)
packages/mobile-sdk-alpha/tests/client.test.ts (1)
93-97: Prefer exercising the public emit API rather than patching Map.prototypeIntercepting Map.prototype.set tightly couples the test to internal data structures. Use client.emit(SdkEvents.PROGRESS, {...}) to drive callbacks and improve test resilience.
-const unsub = client.on(SdkEvents.PROGRESS, cb); -Map.prototype.set = originalSet; - -eventSet?.forEach(fn => fn({ step: 'one' })); +const unsub = client.on(SdkEvents.PROGRESS, cb); +client.emit(SdkEvents.PROGRESS, { step: 'one' });
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
app/src/providers/selfClientProvider.tsx(2 hunks)app/src/utils/proving/provingMachine.ts(4 hunks)app/tests/utils/proving/provingMachine.test.ts(4 hunks)packages/mobile-sdk-alpha/src/browser.ts(1 hunks)packages/mobile-sdk-alpha/src/client.ts(4 hunks)packages/mobile-sdk-alpha/src/context.tsx(2 hunks)packages/mobile-sdk-alpha/src/index.ts(1 hunks)packages/mobile-sdk-alpha/src/types/events.ts(1 hunks)packages/mobile-sdk-alpha/src/types/public.ts(2 hunks)packages/mobile-sdk-alpha/tests/client.test.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{test,spec}.{ts,js,tsx,jsx}
⚙️ CodeRabbit configuration file
**/*.{test,spec}.{ts,js,tsx,jsx}: Review test files for:
- Test coverage completeness
- Test case quality and edge cases
- Mock usage appropriateness
- Test readability and maintainability
Files:
packages/mobile-sdk-alpha/tests/client.test.tsapp/tests/utils/proving/provingMachine.test.ts
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}: Review alpha mobile SDK code for:
- API consistency with core SDK
- Platform-neutral abstractions
- Performance considerations
- Clear experimental notes or TODOs
Files:
packages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/context.tsxpackages/mobile-sdk-alpha/src/index.tspackages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/src/types/public.tspackages/mobile-sdk-alpha/src/client.ts
app/src/**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
app/src/**/*.{ts,tsx,js,jsx}: Review React Native TypeScript code for:
- Component architecture and reusability
- State management patterns
- Performance optimizations
- TypeScript type safety
- React hooks usage and dependencies
- Navigation patterns
Files:
app/src/providers/selfClientProvider.tsxapp/src/utils/proving/provingMachine.ts
🧠 Learnings (23)
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Use actual imports from selfxyz/mobile-sdk-alpha in tests
Applied to files:
packages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/index.tspackages/mobile-sdk-alpha/src/types/public.tsapp/tests/utils/proving/provingMachine.test.tsapp/src/utils/proving/provingMachine.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/src/index.ts : Re-export new SDK modules via packages/mobile-sdk-alpha/src/index.ts
Applied to files:
packages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/index.tspackages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/src/types/public.tsapp/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-25T14:25:57.586Z
Learnt from: aaronmgdr
PR: selfxyz/self#951
File: app/src/providers/authProvider.web.tsx:17-18
Timestamp: 2025-08-25T14:25:57.586Z
Learning: The selfxyz/mobile-sdk-alpha/constants/analytics import path is properly configured with SDK exports, Metro aliases, and TypeScript resolution. Import changes from @/consts/analytics to this path are part of valid analytics migration, not TypeScript resolution issues.
Applied to files:
packages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.tsapp/src/providers/selfClientProvider.tsxpackages/mobile-sdk-alpha/src/index.tsapp/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Never use real user PII in tests; use only synthetic, anonymized, or approved test vectors
Applied to files:
packages/mobile-sdk-alpha/tests/client.test.tsapp/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Do NOT mock selfxyz/mobile-sdk-alpha in tests (avoid jest.mock('selfxyz/mobile-sdk-alpha') and replacing real functions with mocks)
Applied to files:
packages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/index.tsapp/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/tests/setup.ts : Provide Vitest setup file at packages/mobile-sdk-alpha/tests/setup.ts to suppress console noise
Applied to files:
packages/mobile-sdk-alpha/tests/client.test.tsapp/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Avoid introducing circular dependencies
Applied to files:
packages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/index.tspackages/mobile-sdk-alpha/src/types/events.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/vitest.config.ts : Use Vitest in the SDK with a Node environment configured in packages/mobile-sdk-alpha/vitest.config.ts
Applied to files:
packages/mobile-sdk-alpha/tests/client.test.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/package.json : Enable tree shaking for the SDK (e.g., ensure 'sideEffects' is correctly set in package.json and exports are ESM-friendly)
Applied to files:
packages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/index.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Use strict TypeScript type checking across the codebase
Applied to files:
packages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/index.tspackages/mobile-sdk-alpha/src/types/events.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/**/package.json : Ensure package exports are properly configured
Applied to files:
packages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/index.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/README.md : Document new/updated SDK modules and usage in packages/mobile-sdk-alpha/README.md
Applied to files:
packages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/index.tspackages/mobile-sdk-alpha/src/types/events.ts
📚 Learning: 2025-08-26T14:49:11.190Z
Learnt from: shazarre
PR: selfxyz/self#936
File: app/src/screens/passport/PassportNFCScanScreen.tsx:28-31
Timestamp: 2025-08-26T14:49:11.190Z
Learning: SelfClientProvider is wrapped in app/App.tsx, providing context for useSelfClient() hook usage throughout the React Native app navigation stacks.
Applied to files:
packages/mobile-sdk-alpha/src/context.tsxapp/src/providers/selfClientProvider.tsxapp/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-26T14:49:11.190Z
Learnt from: shazarre
PR: selfxyz/self#936
File: app/src/screens/passport/PassportNFCScanScreen.tsx:28-31
Timestamp: 2025-08-26T14:49:11.190Z
Learning: The main App.tsx file is located at app/App.tsx (not in app/src), and it properly wraps the entire app with SelfClientProvider at the top of the provider hierarchy, enabling useSelfClient() hook usage throughout all navigation screens.
Applied to files:
packages/mobile-sdk-alpha/src/context.tsxapp/src/providers/selfClientProvider.tsxapp/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Update the app to consume the mobile-sdk-alpha package and replace local modules with SDK imports
Applied to files:
packages/mobile-sdk-alpha/src/index.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Test isPassportDataValid() with realistic synthetic passport data (never real user data)
Applied to files:
packages/mobile-sdk-alpha/src/types/public.tsapp/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Write integration tests that exercise the real validation logic (not mocks)
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Verify extractMRZInfo() using published sample MRZ strings (e.g., ICAO examples)
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Ensure parseNFCResponse() works with representative, synthetic NFC data
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:52:25.796Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to tests/src/**/*.{test,spec}.{ts,tsx,js,jsx} : Use renderHook for custom hook testing
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-26T14:49:15.210Z
Learnt from: shazarre
PR: selfxyz/self#936
File: app/src/screens/passport/PassportNFCScanScreen.web.tsx:8-11
Timestamp: 2025-08-26T14:49:15.210Z
Learning: The main App.tsx file is located at app/App.tsx (at the app root), not at app/src/App.tsx, and contains the SelfClientProvider wrapping the entire application.
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to app/jest.setup.js : Provide comprehensive Jest setup in app/jest.setup.js with required mocks
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:52:25.796Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to jest.setup.js : Maintain comprehensive mocks in jest.setup.js for all native modules
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
🪛 GitHub Check: lint
packages/mobile-sdk-alpha/src/browser.ts
[failure] 70-70:
Expected SdkEvents before webScannerShim
packages/mobile-sdk-alpha/src/index.ts
[failure] 107-107:
Expected SdkEvents before webScannerShim
packages/mobile-sdk-alpha/src/types/events.ts
[warning] 1-1:
Replace "./public" with './public'
packages/mobile-sdk-alpha/src/types/public.ts
[failure] 6-6:
'SdkEvents' is defined but never used. Allowed unused vars must match /^_/u
packages/mobile-sdk-alpha/src/client.ts
[warning] 59-59:
Replace ·config,·adapters,·listeners·}:·{·config:·Config;·adapters:·Adapters;·listeners?:·Map<SDKEvent,·Set<(p:·any)·=>·void>>· with ⏎··config,⏎··adapters,⏎··listeners,⏎}:·{⏎··config:·Config;⏎··adapters:·Adapters;⏎··listeners?:·Map<SDKEvent,·Set<(p:·any)·=>·void>>;⏎
🪛 GitHub Actions: Mobile SDK CI
packages/mobile-sdk-alpha/src/browser.ts
[error] 70-70: Command 'yarn workspace @selfxyz/mobile-sdk-alpha lint' failed: sort-exports/sort-exports: Expected SdkEvents before webScannerShim.
packages/mobile-sdk-alpha/src/types/events.ts
[warning] 1-1: Code style issues found in this file. Run Prettier with --write to fix.
packages/mobile-sdk-alpha/src/client.ts
[warning] 1-1: Code style issues found in this file. Run Prettier with --write to fix.
🪛 GitHub Check: build-deps
app/src/providers/selfClientProvider.tsx
[warning] 112-112:
Replace SdkEvents.PROVING_MACHINE_ACCOUNT_VERIFIED_SUCCESS, with ⏎······SdkEvents.PROVING_MACHINE_ACCOUNT_VERIFIED_SUCCESS,⏎·····
[warning] 110-110:
Replace ····]) with ······]),⏎····
[warning] 109-109:
Insert ··
[warning] 108-108:
Insert ··
[warning] 107-107:
Replace ·········· with ············
[warning] 106-106:
Insert ··
[warning] 105-105:
Insert ··
[warning] 104-104:
Replace SdkEvents.PROVING_MACHINE_PASSPORT_DATA_NOT_FOUND, with ⏎······SdkEvents.PROVING_MACHINE_PASSPORT_DATA_NOT_FOUND,⏎·····
[warning] 102-102:
Unexpected any. Specify a different type
🪛 GitHub Actions: Mobile CI
app/src/providers/selfClientProvider.tsx
[error] 5-5: simple-import-sort/imports: Run autofix to sort these imports!
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: analyze-ios
- GitHub Check: e2e-ios
🔇 Additional comments (8)
app/tests/utils/proving/provingMachine.test.ts (2)
18-25: Safe partial mocking of the SDKGood use of jest.requireActual to preserve real exports while overriding loadSelectedDocument. This keeps integration behavior realistic.
36-41: Minimal SelfClient shape is fine hereProviding only emit via type cast is acceptable for this focused test.
app/src/providers/selfClientProvider.tsx (1)
155-158: Pass listeners through to SDK providerGood: ensures app-level navigation hooks receive SDK events once SDK Provider supports listeners (see SDK context.tsx fix).
app/src/utils/proving/provingMachine.ts (3)
246-247: Emit on error/failure path replaces hard navigation — good directionSwitching to event emission decouples business logic from routing.
266-287: Check SDKEventMap typings align with emitted payloadsYou emit:
- PROVING_MACHINE_ACCOUNT_VERIFIED_SUCCESS with no payload
- PROVING_MACHINE_PASSPORT_NOT_SUPPORTED with { passportData }
- PROVING_MACHINE_ACCOUNT_RECOVERY_CHOICE with no payload
- PROVING_MACHINE_PASSPORT_DATA_NOT_FOUND with no payload
Ensure SDKEventMap reflects these shapes; mismatches will surface at listener sites (we flagged two in the app provider).
425-436: Structured payload for register error/failureEmitting { hasValidDocument } is good; paired with the provider fix, the UX will route correctly after delay.
packages/mobile-sdk-alpha/src/index.ts (1)
107-107: Unblock lint CI: enable Corepackcorepack enable yarn workspace @selfxyz/mobile-sdk-alpha lintpackages/mobile-sdk-alpha/src/browser.ts (1)
70-70: Enable Corepack and rerun browser entrypoint lintCorepack must be enabled to use the project’s [email protected]. Run:
corepack enable yarn workspace @selfxyz/mobile-sdk-alpha lintto confirm the browser entrypoint export sort passes.
aaronmgdr
reviewed
Sep 8, 2025
aaronmgdr
reviewed
Sep 9, 2025
aaronmgdr
reviewed
Sep 9, 2025
aaronmgdr
reviewed
Sep 9, 2025
shazarre
changed the title
aaronmgdr
approved these changes
Sep 9, 2025
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/mobile-sdk-alpha/tests/provider.test.tsx (1)
37-53: Fix memoization test: stabilize listeners reference to avoid re-instantiation.Inline
new Map()creates a new object each render, invalidating theuseMemocache and causing the CI failure. Hoist a stable map and pass it to the provider.it('memoises the client instance across re-renders', () => { const spy = vi.spyOn(clientModule, 'createSelfClient'); const config = {}; const adapters = mockAdapters; + const listeners = new Map(); const wrapper = ({ children }: { children: ReactNode }) => ( - <SelfClientProvider config={config} adapters={adapters} listeners={new Map()}> + <SelfClientProvider config={config} adapters={adapters} listeners={listeners}> {children} </SelfClientProvider> );packages/mobile-sdk-alpha/tests/client.test.ts (1)
1-1: Prettier/lint failures in this file block CI; reformat the createSelfClient calls.Run Prettier or apply the following formatting to satisfy simple-import-sort/prettier.
- const client = createSelfClient({ config: {}, adapters: { scanner, network, crypto, documents, auth }, listeners: new Map() }); + const client = createSelfClient({ + config: {}, + adapters: { scanner, network, crypto, documents, auth }, + listeners: new Map(), + });Apply the same multi-line formatting to other similar calls around Lines 81, 128, and 136. Then run:
- yarn prettier --write
- yarn workspace @selfxyz/mobile-sdk-alpha lint --fix
</blockquote></details> </blockquote></details>♻️ Duplicate comments (5)
packages/mobile-sdk-alpha/src/types/events.ts (2)
31-31: Narrow STATE payload to a concrete type (avoid plain string).Use a SelfClientState union/enum to prevent navigation bugs from typos.
Apply:
- [SdkEvents.STATE]: string; + [SdkEvents.STATE]: SelfClientState;And add at Line 5:
-import type { PassportData, Progress } from './public'; +import type { PassportData, Progress, SelfClientState } from './shared';
5-5: Extract shared types to break import cycle-import type { PassportData, Progress } from './public'; +import type { PassportData, Progress } from './shared';
- Create
packages/mobile-sdk-alpha/src/types/shared.tsexportingPassportData&Progress- Update
src/types/events.ts&src/types/public.tsto import those types from./shared- Add exports for
SdkEventsand the shared types inpackages/mobile-sdk-alpha/src/index.tspackages/mobile-sdk-alpha/src/client.ts (3)
52-65: Fix missing semicolon and improve type safety for listeners.There's a missing semicolon on line 65 that needs to be added. Additionally, the use of
anyin the listener signatures weakens type safety across the SDK boundary.- return { map, addListener }; + return { map, addListener }; }Also consider improving type safety:
-export const createListenersMap = (): { - map: Map<SDKEvent, Set<(p: any) => void>>; - addListener: <E extends SDKEvent>(event: E, cb: (payload: SDKEventMap[E]) => any) => void; -} => { - const map = new Map<SDKEvent, Set<(p: any) => void>>(); +export const createListenersMap = (): { + map: Map<SDKEvent, Set<(p: unknown) => void>>; + addListener: <E extends SDKEvent>(event: E, cb: (payload: SDKEventMap[E]) => void) => void; +} => { + const map = new Map<SDKEvent, Set<(p: unknown) => void>>();
74-82: Tighten listener parameter typing to avoidany.The
listenersparameter usesanywhich weakens type safety. This should useunknownor a properly typed payload map.-export function createSelfClient({ - config, - adapters, - listeners, -}: { - config: Config; - adapters: Adapters; - listeners: Map<SDKEvent, Set<(p: any) => void>>; -}): SelfClient { +export function createSelfClient({ + config, + adapters, + listeners, +}: { + config: Config; + adapters: Adapters; + listeners?: Map<SDKEvent, Set<(p: unknown) => void>>; +}): SelfClient {
90-90: Update internal listeners map to useunknowninstead ofany.For consistency with the improved type safety, update the internal
_listenersmap declaration.- const _listeners = new Map<SDKEvent, Set<(p: any) => void>>(); + const _listeners = new Map<SDKEvent, Set<(p: unknown) => void>>();📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
app/src/providers/selfClientProvider.tsx(2 hunks)app/src/utils/proving/provingMachine.ts(6 hunks)app/tests/utils/proving/provingMachine.test.ts(4 hunks)packages/mobile-sdk-alpha/src/browser.ts(1 hunks)packages/mobile-sdk-alpha/src/client.ts(4 hunks)packages/mobile-sdk-alpha/src/context.tsx(3 hunks)packages/mobile-sdk-alpha/src/entry/index.tsx(1 hunks)packages/mobile-sdk-alpha/src/index.ts(1 hunks)packages/mobile-sdk-alpha/src/types/events.ts(1 hunks)packages/mobile-sdk-alpha/src/types/public.ts(2 hunks)packages/mobile-sdk-alpha/tests/client-mrz.test.ts(2 hunks)packages/mobile-sdk-alpha/tests/client.test.ts(9 hunks)packages/mobile-sdk-alpha/tests/documents/utils.test.ts(1 hunks)packages/mobile-sdk-alpha/tests/entry.test.tsx(2 hunks)packages/mobile-sdk-alpha/tests/provider.test.tsx(2 hunks)🚧 Files skipped from review as they are similar to previous changes (3)
- packages/mobile-sdk-alpha/src/types/public.ts
- packages/mobile-sdk-alpha/src/context.tsx
- packages/mobile-sdk-alpha/src/index.ts
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/technical-specification.mdc)
**/*.{ts,tsx}: Define IdentityCommitment with fields: commitment (Poseidon hash), nullifier (domain-separated), timestamp (UTC number), version (circuit version), documentType ('passport' | 'eu_id_card')
Define DSCKeyCommitment with fields: publicKeyHash (Poseidon hash), certificateChain (hashes), revocationStatus (boolean), issuer (country code)
Define VerificationConfig with fields: circuitVersion (semver), complianceRules array, timeWindow (seconds, 24h), clockDrift (±5 min), trustAnchors, revocationRoots, timeSource (NTP), nullifierScope (domain separation)Files:
packages/mobile-sdk-alpha/tests/documents/utils.test.tspackages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/tests/client-mrz.test.tsapp/src/providers/selfClientProvider.tsxapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/src/client.tspackages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.tsapp/src/utils/proving/provingMachine.tspackages/mobile-sdk-alpha/src/entry/index.tsxpackages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}}
📄 CodeRabbit inference engine (packages/mobile-sdk-alpha/AGENTS.md)
packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}}: Do NOT mock @selfxyz/mobile-sdk-alpha in tests (avoid jest.mock('@selfxyz/mobile-sdk-alpha') and replacing real functions with mocks)
Use actual imports from @selfxyz/mobile-sdk-alpha in tests
Write integration tests that exercise the real validation logic (not mocks)
Test isPassportDataValid() with realistic synthetic passport data (never real user data)
Verify extractMRZInfo() using published sample MRZ strings (e.g., ICAO examples)
Ensure parseNFCResponse() works with representative, synthetic NFC data
Never use real user PII in tests; use only synthetic, anonymized, or approved test vectorsFiles:
packages/mobile-sdk-alpha/tests/documents/utils.test.tspackages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/tests/client-mrz.test.tspackages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/**/*.{ts,tsx}
📄 CodeRabbit inference engine (packages/mobile-sdk-alpha/AGENTS.md)
packages/mobile-sdk-alpha/**/*.{ts,tsx}: Use strict TypeScript type checking across the codebase
Follow ESLint TypeScript-specific rules
Avoid introducing circular dependenciesFiles:
packages/mobile-sdk-alpha/tests/documents/utils.test.tspackages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/tests/client-mrz.test.tspackages/mobile-sdk-alpha/src/client.tspackages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/entry/index.tsx**/*.{test,spec}.{ts,js,tsx,jsx}
⚙️ CodeRabbit configuration file
**/*.{test,spec}.{ts,js,tsx,jsx}: Review test files for:
- Test coverage completeness
- Test case quality and edge cases
- Mock usage appropriateness
- Test readability and maintainability
Files:
packages/mobile-sdk-alpha/tests/documents/utils.test.tspackages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/tests/client-mrz.test.tsapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}: Review alpha mobile SDK code for:
- API consistency with core SDK
- Platform-neutral abstractions
- Performance considerations
- Clear experimental notes or TODOs
Files:
packages/mobile-sdk-alpha/tests/documents/utils.test.tspackages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/tests/client-mrz.test.tspackages/mobile-sdk-alpha/src/client.tspackages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/entry/index.tsxapp/src/**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
app/src/**/*.{ts,tsx,js,jsx}: Review React Native TypeScript code for:
- Component architecture and reusability
- State management patterns
- Performance optimizations
- TypeScript type safety
- React hooks usage and dependencies
- Navigation patterns
Files:
app/src/providers/selfClientProvider.tsxapp/src/utils/proving/provingMachine.ts🧠 Learnings (22)
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Do NOT mock selfxyz/mobile-sdk-alpha in tests (avoid jest.mock('selfxyz/mobile-sdk-alpha') and replacing real functions with mocks)Applied to files:
packages/mobile-sdk-alpha/tests/documents/utils.test.tspackages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/tests/client-mrz.test.tsapp/src/providers/selfClientProvider.tsxapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/tests/client.test.ts📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Use actual imports from selfxyz/mobile-sdk-alpha in testsApplied to files:
packages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/tests/client-mrz.test.tsapp/src/providers/selfClientProvider.tsxapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.ts📚 Learning: 2025-08-26T14:49:11.190Z
Learnt from: shazarre PR: selfxyz/self#936 File: app/src/screens/passport/PassportNFCScanScreen.tsx:28-31 Timestamp: 2025-08-26T14:49:11.190Z Learning: SelfClientProvider is wrapped in app/App.tsx, providing context for useSelfClient() hook usage throughout the React Native app navigation stacks.Applied to files:
packages/mobile-sdk-alpha/tests/provider.test.tsxapp/src/providers/selfClientProvider.tsxapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/src/entry/index.tsx📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Verify extractMRZInfo() using published sample MRZ strings (e.g., ICAO examples)Applied to files:
packages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/tests/client-mrz.test.tsapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/tests/client.test.ts📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Ensure parseNFCResponse() works with representative, synthetic NFC dataApplied to files:
packages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/tests/client-mrz.test.tsapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/tests/client.test.ts📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR PR: selfxyz/self#0 File: .cursor/rules/mobile-sdk-migration.mdc:0-0 Timestamp: 2025-08-24T18:54:04.809Z Learning: Applies to packages/mobile-sdk-alpha/src/index.ts : Re-export new SDK modules via packages/mobile-sdk-alpha/src/index.tsApplied to files:
packages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/src/types/events.tsapp/src/providers/selfClientProvider.tsxapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/src/client.tspackages/mobile-sdk-alpha/tests/client.test.tspackages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/entry/index.tsx📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Never use real user PII in tests; use only synthetic, anonymized, or approved test vectorsApplied to files:
packages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/tests/client-mrz.test.tsapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/tests/client.test.ts📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Test isPassportDataValid() with realistic synthetic passport data (never real user data)Applied to files:
packages/mobile-sdk-alpha/tests/entry.test.tsxpackages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/tests/client-mrz.test.tsapp/src/providers/selfClientProvider.tsxapp/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/tests/client.test.ts📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Use strict TypeScript type checking across the codebaseApplied to files:
packages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/src/browser.ts📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR PR: selfxyz/self#0 File: .cursor/rules/mobile-sdk-migration.mdc:0-0 Timestamp: 2025-08-24T18:54:04.809Z Learning: Applies to packages/mobile-sdk-alpha/README.md : Document new/updated SDK modules and usage in packages/mobile-sdk-alpha/README.mdApplied to files:
packages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/src/client.tspackages/mobile-sdk-alpha/src/browser.tspackages/mobile-sdk-alpha/src/entry/index.tsx📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Avoid introducing circular dependenciesApplied to files:
packages/mobile-sdk-alpha/src/types/events.tsapp/src/providers/selfClientProvider.tsxpackages/mobile-sdk-alpha/src/browser.ts📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/**/package.json : Ensure package exports are properly configuredApplied to files:
packages/mobile-sdk-alpha/src/types/events.tspackages/mobile-sdk-alpha/src/browser.ts📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/**/package.json : Verify package conditions are valid (e.g., exports conditions)Applied to files:
packages/mobile-sdk-alpha/src/types/events.ts📚 Learning: 2025-08-25T14:25:57.586Z
Learnt from: aaronmgdr PR: selfxyz/self#951 File: app/src/providers/authProvider.web.tsx:17-18 Timestamp: 2025-08-25T14:25:57.586Z Learning: The selfxyz/mobile-sdk-alpha/constants/analytics import path is properly configured with SDK exports, Metro aliases, and TypeScript resolution. Import changes from @/consts/analytics to this path are part of valid analytics migration, not TypeScript resolution issues.Applied to files:
packages/mobile-sdk-alpha/src/types/events.tsapp/src/providers/selfClientProvider.tsx📚 Learning: 2025-08-26T14:49:11.190Z
Learnt from: shazarre PR: selfxyz/self#936 File: app/src/screens/passport/PassportNFCScanScreen.tsx:28-31 Timestamp: 2025-08-26T14:49:11.190Z Learning: The main App.tsx file is located at app/App.tsx (not in app/src), and it properly wraps the entire app with SelfClientProvider at the top of the provider hierarchy, enabling useSelfClient() hook usage throughout all navigation screens.Applied to files:
app/src/providers/selfClientProvider.tsxapp/tests/utils/proving/provingMachine.test.ts📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR PR: selfxyz/self#0 File: .cursor/rules/mobile-sdk-migration.mdc:0-0 Timestamp: 2025-08-24T18:54:04.809Z Learning: Applies to packages/mobile-sdk-alpha/package.json : Enable tree shaking for the SDK (e.g., ensure 'sideEffects' is correctly set in package.json and exports are ESM-friendly)Applied to files:
app/src/providers/selfClientProvider.tsxpackages/mobile-sdk-alpha/src/browser.ts📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR PR: selfxyz/self#0 File: .cursor/rules/mobile-sdk-migration.mdc:0-0 Timestamp: 2025-08-24T18:54:04.809Z Learning: Update the app to consume the mobile-sdk-alpha package and replace local modules with SDK importsApplied to files:
app/src/providers/selfClientProvider.tsx📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR PR: selfxyz/self#0 File: packages/mobile-sdk-alpha/AGENTS.md:0-0 Timestamp: 2025-08-29T15:31:15.924Z Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Write integration tests that exercise the real validation logic (not mocks)Applied to files:
app/tests/utils/proving/provingMachine.test.tspackages/mobile-sdk-alpha/tests/client.test.ts📚 Learning: 2025-08-24T18:52:25.796Z
Learnt from: CR PR: selfxyz/self#0 File: .cursorrules:0-0 Timestamp: 2025-08-24T18:52:25.796Z Learning: Applies to tests/src/**/*.{test,spec}.{ts,tsx,js,jsx} : Use renderHook for custom hook testingApplied to files:
app/tests/utils/proving/provingMachine.test.ts📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR PR: selfxyz/self#0 File: .cursor/rules/mobile-sdk-migration.mdc:0-0 Timestamp: 2025-08-24T18:54:04.809Z Learning: Applies to app/jest.setup.js : Provide comprehensive Jest setup in app/jest.setup.js with required mocksApplied to files:
app/tests/utils/proving/provingMachine.test.ts📚 Learning: 2025-08-24T18:52:25.796Z
Learnt from: CR PR: selfxyz/self#0 File: .cursorrules:0-0 Timestamp: 2025-08-24T18:52:25.796Z Learning: Applies to jest.setup.js : Maintain comprehensive mocks in jest.setup.js for all native modulesApplied to files:
app/tests/utils/proving/provingMachine.test.ts📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR PR: selfxyz/self#0 File: .cursor/rules/mobile-sdk-migration.mdc:0-0 Timestamp: 2025-08-24T18:54:04.809Z Learning: Applies to packages/mobile-sdk-alpha/tests/setup.ts : Provide Vitest setup file at packages/mobile-sdk-alpha/tests/setup.ts to suppress console noiseApplied to files:
app/tests/utils/proving/provingMachine.test.ts🧬 Code graph analysis (10)
packages/mobile-sdk-alpha/tests/provider.test.tsx (3)
app/src/providers/selfClientProvider.tsx (1)
SelfClientProvider(34-162)packages/mobile-sdk-alpha/src/context.tsx (1)
SelfClientProvider(48-57)packages/mobile-sdk-alpha/tests/utils/testHelpers.ts (1)
mockAdapters(66-72)packages/mobile-sdk-alpha/tests/entry.test.tsx (2)
packages/mobile-sdk-alpha/src/entry/index.tsx (1)
SelfMobileSdk(18-22)packages/mobile-sdk-alpha/tests/utils/testHelpers.ts (1)
mockAdapters(66-72)packages/mobile-sdk-alpha/src/types/events.ts (3)
packages/mobile-sdk-alpha/src/index.ts (2)
SdkEvents(72-72)Progress(20-20)packages/mobile-sdk-alpha/src/browser.ts (2)
SdkEvents(44-44)Progress(19-19)packages/mobile-sdk-alpha/src/types/public.ts (2)
PassportData(10-10)Progress(94-97)packages/mobile-sdk-alpha/tests/client-mrz.test.ts (2)
packages/mobile-sdk-alpha/src/client.ts (1)
createSelfClient(74-202)packages/mobile-sdk-alpha/tests/utils/testHelpers.ts (2)
mockAdapters(66-72)invalidMRZ(11-11)app/src/providers/selfClientProvider.tsx (2)
packages/mobile-sdk-alpha/src/client.ts (1)
createListenersMap(52-65)app/src/navigation/index.tsx (1)
navigationRef(53-53)app/tests/utils/proving/provingMachine.test.ts (1)
packages/mobile-sdk-alpha/src/types/public.ts (2)
SelfClient(183-206)PassportData(10-10)packages/mobile-sdk-alpha/src/client.ts (2)
packages/mobile-sdk-alpha/src/types/events.ts (2)
SDKEvent(35-35)SDKEventMap(19-33)packages/mobile-sdk-alpha/src/types/public.ts (2)
SelfClient(183-206)Unsubscribe(207-207)packages/mobile-sdk-alpha/tests/client.test.ts (3)
packages/mobile-sdk-alpha/src/client.ts (2)
createSelfClient(74-202)createListenersMap(52-65)packages/mobile-sdk-alpha/src/types/public.ts (1)
PassportData(10-10)common/src/utils/types.ts (1)
PassportData(35-50)app/src/utils/proving/provingMachine.ts (2)
packages/mobile-sdk-alpha/src/types/public.ts (2)
SelfClient(183-206)PassportData(10-10)common/src/utils/types.ts (1)
PassportData(35-50)packages/mobile-sdk-alpha/src/entry/index.tsx (3)
packages/mobile-sdk-alpha/src/types/events.ts (1)
SDKEvent(35-35)app/src/providers/selfClientProvider.tsx (1)
SelfClientProvider(34-162)packages/mobile-sdk-alpha/src/context.tsx (1)
SelfClientProvider(48-57)🪛 GitHub Actions: Mobile SDK CI
packages/mobile-sdk-alpha/tests/provider.test.tsx
[error] 50-50: SelfClientProvider Context memoises the client instance across re-renders: AssertionError: expected { …(14) } to be { …(14) } // Object.is equality
packages/mobile-sdk-alpha/src/client.ts
[warning] 1-1: Prettier formatting issues detected in src/client.ts. Run 'yarn prettier --write' to fix.
packages/mobile-sdk-alpha/tests/client.test.ts
[warning] 1-1: Prettier formatting issues detected in tests/client.test.ts. Run 'yarn prettier --write' to fix.
packages/mobile-sdk-alpha/src/entry/index.tsx
[error] 5-5: Lint step 'yarn workspace @selfxyz/mobile-sdk-alpha lint' reported simple-import-sort/imports error: Run autofix to sort these imports!
🪛 GitHub Check: lint
packages/mobile-sdk-alpha/src/client.ts
[warning] 65-65:
Insert;packages/mobile-sdk-alpha/tests/client.test.ts
[warning] 50-50:
Replace·config:·{},·adapters:·{·scanner,·network,·crypto,·documents,·auth·},·listeners:·new·Map()with⏎······config:·{},⏎······adapters:·{·scanner,·network,·crypto,·documents,·auth·},⏎······listeners:·new·Map(),⏎···
[warning] 81-81:
Replace·config:·{},·adapters:·{·network,·crypto,·scanner,·documents,·auth·},·listeners:·new·Map()with⏎······config:·{},⏎······adapters:·{·network,·crypto,·scanner,·documents,·auth·},⏎······listeners:·new·Map(),⏎···
[warning] 136-136:
Replace·config:·{},·adapters:·{·scanner,·network,·crypto,·documents,·auth·},·listeners:·new·Map()with⏎······config:·{},⏎······adapters:·{·scanner,·network,·crypto,·documents,·auth·},⏎······listeners:·new·Map(),⏎···
[warning] 128-128:
Replace·config:·{},·adapters:·{·scanner,·network,·crypto,·documents,·auth·},·listeners:·new·Map()with⏎······config:·{},⏎······adapters:·{·scanner,·network,·crypto,·documents,·auth·},⏎······listeners:·new·Map(),⏎···⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build-android
- GitHub Check: test
- GitHub Check: build-ios
- GitHub Check: e2e-ios
- GitHub Check: analyze-android
🔇 Additional comments (12)
packages/mobile-sdk-alpha/tests/entry.test.tsx (1)
23-26: LGTM: listeners wired into SelfMobileSdk.Passing a listeners map here aligns with the new event-driven API. No issues.
Also applies to: 34-37
packages/mobile-sdk-alpha/tests/documents/utils.test.ts (1)
14-15: LGTM: listeners passed to createSelfClient.Keeps the helper consistent with the new client signature.
packages/mobile-sdk-alpha/tests/client-mrz.test.ts (1)
12-13: LGTM: updated tests to supply listeners map.Matches the new public API; assertions remain valid.
Also applies to: 20-21, 31-33, 39-41, 44-45
packages/mobile-sdk-alpha/src/browser.ts (1)
44-49: LGTM: public re-exports for SdkEvents and listeners map utilities.This cleanly exposes the event API surface.
packages/mobile-sdk-alpha/src/types/events.ts (1)
19-29: Event payload mapping looks sound and aligns with app listeners.Shapes for PROVING_* events and the hasValidDocument/passportData payloads are correct.
app/src/providers/selfClientProvider.tsx (1)
101-151: Event-driven navigation wiring is correct; payload destructuring fixed prior shape mismatches.Listeners for PROVING_* events are properly typed and guarded with navigationRef.isReady(); destructuring { hasValidDocument } and { passportData } prevents always-true and nested-payload bugs.
packages/mobile-sdk-alpha/src/client.ts (2)
144-144: Event emission for timeout uses correct typed event.Good migration from string-based event to typed
SdkEvents.ERRORfor timeout handling.
111-115: Add null check for listeners parameter.The
listenersparameter is now required but the iteration uses optional chaining, which is inconsistent.- for (const [event, set] of listeners ?? []) { + if (listeners) { + for (const [event, set] of listeners) { for (const cb of Array.from(set)) { on(event, cb); } + } }Likely an incorrect or invalid review comment.
app/src/utils/proving/provingMachine.ts (4)
211-214: LGTM! Clean event-driven architecture.The new handler signatures properly encapsulate navigation logic and follow the event-driven pattern, removing direct navigation dependencies.
429-440: Excellent error handling with document validation.The error handler properly checks for valid documents before emitting the failure event, with appropriate fallback in the catch block.
1098-1114: Well-structured event emission handlers.All four new handlers correctly emit typed SDK events with appropriate payloads, completing the migration to event-driven navigation.
272-274: Clean removal of navigation delays.The removal of the 3-second delay and direct navigation call in favor of event emission improves responsiveness and decoupling.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
packages/mobile-sdk-alpha/src/client.ts (2)
52-65: Eliminate any from public listener utilities; use unknown and precise callback typing.Leaking any across the boundary weakens type safety for consumers of createListenersMap.
Apply:
-export const createListenersMap = (): { - map: Map<SDKEvent, Set<(p: any) => void>>; - addListener: <E extends SDKEvent>(event: E, cb: (payload: SDKEventMap[E]) => any) => void; -} => { - const map = new Map<SDKEvent, Set<(p: any) => void>>(); - - const addListener = <E extends SDKEvent>(event: E, cb: (payload: SDKEventMap[E]) => void) => { - const set = map.get(event) ?? new Set(); - set.add(cb as any); - map.set(event, set); - }; - - return { map, addListener }; -}; +export const createListenersMap = (): { + map: Map<SDKEvent, Set<(p: unknown) => void>>; + addListener: <E extends SDKEvent>(event: E, cb: (payload: SDKEventMap[E]) => void) => void; +} => { + const map = new Map<SDKEvent, Set<(p: unknown) => void>>(); + + const addListener = <E extends SDKEvent>(event: E, cb: (payload: SDKEventMap[E]) => void) => { + const set = map.get(event) ?? new Set<(p: unknown) => void>(); + set.add(cb as (p: unknown) => void); + map.set(event, set); + }; + + return { map, addListener }; +};
74-82: Make listeners optional and tighten its type.The code treats listeners as optional (listeners ?? []), but the signature requires it. This is a breaking change for existing callers.
Apply:
export function createSelfClient({ config, adapters, listeners, }: { config: Config; adapters: Adapters; - listeners: Map<SDKEvent, Set<(p: any) => void>>; + listeners?: Map<SDKEvent, Set<(p: unknown) => void>>; }): SelfClient {
🧹 Nitpick comments (1)
packages/mobile-sdk-alpha/src/client.ts (1)
99-109: Minor: guard emit when no listeners; keep error handling.Prevents needless work on empty sets.
Apply:
function emit<E extends SDKEvent>(event: E, payload: SDKEventMap[E]): void { - const set = _listeners.get(event); - if (!set) return; + const set = _listeners.get(event); + if (!set?.size) return; for (const cb of Array.from(set)) { try { (cb as (p: SDKEventMap[E]) => void)(payload); } catch (err) { _adapters.logger.log('error', `event-listener error for event '${event}'`, { event, error: err }); } } }
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
packages/mobile-sdk-alpha/src/client.ts(4 hunks)packages/mobile-sdk-alpha/src/entry/index.tsx(1 hunks)packages/mobile-sdk-alpha/tests/client.test.ts(9 hunks)packages/mobile-sdk-alpha/tests/provider.test.tsx(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/mobile-sdk-alpha/src/entry/index.tsx
- packages/mobile-sdk-alpha/tests/client.test.ts
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/technical-specification.mdc)
**/*.{ts,tsx}: Define IdentityCommitment with fields: commitment (Poseidon hash), nullifier (domain-separated), timestamp (UTC number), version (circuit version), documentType ('passport' | 'eu_id_card')
Define DSCKeyCommitment with fields: publicKeyHash (Poseidon hash), certificateChain (hashes), revocationStatus (boolean), issuer (country code)
Define VerificationConfig with fields: circuitVersion (semver), complianceRules array, timeWindow (seconds, 24h), clockDrift (±5 min), trustAnchors, revocationRoots, timeSource (NTP), nullifierScope (domain separation)
Files:
packages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/src/client.ts
packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}}
📄 CodeRabbit inference engine (packages/mobile-sdk-alpha/AGENTS.md)
packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}}: Do NOT mock @selfxyz/mobile-sdk-alpha in tests (avoid jest.mock('@selfxyz/mobile-sdk-alpha') and replacing real functions with mocks)
Use actual imports from @selfxyz/mobile-sdk-alpha in tests
Write integration tests that exercise the real validation logic (not mocks)
Test isPassportDataValid() with realistic synthetic passport data (never real user data)
Verify extractMRZInfo() using published sample MRZ strings (e.g., ICAO examples)
Ensure parseNFCResponse() works with representative, synthetic NFC data
Never use real user PII in tests; use only synthetic, anonymized, or approved test vectors
Files:
packages/mobile-sdk-alpha/tests/provider.test.tsx
packages/mobile-sdk-alpha/**/*.{ts,tsx}
📄 CodeRabbit inference engine (packages/mobile-sdk-alpha/AGENTS.md)
packages/mobile-sdk-alpha/**/*.{ts,tsx}: Use strict TypeScript type checking across the codebase
Follow ESLint TypeScript-specific rules
Avoid introducing circular dependencies
Files:
packages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/src/client.ts
**/*.{test,spec}.{ts,js,tsx,jsx}
⚙️ CodeRabbit configuration file
**/*.{test,spec}.{ts,js,tsx,jsx}: Review test files for:
- Test coverage completeness
- Test case quality and edge cases
- Mock usage appropriateness
- Test readability and maintainability
Files:
packages/mobile-sdk-alpha/tests/provider.test.tsx
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
packages/mobile-sdk-alpha/**/*.{ts,tsx,js,jsx}: Review alpha mobile SDK code for:
- API consistency with core SDK
- Platform-neutral abstractions
- Performance considerations
- Clear experimental notes or TODOs
Files:
packages/mobile-sdk-alpha/tests/provider.test.tsxpackages/mobile-sdk-alpha/src/client.ts
🧠 Learnings (5)
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Use actual imports from selfxyz/mobile-sdk-alpha in tests
Applied to files:
packages/mobile-sdk-alpha/tests/provider.test.tsx
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Do NOT mock selfxyz/mobile-sdk-alpha in tests (avoid jest.mock('selfxyz/mobile-sdk-alpha') and replacing real functions with mocks)
Applied to files:
packages/mobile-sdk-alpha/tests/provider.test.tsx
📚 Learning: 2025-08-26T14:49:11.190Z
Learnt from: shazarre
PR: selfxyz/self#936
File: app/src/screens/passport/PassportNFCScanScreen.tsx:28-31
Timestamp: 2025-08-26T14:49:11.190Z
Learning: SelfClientProvider is wrapped in app/App.tsx, providing context for useSelfClient() hook usage throughout the React Native app navigation stacks.
Applied to files:
packages/mobile-sdk-alpha/tests/provider.test.tsx
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/src/index.ts : Re-export new SDK modules via packages/mobile-sdk-alpha/src/index.ts
Applied to files:
packages/mobile-sdk-alpha/src/client.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/README.md : Document new/updated SDK modules and usage in packages/mobile-sdk-alpha/README.md
Applied to files:
packages/mobile-sdk-alpha/src/client.ts
🧬 Code graph analysis (2)
packages/mobile-sdk-alpha/tests/provider.test.tsx (2)
packages/mobile-sdk-alpha/src/context.tsx (1)
SelfClientProvider(48-57)packages/mobile-sdk-alpha/tests/utils/testHelpers.ts (1)
mockAdapters(66-72)
packages/mobile-sdk-alpha/src/client.ts (2)
packages/mobile-sdk-alpha/src/types/events.ts (2)
SDKEvent(35-35)SDKEventMap(19-33)packages/mobile-sdk-alpha/src/types/public.ts (2)
SelfClient(183-206)Unsubscribe(207-207)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: build-android
- GitHub Check: test
- GitHub Check: build-ios
- GitHub Check: analyze-android
- GitHub Check: analyze-ios
- GitHub Check: e2e-ios
🔇 Additional comments (2)
packages/mobile-sdk-alpha/tests/provider.test.tsx (2)
18-21: LGTM: Provider now forwards listeners into the client.Using a Map for listeners here aligns with the new event-driven flow and avoids tight coupling to navigation.
41-45: LGTM: Memoization test is sound.Stable refs for config/adapters/listeners ensure createSelfClient is invoked once across re-renders.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
app/tests/utils/proving/provingMachine.test.ts (3)
12-17: Drop stale navigation mock to avoid masking regressionsNavigation is no longer used by the proving machine; keeping this mock could hide accidental reintroductions. Remove it.
-jest.mock('@/navigation', () => ({ - navigationRef: { - isReady: jest.fn(() => true), - navigate: jest.fn(), - }, -}));
55-58: Tighten assertion: ensure only the expected event firesGuard against extra emits during init.
expect(provingStoreHook.current).toBe('passport_data_not_found'); expect(emitMock).toHaveBeenCalledWith( SdkEvents.PROVING_PASSPORT_DATA_NOT_FOUND, ); +expect(emitMock).toHaveBeenCalledTimes(1);
62-62: Rename test titles to match new event namesRemove the obsolete
PROVING_MACHINE_prefix in your test descriptions so they reflect the updated event names in app/tests/utils/proving/provingMachine.test.ts:- it('emits PROVING_MACHINE_PASSPORT_NOT_SUPPORTED', async () => { + it('emits PROVING_PASSPORT_NOT_SUPPORTED', async () => { - it('emits PROVING_MACHINE_ACCOUNT_RECOVERY_CHOICE', async () => { + it('emits PROVING_ACCOUNT_RECOVERY_REQUIRED', async () => { - it('emits PROVING_MACHINE_ACCOUNT_VERIFIED_SUCCESS', async () => { + it('emits PROVING_ACCOUNT_VERIFIED_SUCCESS', async () => { - it('emits PROVING_MACHINE_PASSPORT_DATA_NOT_FOUND', async () => { + it('emits PROVING_PASSPORT_DATA_NOT_FOUND', async () => { - it('emits PROVING_MACHINE_REGISTER_ERROR_OR_FAILURE', async () => { + it('emits PROVING_REGISTER_ERROR_OR_FAILURE', async () => {
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/tests/utils/proving/provingMachine.test.ts(4 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/technical-specification.mdc)
**/*.{ts,tsx}: Define IdentityCommitment with fields: commitment (Poseidon hash), nullifier (domain-separated), timestamp (UTC number), version (circuit version), documentType ('passport' | 'eu_id_card')
Define DSCKeyCommitment with fields: publicKeyHash (Poseidon hash), certificateChain (hashes), revocationStatus (boolean), issuer (country code)
Define VerificationConfig with fields: circuitVersion (semver), complianceRules array, timeWindow (seconds, 24h), clockDrift (±5 min), trustAnchors, revocationRoots, timeSource (NTP), nullifierScope (domain separation)
Files:
app/tests/utils/proving/provingMachine.test.ts
**/*.{test,spec}.{ts,js,tsx,jsx}
⚙️ CodeRabbit configuration file
**/*.{test,spec}.{ts,js,tsx,jsx}: Review test files for:
- Test coverage completeness
- Test case quality and edge cases
- Mock usage appropriateness
- Test readability and maintainability
Files:
app/tests/utils/proving/provingMachine.test.ts
🧠 Learnings (15)
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Test isPassportDataValid() with realistic synthetic passport data (never real user data)
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Use actual imports from selfxyz/mobile-sdk-alpha in tests
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Do NOT mock selfxyz/mobile-sdk-alpha in tests (avoid jest.mock('selfxyz/mobile-sdk-alpha') and replacing real functions with mocks)
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Verify extractMRZInfo() using published sample MRZ strings (e.g., ICAO examples)
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Write integration tests that exercise the real validation logic (not mocks)
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Ensure parseNFCResponse() works with representative, synthetic NFC data
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-29T15:31:15.924Z
Learnt from: CR
PR: selfxyz/self#0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-08-29T15:31:15.924Z
Learning: Applies to packages/mobile-sdk-alpha/{**/*.test.{ts,tsx},**/__tests__/**/*.{ts,tsx}} : Never use real user PII in tests; use only synthetic, anonymized, or approved test vectors
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:52:25.796Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to contracts/contracts/IdentityVerificationHubImplV2.sol : Identity Verification Hub: manage multi-step verification for passports and EU ID cards, handle document attestation via ZK proofs, and implement E-PASSPORT and EU_ID_CARD paths in IdentityVerificationHubImplV2.sol
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-26T14:49:11.190Z
Learnt from: shazarre
PR: selfxyz/self#936
File: app/src/screens/passport/PassportNFCScanScreen.tsx:28-31
Timestamp: 2025-08-26T14:49:11.190Z
Learning: SelfClientProvider is wrapped in app/App.tsx, providing context for useSelfClient() hook usage throughout the React Native app navigation stacks.
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:52:25.796Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to tests/src/**/*.{test,spec}.{ts,tsx,js,jsx} : Use renderHook for custom hook testing
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-26T14:49:11.190Z
Learnt from: shazarre
PR: selfxyz/self#936
File: app/src/screens/passport/PassportNFCScanScreen.tsx:28-31
Timestamp: 2025-08-26T14:49:11.190Z
Learning: The main App.tsx file is located at app/App.tsx (not in app/src), and it properly wraps the entire app with SelfClientProvider at the top of the provider hierarchy, enabling useSelfClient() hook usage throughout all navigation screens.
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to app/jest.setup.js : Provide comprehensive Jest setup in app/jest.setup.js with required mocks
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:52:25.796Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursorrules:0-0
Timestamp: 2025-08-24T18:52:25.796Z
Learning: Applies to jest.setup.js : Maintain comprehensive mocks in jest.setup.js for all native modules
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/src/index.ts : Re-export new SDK modules via packages/mobile-sdk-alpha/src/index.ts
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
📚 Learning: 2025-08-24T18:54:04.809Z
Learnt from: CR
PR: selfxyz/self#0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-08-24T18:54:04.809Z
Learning: Applies to packages/mobile-sdk-alpha/tests/setup.ts : Provide Vitest setup file at packages/mobile-sdk-alpha/tests/setup.ts to suppress console noise
Applied to files:
app/tests/utils/proving/provingMachine.test.ts
🧬 Code graph analysis (1)
app/tests/utils/proving/provingMachine.test.ts (2)
packages/mobile-sdk-alpha/src/types/public.ts (2)
SelfClient(183-206)PassportData(10-10)app/src/utils/proving/provingMachine.ts (1)
useProvingStore(217-1116)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build-ios
- GitHub Check: test
- GitHub Check: build-android
- GitHub Check: analyze-ios
- GitHub Check: e2e-ios
🔇 Additional comments (1)
app/tests/utils/proving/provingMachine.test.ts (1)
7-9: Typed imports and event constants — LGTMGood use of type-only import for SelfClient and SdkEvents constants to avoid stringly-typed expectations.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
app/src/utils/proving/provingMachine.ts (2)
202-215: Fix async return type mismatch for _handleRegisterErrorOrFailureThe interface declares a void return, but the implementation is async and returns Promise. This breaks type safety and can fail compilation with strict options.
Apply:
- _handleRegisterErrorOrFailure: (selfClient: SelfClient) => void; + _handleRegisterErrorOrFailure: (selfClient: SelfClient) => Promise<void>;
326-327: Remove undeclared property 'selfApp' from store initializerThe returned object includes
selfApp: null, butselfAppis not part of ProvingState. This causes “object literal may only specify known properties” and breaks the build.- selfApp: null,
♻️ Duplicate comments (1)
app/src/utils/proving/provingMachine.ts (1)
433-440: Verify event name before merge: REGISTER vs REGISTRATIONYou’re emitting
SdkEvents.PROVING_REGISTER_ERROR_OR_FAILURE, while a prior review referencedPROVING_REGISTRATION_ERROR_OR_FAILURE. Align with the actual SDK enum to avoid silent no-op listeners.Run:
#!/bin/bash # Verify the canonical event constant and payload type rg -nP -C2 'export\s+(enum|const)\s+SdkEvents|type\s+SDKEvent|SDKEventMap' packages/mobile-sdk-alpha rg -nP 'PROVING_(REGISTER|REGISTRATION)_ERROR_OR_FAILURE' -S
🧹 Nitpick comments (1)
app/src/utils/proving/provingMachine.ts (1)
42-44: Make SelfClient a type-only import to trim bundle and avoid runtime import
SelfClientis used purely in types. Import it withimport typein a separate clause.-import { - hasAnyValidRegisteredDocument, - loadSelectedDocument, - SdkEvents, - SelfClient, -} from '@selfxyz/mobile-sdk-alpha'; +import { SdkEvents } from '@selfxyz/mobile-sdk-alpha'; +import type { SelfClient } from '@selfxyz/mobile-sdk-alpha';
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/src/utils/proving/provingMachine.ts(6 hunks)packages/mobile-sdk-alpha/src/index.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/mobile-sdk-alpha/src/index.ts
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/technical-specification.mdc)
**/*.{ts,tsx}: Define IdentityCommitment with fields: commitment (Poseidon hash), nullifier (domain-separated), timestamp (UTC number), version (circuit version), documentType ('passport' | 'eu_id_card')
Define DSCKeyCommitment with fields: publicKeyHash (Poseidon hash), certificateChain (hashes), revocationStatus (boolean), issuer (country code)
Define VerificationConfig with fields: circuitVersion (semver), complianceRules array, timeWindow (seconds, 24h), clockDrift (±5 min), trustAnchors, revocationRoots, timeSource (NTP), nullifierScope (domain separation)
Files:
app/src/utils/proving/provingMachine.ts
app/src/**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
app/src/**/*.{ts,tsx,js,jsx}: Review React Native TypeScript code for:
- Component architecture and reusability
- State management patterns
- Performance optimizations
- TypeScript type safety
- React hooks usage and dependencies
- Navigation patterns
Files:
app/src/utils/proving/provingMachine.ts
🧠 Learnings (2)
📚 Learning: 2025-08-29T15:30:12.210Z
Learnt from: CR
PR: selfxyz/self#0
File: app/AGENTS.md:0-0
Timestamp: 2025-08-29T15:30:12.210Z
Learning: Document complex native module changes for AI review
Applied to files:
app/src/utils/proving/provingMachine.ts
📚 Learning: 2025-08-25T14:25:57.586Z
Learnt from: aaronmgdr
PR: selfxyz/self#951
File: app/src/providers/authProvider.web.tsx:17-18
Timestamp: 2025-08-25T14:25:57.586Z
Learning: The selfxyz/mobile-sdk-alpha/constants/analytics import path is properly configured with SDK exports, Metro aliases, and TypeScript resolution. Import changes from @/consts/analytics to this path are part of valid analytics migration, not TypeScript resolution issues.
Applied to files:
app/src/utils/proving/provingMachine.ts
🧬 Code graph analysis (1)
app/src/utils/proving/provingMachine.ts (3)
packages/mobile-sdk-alpha/src/index.ts (2)
SelfClient(29-29)SdkEvents(72-72)packages/mobile-sdk-alpha/src/types/public.ts (2)
SelfClient(183-206)PassportData(10-10)common/src/utils/types.ts (1)
PassportData(35-50)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: build-android
- GitHub Check: test
- GitHub Check: build-ios
- GitHub Check: e2e-ios
- GitHub Check: analyze-android
- GitHub Check: analyze-ios
shazarre
deleted the
shazarre/remove_navigationRef_from_provingMachine
branch
This was referenced Sep 9, 2025
remicolin
added a commit
that referenced
this pull request
Sep 22, 2025
* SDK Go version (#920) * feat: helper functions and constant for go-sdk * feat: formatRevealedDataPacked in go * chore: refactor * feat: define struct for selfBackendVerifier * feat: verify function for selfBackendVerifier * feat(wip): custom hasher * feat: SelfVerifierBacked in go * test(wip): scope and userContextHash is failing * test: zk proof verified * fix: MockConfigStore getactionId function * chore: refactor * chore: remove abi duplicate files * chore: move configStore to utils * chore: modified VcAndDiscloseProof struct * chore: more review changes * feat: impl DefaultConfig and InMemoryConfigStore * chore: refactor and export functions * fix: module import and README * chore: remove example folder * chore: remove pointers from VerificationConfig * chore: coderabbit review fixes * chore: more coderabbit review fix * chore: add license * fix: convert attestationIdd to int * chore: remove duplicate code --------- Co-authored-by: ayman <[email protected]> * Moving proving Utils to common (#935) * remove react dom * moves proving utils to the common * need to use rn components * fix imports * add proving-utils and dedeuplicate entry configs for esm and cjs. * must wrap in text component * fix metro bundling * fix mock import * fix builds and tests * please save me * solution? * fix test * Move proving inputs to the common package (#937) * create ofactTree type to share * move proving inputs from app to register inputs in common * missed reexport * ok * add some validations as suggested by our ai overlords * Fix mock passport flow (#942) * fix dev screens * add hint * rename * fix path * fix mobile-ci path * fix: extractMRZ (#938) * fix: extractMRZ * yarn nice && yarn types * fix test: remove unused * fix mobile ci * add script --------- Co-authored-by: Justin Hernandez <[email protected]> * Move Proving attest and cose (#950) * moved attest and cose utils to common with cursor converted tests in common to use vitest and converted coseVerify.test to vitest after moving from app to common what does cryptoLoader do? * moved away * get buff Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice * Migrate Analytics (#951) * setup analytics adapter for self mobile sdk client and use in app * wrap for context * fix build * yarn types is an alias for build when build just compiles ts * ok unlock * deeper * ok this looks to work * fix license check * make sure it starts with this line * someone didnt commit * fix double analytics bug and builds * lint * Read document catalog from selfClient (#936) * [SELF-676] feat: upgrade React Native from 0.75.4 to 0.76.9 (#943) * chore: upgrade build tooling to Node 22 and AGP 8.6 * chore: upgrade react-native to 0.76.9 * update lock files and formatting * fix path * fix: handle hermes-engine cache mismatch in CI after React Native upgrade - Add fallback logic to run 'pod update hermes-engine' when pod install fails - This resolves CocoaPods cache issues that occur after React Native version upgrades - Fixes CI pipeline failures on codex/update-core-tooling-for-react-native-upgrade branch * fix: improve hermes-engine cache handling in CI - Preemptively clear CocoaPods cache before pod install - This prevents dependency analysis failures that occur when cached podspecs conflict - Addresses the root cause: cache conflicts during 'Analyzing dependencies' phase - Keeps fallback logic for additional safety * fix: handle hermes-engine cache in mobile-bundle-analysis workflow - Add pod-install-with-cache-fix.sh script to handle hermes-engine cache conflicts - Update install-app:setup script to use the new cache fix approach - This fixes the mobile-bundle-analysis.yml workflow failures after React Native upgrade - Proactively clears CocoaPods cache and has fallback for hermes-engine updates * formatting * fix: robust hermes-engine cache handling in CI workflows - Apply comprehensive cache clearing to mobile-ci.yml and mobile-e2e.yml - Pre-emptively run 'pod update hermes-engine' before pod install - Clear multiple cache locations to handle CI environment differences - This prevents 'hermes-engine differs from Pods/Local Podspecs' errors - Fixes all workflows affected by React Native 0.76.9 upgrade cache issues * fixes * clean up * update lock files * fix tests * sort * fixes * fix ci * fix deployment target * android fixes * upgrade fix * fixes * fix: streamline mobile CI build and caching (#946) * fix: streamline mobile CI build and caching * Enable mobile E2E tests on codex/fix-mobile-ci-workflow-errors branch * test * simplify and fix path * workflow fixes * fix loading on 0.76.9 * clean up unnecessary comments * fix readme * finalize upgrade to 0.76.9 * fix android build and upgrade * fix bundler caching * download cli to fix "yarn start" issues * fix cli build erorr * fix script path * better path * abstract build step to prevent race condition * fixes * better cache * fix corepack build error * update lock * update lock * add yarn cache to workflows * fix test building * ci caching improvements * fix common type check * fix common ci * better mobile sdk alpha building logic * chore: speed up mobile e2e workflow (#962) * chore: speed up mobile e2e workflow * chore: disable android e2e job * chore: speed up ios build * fix: bundle js for ios debug build * fix e2e * fix mobile ci (#964) * feat: improve mixpanel flush strategy (#960) * feat: improve mixpanel flush strategy * fixes * fix build * update lock * refactor methods * conslidate calls * update package and lock * refactor: remove namespace imports (#969) * refactor: remove namespace imports * refactor: use named fs imports * refactor(app): replace path and fs namespace imports * format * format * Mixpanel tweaks (#971) * udpates * fox * update license * Add DSC parsing check (#836) * Handle missing dsc parsed * nice * fix test * throw * fix * chore(app): upgrade dependencies (#968) * chore(app): upgrade dependencies * update package * update lock files * fixes * lock * fix * Auth Adapter + (#958) * basic auth adapater * remove SelfMobileSDk, this was another architecture which the adapter patern replaced * rename to avoid confusion with client.test.ts * basic auth adapater * remove SelfMobileSDk, this was another architecture which the adapter patern replaced * rename to avoid confusion with client.test.ts * self * fix * remove prototypes * make sure its mounted * fix tests * fmt * require required adapters * fix types * not a partial * adds missing exports * fix missing data * Fix nfc configuration scanning issue (#978) * fix nfc scanning on ios and android * save test * fix tests * fix lint * Chore fix ios nfc scanning and compiling (#979) * fixes * silence error * fix debugge * fix nfc scanning * lint and pipeline fixes * large runner (#980) * chore: update to macos latest large runner (#981) * bump up to macos-latest-large * fix ci * Move loadSelectedDocument to SDK (#967) Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * docs: update mobile SDK migration progress (#982) * docs: record app integration progress * docs: consolidate mobile SDK migration tracking * docs: humanize migration tracking and merge prompts * docs: add common consolidation tasks * docs: reprioritize migration tasks * docs: soften migration plan tone * docs: detail agent prompts with file paths * docs: catalog Linear tasks for SDK * updates * remove artifact management * moves validateDocument functions into the common package. (#977) * moves validateDocument functions into the common package. * fix build issues and lint * handle bad connections better in nullifiier * add an abort controler to nullifer fetcher, ignore fals positives * import types separately * take it as an arg * chore: update yarn.lock * chore(app): resolve lint warnings (#990) * chore(app): resolve lint warnings * update lock * clean up any types * fix types * feedback from cr * [SELF-703] feat: Migrate mock generator to mobile sdk (#992) * feat: expose mock generator * formatting * fix tests and lint * rename passport to document * fix types * [SELF-698] scaffold mobile sdk demo app (#993) * chore: scaffold mobile sdk demo app * test: cover demo app menu * prettier and types * sort * add android app foundation * fix android loading * get ios app running * update script * cr feedback * disable fabric * fixes * fixes * fix * SELF-702: Refactor navigation structure and dev utilities (#994) * Refactor navigation and dev screens * refactor: rename passport screens to document * fixes * add missing header * fixes * type files * feat: clarify proof verification analytics (#996) * feat: increase sha256 byte size and add new rsa circuits (#986) * feat: increase sha256 byte size and add new rsa circuits * feat: modularise the rsa fp pow mod * chore: comment signature verifier for testing * fix: sha256_sha256_sha224_ecdsa_secp224r1 * lint * chore: implement google play suggestions (#997) * google play suggestions * update gitguardian ignore * remove unused * chore: address yarn lock issues (#1004) * address yarn lock issues * fix postinstall * skip postinstall for ci (#1005) * [SELF-654] feat: add native modules (#919) * feat: add ios native modules * fix: extractMRZ * Add android OCR native module * wire native mrz module with adapter * wire Native modules and fix tests * fixes * fix license header logic * fix tests * fix types * fix: ci test * fix: android build ci * fix: ios build CI * add podfile.lock * add yarn.lock * update lock files * add yarn.lock * add license * order methods * update lock * pipeline fixes * prettier * update lock file * fix native modules on external apps * bundle @selfxyz/common into mobile-sdk-alpha * chore: address yarn lock issues (#1004) * address yarn lock issues * fix postinstall * update lock * fix build issues * fix pipeline issue * fix ci * fix bad merge * fix android ci * fix ci errors * fix mobile sdk ci. stop gap fix for now until we create a package * tweaks * retry aapt2 approach * use ^0.8.4 instead of ^0.8.0 due to the use of custom errors * workflow fixes * fix file * update * fix ci * test ci fix * fix test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: update dev with staging 09/06/25 (#1007) * update CI * bump iOS version * update readme * update mobile-deploy ci * bump version iOS * update workflow to use workload identity federation (#933) * update workflow to use workload identity federation * add token permissions * correct provider name * chore: incrementing android build version for version 2.6.4 [github action] --------- Co-authored-by: Self GitHub Actions <[email protected]> * update ci * update ci * update ci * update ci * update ci * fix ci * fix ci * fix ci * remove fastlane use for android * bump iOS build version * update CI python script * iterate on CI * iterate on CI * iterate on CI * Dev (#941) * SDK Go version (#920) * feat: helper functions and constant for go-sdk * feat: formatRevealedDataPacked in go * chore: refactor * feat: define struct for selfBackendVerifier * feat: verify function for selfBackendVerifier * feat(wip): custom hasher * feat: SelfVerifierBacked in go * test(wip): scope and userContextHash is failing * test: zk proof verified * fix: MockConfigStore getactionId function * chore: refactor * chore: remove abi duplicate files * chore: move configStore to utils * chore: modified VcAndDiscloseProof struct * chore: more review changes * feat: impl DefaultConfig and InMemoryConfigStore * chore: refactor and export functions * fix: module import and README * chore: remove example folder * chore: remove pointers from VerificationConfig * chore: coderabbit review fixes * chore: more coderabbit review fix * chore: add license * fix: convert attestationIdd to int * chore: remove duplicate code --------- Co-authored-by: ayman <[email protected]> * Moving proving Utils to common (#935) * remove react dom * moves proving utils to the common * need to use rn components * fix imports * add proving-utils and dedeuplicate entry configs for esm and cjs. * must wrap in text component * fix metro bundling * fix mock import * fix builds and tests * please save me * solution? * fix test * Move proving inputs to the common package (#937) * create ofactTree type to share * move proving inputs from app to register inputs in common * missed reexport * ok * add some validations as suggested by our ai overlords * Fix mock passport flow (#942) * fix dev screens * add hint * rename * fix path * fix mobile-ci path * fix: extractMRZ (#938) * fix: extractMRZ * yarn nice && yarn types * fix test: remove unused * fix mobile ci * add script --------- Co-authored-by: Justin Hernandez <[email protected]> * Move Proving attest and cose (#950) * moved attest and cose utils to common with cursor converted tests in common to use vitest and converted coseVerify.test to vitest after moving from app to common what does cryptoLoader do? * moved away * get buff Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: ayman <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * bump version * bump yarn.lock * update ci (#966) * chore: Manually bump and release v2.6.4 (#961) * update lock files * bump and build android * update build artifacts * show generate mock document button * update lock * fix formatting and update failing e2e test * revert podfile * fixes * fix cold start of the app with deeplink * update ci * update ci * Sync MARKETING_VERSION to iOS project files after version bump * chore: incrementing android build version for version 2.6.4 [github action] (#976) Co-authored-by: remicolin <[email protected]> * chore: add build dependencies step for iOS and Android in mobile deploy workflow * chore: enhance mobile deploy workflow by adding CMake installation step * bump android build version * chore: incrementing android build version for version 2.6.4 [github action] (#985) Co-authored-by: remicolin <[email protected]> * chore: configure Metro bundler for production compatibility in mobile deploy workflow * chore: incrementing android build version for version 2.6.4 [github action] (#987) Co-authored-by: remicolin <[email protected]> * Revert "chore: configure Metro bundler for production compatibility in mobile deploy workflow" This reverts commit 60fc1f2580c2f6ad3105d8b904d969412a18bd2e. * reduce max old space size in mobile-deploy ci * fix android french id card (#957) * fix android french id card * fix common ci cache * feat: log apdu (#988) --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> * unblock ci * fix merge * merge fixes * fix tests * make ci happy --------- Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: pputman-clabs <[email protected]> Co-authored-by: Self GitHub Actions <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: ayman <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: fix yarn format (#1009) * fix yarn format * yarn format * fix lint * undo temporary disabling * pipeline fixes * revert nvmrc change * add new home screen (#1019) * add new home screen * fix typing issue * yarn nice * chore: update the cpp build script (#1021) * chore: install node (#1022) * chore: use node v22 (#1023) * chore: install yarn (#1024) * chore: yarn cache (#1025) * chore: sanitise node version (#1026) * remove lazy loading (#1018) * remove lazy loading * fix tests * formatting * fix imports and web ci * fix tests * fix building * fix * debug ci * fix web ci issue * fix * fix * fix ci * remove web render test * coderabbit feedback * fix ci * use import * fix lint * fix compiling * update lock * update lock * fix: update yarn.lock hash for @selfxyz/mobile-sdk-alpha Resolves CI error where yarn install --immutable failed due to outdated package hash. The hash changed from b2afc4 to f9ebb9. * fix: update yarn.lock hash after mobile-sdk-alpha changes - Hash changed from c0e6b9 to 0d0f72 due to package modifications - Cleaned caches and regenerated lockfile to ensure consistency - This resolves CI cache mismatch where old artifacts had stale hash * fix: update yarn.lock hash after building mobile-sdk-alpha - Final hash: 89f5a6 (includes built dist artifacts) - Built mobile-sdk-alpha to ensure package is in stable state - This should resolve CI immutable install errors * fix yarn lock and build * chore(ci): improve mobile e2e caching (#1010) * chore(ci): improve mobile e2e caching * chore(ci): restore deriveddata cache * chore(ci): remove ios deriveddata cache * chore(ci): cache ios derived data * chore(ci): optimize mobile deploy caching * chore(ci): enable ccache for ios e2e builds * fix(ci): add ccache path for ios e2e * moves ofac and protocol store (#1012) * move ofact tree fetch to common * move protocol store to the msdk, fix some dependencies on msdk * chore: remove register id from register circuits (#1028) * chore: remove register id from register circuits * chore: only use 128ram instance * Feat/build cpp (#1029) * chore: remove register id from register circuits * chore: only use 128ram instance * chore: build 2 circuits at a time * Remove navigationRef from provingMachine (#1011) * SDK: minimize amount of data sent through PROVING_PASSPORT_NOT_SUPPORTED event (#1030) * Fix mock passport generation (#1031) * fix mock passport generation * fix mobile ci tests * Feat/aadhaar (#949) * make contract sdk simpler (#514) * make contract sdk simpler * reduce root inputs * delete convert function * summarize our library * update npm package * update package version * update attestation id * add util function to get revealed data * Revert "make contract sdk simpler (#514)" (#518) This reverts commit 847b88d5ecc0d449b976a552f68af38eec8e561b. * merge dev into main (#576) * Feat: Show error code in SDK (#500) * feat: emit `error_code` and `reason` in app * feat: add `onError` in sdk * feat: Display reason in app * lint & fmt * feat: add scrollview in ProofRequestStatusScreen for long reasons * Fix input generation for 521bit curves (#481) * fix EC point padding for 521 bit curves * rename modulus to point in findStartIndexEC as it is a point * simplify matching logic * simplify padding logic * remove comment * remove log removing .only so the CI/CD runs circuit tests fix disclosure test fix scope in test fix scope error in circuit tests remove .only fix test * run ci/cd * Feat/simpler contract sdk (#519) * make contract sdk simpler * reduce root inputs * delete convert function * summarize our library * update npm package * update package version * update attestation id * add util function to get revealed data --------- Co-authored-by: motemotech <[email protected]> * forgot to include package update (#521) * Bump version to 2.5.1 (#522) * bump version * update fastlane * fix bump version * bump build and add todo * disable commit for now * [SEL-154] Step 1: Scan your passport (#511) * simplify navigation logic * use aesop design hook * save wip * add new aesop redesign screens * save wip design * refactor nav bar logic * fix paths * save wip * stub progress navbar and save wip * save wip progress bar animation * save wip progress bar, almost done with design * fix progress bar design * fix bottom padding * disable git commit for now * fix flaky android downloads that causes pipeline to crash * update lock for ci * [SEL-46] FE: Add minimum bottom padding (#510) * fix bottom padding for smaller screens * fix podfile post install hook permissions check * update pod lock and disable git commit action step for now * update lock * fix flaky android downloads that causes pipeline to crash * fix: improve error handling for forbidden countries list mismatch (#494) * Update SelfBackendVerifier.ts * Update constants.ts * Update formatInputs.ts * Update formatCallData.ts * DX: Auto format on save (#526) * save wip * use elint instead of prettier to sort imports * set imports to warn * sync prettier settigns * update prettier settings * save working version * fix export and disable mobile pipeline for now * limit auto formatting to the app folder * remove artefacts * SEL-187: Make bottom layout scrollable on smaller screens (#525) * fix design check * add an option to disable local sending of sentry events * better sentry enable / disable * fix scan passport height * make bottom layout scrollable so it doesn't squish top screen * simpler logic check. don't create new env var * fix internet connection issues * readd comment * use isConnected instead of internet reachable * use a dynamic bottom panel height * add missing recovery screens * move aesop below * remove dupe export * fix rebase * fix android package download issue * Feat/extend id support (#517) * refactor proving impleting xstate, speedup proving * add disclosure proof support * keep refactoring provingMachine, clean old implementation * call init method when switching from dsc to register * rebase with dev to display why the proof verification failed * refactor ws connexion between front-end and mobile to retrieve self-app * update the webclient at proofVerification and use selfAppStore in provingMachine * fix provintStore.init in ProveScreen * yarn nice * fetch data correctly in splash screen * Bump build versions for 2.5.1 (#531) * release new builds * fix app and build versions * fix env check * display error animation on failure on loading screen (#532) * display error animation on failure on loading screen * remove log --------- Co-authored-by: Justin Hernandez <[email protected]> * ci: bump actions/checkout to v4 (#529) * make contract sdk simpler (#514) * make contract sdk simpler * reduce root inputs * delete convert function * summarize our library * update npm package * update package version * update attestation id * add util function to get revealed data * Revert "make contract sdk simpler (#514)" (#518) This reverts commit 847b88d5ecc0d449b976a552f68af38eec8e561b. * ci: bump actions/checkout to v4 --------- Co-authored-by: nicoshark <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> * fix italy (#530) * Fix/proving machine endpoint type (#538) * store endpoint type in proving machine * yarn nice * fix splash screen error (#539) * New bug fix build for v2.5.1 (#540) * bump new build for dev fixes * update lock * reinstall before running local deploy * SEL-178: Improve haptic feedback library (#535) * fix dev settings typing * add dev screens file * save haptic feedback progress * change ordedr * fix initial route and add haptic feedback screen to dev settings options * add delete scripts (#542) * update staging registry address (#545) * feat: Add Disclose history (#533) * feat: Add Disclose history * fix: Duplicate history in list * fix: Outdated disclosures * Delete app/ios/Self copy-Info.plist * allow a scale of up to 1.3 (#546) * allow a scale of up to 1.3 * update lock files * clean up unused imports * fix settings * add common sdk (#537) * add common sdk * remove sdk backend api * remove registry * regenerate sha256 rsa dsc each time * download ski-pem dynamically on staging, refactor initpassportDataParsing * add state machine for button on prove screen, improve ux on splash screen * fetch ski-pem in production * fix linter issues * fix prove screen button bugs * update podfile.lock and yarn.lock * run linter in circuits repo * bump build * bump version for sentry debugging * bump ios to version 118 --------- Co-authored-by: Justin Hernandez <[email protected]> * better connection check (#548) * Clean up navigation and setup Jest (#549) * remove dupe account screens and prefer the term home * organize screen loading better * sort keys * rename screen files wip * fix deleted directory issues * rename folders * fix paths and naming * save working jest import test * save base working jest navigation test * finalize navigation refactor and jest test * update test name and podfile lock * remove unused packages * use the correct version of react test renderer * bump build (#552) * Eth dublin (#554) * add mock id card generator * add genMockIdDoc in common/sdk exports * onboard developer id using deeplink, allow custom birthdate on mockpassport * log more dsc info (#558) * Push notification (#536) * add push notification feature * merge new app impl * change dsc key * import * reverse mock dsc * worked in the ios * checked in android * update url and delete console * delete small changes * lint * add yarn.lock * fix warning message * add mock notification service for test code * fix path for the mock implementation * add mock deeplink to the test code * nice notificationServiceMock.js * delete unused firebase related implementation * fix wording and UI related to notification service * hotfix on mockdatascreen --------- Co-authored-by: turnoffthiscomputer <[email protected]> * Fix deeplink 2 (#560) * fix deeplink * fix deeplink * yarn nice * feat: Use vision for MRZ scanning (SEL-47) (#557) * feat: Use vision for MRZ scanning * modify label to position the smartphone during the OCR scan --------- Co-authored-by: turnoffthiscomputer <[email protected]> * SEL-255: improved loading screen with estimated wait times (#550) * create new loading screen and rename static to misc * fix route * save wip loading screen * save wip animation * save static wip design * continue * splash * add a loading screen text helper * add test for loading screen text * save wip. almost there * update haptic logic * better feedback and add dev scren * save current work * update text logic and tests * load passport metadata in loading screen * simplify and fix tests * test for additional exponents * add new animation * rename file * consolidate ui useEffect and fix loading screen layout * fix current state * remove mockPassportFlow param * merge new loading screen and new notification logic * simplify * update lock * use passportMetadata instead of metadata * save simplification * update loading text based on pr feedback and tests * Bump v2.5.1: ios 122; android 60 (#561) * increment build to 120 * bump builds for 2.5.1. ios 121; android 60 * clean up logic * upgrade react native firebase for privacy manifests * update react native keychain to fix could not recover issue (#564) * fix: update ocr corrections (#563) * Chore: Polish proof history to prep for release (#566) * clean up nav and home boundaries, passport data screen insets * migrate proof history screen out of settings * minor clean up * save wip * add new ibm plex mono font and clean up proof detail screen * remove test data * remove extra loading screen text * remove unnecessary ceil * Bump v2.5.1; ios 123; android 62 (#565) * bump to build 61 * bump ios version * update version * Feature/add prettier formatter (#568) * Add Prettier configuration and ignore files for code formatting - Created .prettierignore to exclude specific directories and files from formatting. - Added .prettierrc.yml with custom settings for print width and trailing commas. - Updated package.json to include Prettier and its Solidity plugin as dependencies, along with scripts for formatting and checking code. * Run prettier formatting * fix nationality using mock passports * SEL-181 & SEL-252: Update mobile app events (#570) * improve analytics handling * add error boundary that flushes segment events before error occurs * upgrade segment analytics package * flush analytics when user encounters error screen * track all click events * add tracking to loading screen * better init and click event names * track cloud backup and modal actions * use __DEV__ for debugging * add tracking to account recovery, auth, mock data * return false instead of throwing * add more tracking events * save wip event updating * abstract analytic event names * update click events * clean up * move reasons comment * add unsupported passport event * Feature/enhance self verification root (#569) * Add SelfVerificationConsumer contract for self-verification logic - Introduced an abstract contract, SelfVerificationConsumer, that extends SelfVerificationRoot. - Implemented nullifier tracking, verification success events, and customizable validation and update methods for nullifiers. - Added error handling for nullifier check failures and hooks for derived contracts to implement custom logic after successful verification. * Add SelfHappyBirthday contract example using SelfVerificationConsumer - Introduced SelfHappyBirthday contract that allows users to claim USDC on their birthday. - Integrated SelfVerificationConsumer for handling verification and nullifier tracking. - Added functions to set claimable amount and window, along with event emissions for state changes. - Implemented logic to check if the claim is within the user's birthday window and transfer USDC accordingly. * Refactor imports in HappyBirthday contract for better organization - Updated import statements in HappyBirthday.sol to use relative paths for ISelfVerificationRoot, SelfCircuitLibrary, and SelfVerificationConsumer. - Improved code readability and maintainability by organizing imports more logically. * Refactor Airdrop contract to use SelfVerificationConsumer for registration logic - Updated Airdrop contract to inherit from SelfVerificationConsumer instead of SelfVerificationRoot. - Refactored mappings for user identifiers and nullifiers for improved clarity and functionality. - Enhanced error handling and updated function parameters for consistency. - Implemented new validation and update methods for nullifiers, streamlining the registration process. - Removed deprecated verifySelfProof function and integrated logic into new methods. * Add events and refactor SelfVerificationRoot and related contracts - Introduced new events in SelfVerificationRoot for verification configuration updates, scope changes, and attestation ID management. - Updated Airdrop contract to remove deprecated events and added a new event for Merkle root updates. - Refactored SelfPassportERC721 to inherit from SelfVerificationConsumer, enhancing verification logic and event handling. - Improved function parameters for consistency and clarity across contracts. * Refactor contracts to use SelfVerificationRoot and enhance verification logic - Removed SelfVerificationConsumer contract and updated related contracts to inherit from SelfVerificationRoot. - Refactored mappings and event emissions in Airdrop, HappyBirthday, and SelfPassportERC721 for improved clarity and functionality. - Enhanced verification success hooks to include user identifiers and nullifiers for better tracking. - Updated constructor parameters for consistency across contracts and improved error handling for user registration and claims. * Refactor constructor in SelfPassportERC721 for improved readability * Refactor function parameters in SelfVerificationRoot and related contracts * Refactor constructor parameter names in IdentityVerificationHub, Airdrop, IdentityRegistry, and ProxyRoot contracts for improved clarity and consistency * fix getCircuitName function (#575) * fix getCircuitName function * fix getCircuitName function * feat: Read ID cards (#571) * Update GitHub checkout action from v3 to v4 (#544) * Bump build version 2.5.2 to test react native keychain (#572) * bump build and version * bump version 2.5.2 * don't downgrade react native keychain * update app/README.md toolchain instructions (#140) * bump build (#580) --------- Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: turboblitz <[email protected]> Co-authored-by: motemotech <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: James Niken <[email protected]> Co-authored-by: Kevin Lin <[email protected]> Co-authored-by: leopardracer <[email protected]> Co-authored-by: Olof Andersson <[email protected]> * feat(wip): register circuit for aadhaar * chore: add anon aadhar circuits * chore: remove sc and disclose selfrica test * feat: extract aadhaar qr data * test: aadhaar qr data extract circuit * test: aadhaar register circuit * feat: extract pincode and ph no last 4 digit * fix: register aadhaar nullifier and commitment * test: Verify commitment circuit of aadhaar * feat: add photoHash inside commitment * feat: build Aadhaar OFAC SMT * feat: ofac check and reveal data (test done) * test: qr extractor for custom data input * feat: add state as reveal data inside VC and disclose * chore: add comments * fix: num2Ceil component * chore: review changes * chore: use passport SignatureVerifier * fix: signatureVerifier inputs * feat: extract ascii values of fields * feat: provide users the flexibility to reveal specific characters of a field * chore: refactor * test: register aadhaar for tampered data * test(wip): should return 0 if in ofac list * test: ofac check * test: register aadhaar circuit for different qr data * merge dev into main (#683) * remove sdk/tests (#622) * remove sdk/tests * chore: update yarn.lock --------- Co-authored-by: Ayman <[email protected]> * fix: add range check on paddedInLength of shaBytesDynamic (#623) * fix ci (#626) * implement self uups upgradeable (#592) * implement self uups upgradeable * small changes in identityVerificationHubImplV2 * delete aderyn.toml * chore: add custom verifier * chnage return output * feat: use self structs and a Generic output struct * feat: add userIdentifier, nullifier, forbiddencountries to returned output * add root view functions from registry * fix: build and compilation errors * add userDefined data into selfVerificationRoot * "resolve conflicts" * fix compilation problem * fix how to register verification config * test: CustomVerifier * fix verification root and hub integration * add scope check in hub impl * replace poseidon hash to ripemd+sha256 * add todo list * feat: refactor and add test cases for generic formatter * add performUserIdentifierCheck in basicVerification * change how to handle additionalData and fix stack too deep * start adding test codes * fix dependency problems in monorepo * fix: forbidden countries (#612) LGTM! * able to run test code * pass happy path * delete unused codes * change error code name, add caller address validation and add scripts to run test and build in monorepo * add all test cases in vcAndDisclose flow * remove comment out * chore: use actual user identifier outputs * success in registration tests * cover all cases * pass contractVersion instead of circuitVersion * fix disclose test * chore: add natspecs for ImplHubV2, CustomVerifier and GenericFormatter * change val name and remove unused lines * add val name change * remove userIdentifier from return data * feat: use GenericDiscloseOutput struct in verfication hook fix test cases for user identifier * chore: change the function order for Hub Impl V2 (#625) * fix nat specs * add nat spec in SelfStructs --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Nesopie <[email protected]> * prettier (#629) * CAN auth - android (#613) * add missed files * add NFCMethodSelectionScreen * bump android build --------- Co-authored-by: Justin Hernandez <[email protected]> * feat: add MRZ correction method to NFCMethodSelectionScreen (#627) * add npm auth token env (#632) * bump sdk version (#633) * publish npm package when merging on dev * bump common sdk version * replace yarn publish by npm publish * update common package version * Simplify dev mode gesture (#635) * Simplify developer mode gesture * Enable dev mode on MockData screen with five taps * add build smt function to common sdk * update vc_and_disclose_id test (dev branch) (#641) * fix: vc_and_disclose_id test * chore: yarn prettier * Show modal on NFC scan error (#642) * Add help button and error modal actions * fix the screen management * yarn nice * Bump build v2.5.4: ios 132; android 71 (#631) * bump version and build numbers * remove tamagui/toast * fix marketing version * fix: update TD1 and TD3 checks (#643) * bum yarn.lock * Bump build: ios 133; android 72 and build fixes (#654) * update gesture version and bump android build * bump and fix ios build * update lock files * fixes * fix fotoapparat library source * Update example contracts to include EUID usage (#656) * refactor: update HappyBirthday contract to V2 with support for E-Passport and EUID cards, introduce bonus multipliers, and enhance verification logic * refactor: update Airdrop contract to V2 with support for E-Passport and EU ID Card attestations * refactor: remove BASIS_POINTS constant from Airdrop contract * feat: introduce SelfIdentityERC721 contract for issuing NFTs based on verified identity credentials, replacing SelfPassportERC721 * fix: update verification functions in Airdrop, HappyBirthday, and SelfIdentityERC721 contracts to use customVerificationHook * cherry pick commit from add-test-self-verification... * block non-dev pr to main branch * audit fixes (#645) * merge dev branch into main (#624) * remove sdk/tests (#622) * remove sdk/tests * chore: update yarn.lock --------- Co-authored-by: Ayman <[email protected]> * fix: add range check on paddedInLength of shaBytesDynamic (#623) * fix ci (#626) --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> * update contracts (#628) * remove sdk/tests (#622) * remove sdk/tests * chore: update yarn.lock --------- Co-authored-by: Ayman <[email protected]> * fix: add range check on paddedInLength of shaBytesDynamic (#623) * fix ci (#626) * implement self uups upgradeable (#592) * implement self uups upgradeable * small changes in identityVerificationHubImplV2 * delete aderyn.toml * chore: add custom verifier * chnage return output * feat: use self structs and a Generic output struct * feat: add userIdentifier, nullifier, forbiddencountries to returned output * add root view functions from registry * fix: build and compilation errors * add userDefined data into selfVerificationRoot * "resolve conflicts" * fix compilation problem * fix how to register verification config * test: CustomVerifier * fix verification root and hub integration * add scope check in hub impl * replace poseidon hash to ripemd+sha256 * add todo list * feat: refactor and add test cases for generic formatter * add performUserIdentifierCheck in basicVerification * change how to handle additionalData and fix stack too deep * start adding test codes * fix dependency problems in monorepo * fix: forbidden countries (#612) LGTM! * able to run test code * pass happy path * delete unused codes * change error code name, add caller address validation and add scripts to run test and build in monorepo * add all test cases in vcAndDisclose flow * remove comment out * chore: use actual user identifier outputs * success in registration tests * cover all cases * pass contractVersion instead of circuitVersion * fix disclose test * chore: add natspecs for ImplHubV2, CustomVerifier and GenericFormatter * change val name and remove unused lines * add val name change * remove userIdentifier from return data * feat: use GenericDiscloseOutput struct in verfication hook fix test cases for user identifier * chore: change the function order for Hub Impl V2 (#625) * fix nat specs * add nat spec in SelfStructs --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Nesopie <[email protected]> * prettier (#629) --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: nicoshark <[email protected]> Co-authored-by: Nesopie <[email protected]> * fix: vc_and_disclose_id test (#640) * fix: vc_and_disclose_id test * chore: yarn prettier * fix: check if a config id exists * chore: change the function where the config not set verification is happening * fix: add await * feat: add getConfigId function in SelfVerificationRoot (#650) * feat: add getConfigId function in SelfVerificationRoot * update comment --------- Co-authored-by: motemotech <[email protected]> * chore: fix ofac end index in eu id cards * chore: fix tests * fix: example contracts and tests --------- Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: nicoshark <[email protected]> * Update deployment module for Identity Verification Hub V2 with detailed documentation and library linkage for CustomVerifier. Update initialization process to reflect changes in V2 implementation, ensuring proper setup for proxy deployment. (#658) * publish npm-package (#651) * App/eu id updates (#638) * fix build issues * generate disclosure proof with euids * generate disclosure proof with euids * Eu id updates 2 (#648) * update vc_and_disclose_id test (dev branch) (#641) * fix: vc_and_disclose_id test * chore: yarn prettier * Show modal on NFC scan error (#642) * Add help button and error modal actions * fix the screen management * yarn nice * Bump build v2.5.4: ios 132; android 71 (#631) * bump version and build numbers * remove tamagui/toast * fix marketing version * fix: update TD1 and TD3 checks (#643) * bum yarn.lock * add version and user defined data --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> * remove the mock user define data * get the useridentifier as a hash from the user defined data * chore: add version and userDefinedData * feat: use the version in register / dsc proofs as well * update calculateUserIdentifierHash * yarn nice * refactor: consolidate user context data handling and update payload structure * fix typing issues on sha1 * remove console.log(sha1) * fix sha1 import * refactor: streamline userDefinedData handling and adjust payload type for circuit * refactor: update sha1 usage and enhance logging in calculateUserIdentifierHash * yarn nice * yarn lint common * use ts-ignore for sha1 import * fix app ci tests * fix typing issue * remove unused ts-ignore * cast uuid before calling generateinputs * bump qrcode version * add tsup on the qrcode sdk * fix: exports on selfxyz/qrcode * update how we define config.version * fix yarn imports * yarn format --------- Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Ayman <[email protected]> * Hotfix contract compile error (#660) * Fix previous rebase error * Refactor deployment module for Identity Verification Hub V2. * Fix/sdk (#652) * fix: sdk build configs * chore: SelfBackendVerifier (WIP) * feat: add custom verification * feat: consider destination chain in user defined data * chore: export attestation id * chore: export attestation id * chore: export config storage * chore: don't throw an error if the proof is not valid * chore: trim abi and rm typechain types * refactor * chore: rm unnecessary exports * 📝 Add docstrings to `fix/sdk` (#653) Docstrings generation was requested by @remicolin. * https://github.com/selfxyz/self/pull/652#issuecomment-2992046545 The following files were modified: * `sdk/core/src/utils/hash.ts` * `sdk/core/src/utils/proof.ts` * `sdk/core/src/utils/utils.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * review fixes * chore: fix package.json cjs types * chore: add minor changes to checks * feat: add InMemoryConfigStore, allIds constant and verificationResult type * chore: export Verification config * feat: change the verification config types * fix: throw issues early if verification config is null * fix: update yarn.lock file * chore: lint * fix: rm ts expect error directive * fix: contract tests * use excluded countries instead forbidden countries list * chore: change types in constnats --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update npm-publish workflow and bump core package version to 1.0.0 (#661) * update import * Update get verification config visibility (#664) * Update deployment module for Identity Verification Hub V2 to correct file paths and module name for deployment commands. * Add troubleshooting documentation for verification issues in deployHubV2.ts. Include manual verification steps and common failure reasons to assist users during deployment. * Change visibility of getVerificationConfigV2 function from internal to public in IdentityVerificationHubImplV2 contract to allow external access. * Apply BUSL v1.1 license headers to app (#665) * Add BSL license headers to app sources * prettier * fix license reference - https://spdx.org/licenses/BUSL-1.1.html * bump build: android 73 (#659) * Contracts/deploy staging (#668) * update scripts * deploy vc and disclose id * fix the deployment scripts on staging * update yarn.lock * bump ios build and version (#669) * configure coderabbitai (#670) * tweak coderabbit * bump * more thorough test spec * Apply BSL to app codebase (#639) * Clean up root license wording * Simplify SPDX header * simplify license and rename BSL to BUSL * fix merge issues * fix missing method --------- Co-authored-by: Justin Hernandez <[email protected]> * SEL-423 apply xcode build suggestions (#671) * apply recommended app settings from xcode * stick to portrait orientation and update target settings * remove app clip references * Circuit audit fixes (#644) * feat: add range checks before use of LessEqThan and SelectSubArray * fix: Num2Bits_strict to constrain virtualKey * bump core version * bump core version and fix ci * chore: use npm_auth_token in yarnrc * chroe: rm yarnrc changes * chore: update npm publish * chore: run npm publish manually * chore: change hub contract address (#675) * Update npm-publish.yml * chore: use proper secret when publishing * feat: enable publishing if workflow was triggered manually * Contracts/update verifier (#673) * update hardhat config * update vc and disclose verifier * update vc and disclose verifier script and run it * update test self verification root * update verifier * bump sdk version and use new hub address * chore: update zk-kit binary merkle root dep (#674) * refactor deployment scripts (#678) * feat: add register eu id instances (#682) * feat: add register eu id instances * feat: add new instances * chore: update scripts * chore: fix sig alg * chore: rm circuits --------- Co-authored-by: Ayman <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: nicoshark <[email protected]> Co-authored-by: Nesopie <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Kevin Lin <[email protected]> Co-authored-by: kevinsslin <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Eric Nakagawa <[email protected]> * fix: commitment hash * fix: register aadhaar test * chore: refactor * feat: reveal data in packed bytes * feat: add constrain on delimiterIndices * feat: reveal timestamp * merge main to feat/aadhaar * fix: tests * feat: hash pubKey * feat: add registry contract * feat: Update HubImplV2 (WIP) * add functions to generate aadhaar data (WIP) * modularize aadhaar data generation (WIP) * fix(wip): register test * fix: test qr extractor * fix * chore: refactor functions * feat: add age extractor and tested * feat: add isMiniumAge check * fix: prepareAadhaarTestData func * registry contract tests * feat: registry contract tests * feat: extract fields from qr data bytes * chore: refactor mockData * feat: move minimum age to revealPackedData * feat: create a constant.ts to retrive fields from unpacked bytes * chore: refactor * fix: exports * rebase * rebase * feat: add public signal ,indices mapping * chore: add public output to indices mapping * fix:AADHAAR_PUBLIC_SIGNAL_INDICES * feat: make nullifier public * fix: nullifier cal for disclose circuits * feat: merge isMiniumAgeValid and miniumAge signal * fix: disclsoe test * feat: support for user identifier and secret * chore :refactor * feat: ofac test last name , firstname * feat: add forbidden_countries_list check * feat: add tests for aadhaar (WIP) * failing ofac tests * feat: finish contract tests * fix: merge conflicts * update the common package to be usable in circuits and contracts * lint everything * coderabbit fixes * chore: update name dob,yob aadhaar ofac tree * feat: merge ofac and reverse ofac check into one * test: merged ofac constrain * SELF-253 feat: add user email feedback (#889) * feat: add sentry feedback * add sentry feedback to web * feat: add custom feedback modal & fix freeze on IOS * yarn nice * update lock * feat: show feedback widget on NFC scan issues (#948) * feat: show feedback widget on NFC scan issues * fix ref * clean up * fix report issue screen * abstract send user feedback email logic * fixes * change text to Report Issue * sanitize email and track event messge * remove unnecessary sanitization * add sanitize error message tests * fix tests * save wip. almost done * fix screen test * fix screen test * remove non working test --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> * chore: centralize license header checks (#952) * chore: centralize license header scripts * chore: run license header checks from root * add header to other files * add header to bundle * add migration script and update check license headers * convert license to mobile sdk * migrate license headers * remove headers from common; convert remaining * fix headers * add license header checks * update unsupported passport screen (#953) * update unsupported passport screen * yarn nice * feat: support new ofac trees * fix: qr extractor tests * chore: remove unassigned age signal * chore: modify timestamp func comment * fix: add constrain on photo bytes delimiter * fix: add range check on minimumAge within 2^7 * fix: range check for country not in list * chore: remove dummy constrain * fix: assert lessthan * fix: check is photoEOI valid * fix: replace maxDataLength with qrPaddedLength for valid del indices * feat: update forbidden countries in disclose and disclose id * feat: convert name to uppercase * fix: add constrain between delimiter and photoEOI * feat: support for phno len 4 and 10 * chore: hard-code attestaion_ID to 3 * feat: calculate nullifier using uppercase name * feat: add real id support * fix: rebase error * chore: refactor * add new nullifier and commitment calc * fix: reuse uppercase name from verify commitment * feat: add a function that will iterate though all pubkeys * chore: skip real id test * chore: yarn format * chore: update yarn.lock * chore: rm trailing / from import * chore: add support for issuing state * chore: linting and types * chore: rm types script from circuits * chore: add license header --------- Co-authored-by: nicoshark <[email protected]> Co-authored-by: turnoffthiscomputer <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: turboblitz <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: James Niken <[email protected]> Co-authored-by: Kevin Lin <[email protected]> Co-authored-by: leopardracer <[email protected]> Co-authored-by: Olof Andersson <[email protected]> Co-authored-by: vishal <[email protected]> Co-authored-by: Vishalkulkarni45 <[email protected]> Co-authored-by: kevinsslin <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Eric Nakagawa <[email protected]> * fix: CLA not supported (#1027) * fix: CLA not supported * fix "yarn android" building * remove unnecessary commands --------- Co-authored-by: Justin Hernandez <[email protected]> * chore: bump app version v2.6.5 (#1034) * update gem lock * bump build and version * fix app versions * chore: fix nfc passport reader private repo access (#1042) * add internal repo pat * update nfc passport reader location * update workflows to use PAT to access NFC Passport Reader * fix ci * update logic to access private repo * build(android): support 16KB page size (#1043) * build(android): support 16KB page size * fix 16kb * update lock * chore: bump v2.6.5 for release (#1036) * bump build * update to ssh clone to fix local build * update podfile lock * fix version * Feat/build aadhaar (#1044) * feat: build aadhaar circuits as well in the ci * feat: add register aadhaar case handling * fix aadhaar register output after building the cpp circuit (#1045) * fix: metro js crypto module build issues (#1047) * fix sdk build issues * fix build error * sort and fix dependencies * add constants-browserify * feat: add new verifiers (#1049) * feat: add new verifiers * format: contracts * fix: ofac check to aadhaar (#1050) * fix: hub-v2 (#1051) * Add DisclosureVerified event for comprehensive verification tracking (#945) * Add VerificationPerformed event to track verification calls - Added VerificationPerformed event with comprehensive tracking fields - Captures requestor contract, version, attestation ID, chain ID, config ID, user identifier, output, and user data - Enhanced _executeVerificationFlow to return additional tracking data - Event emission placed after verification completion for accurate tracking * chore: run formatter * chore: rename verify event name to DisclosureVerified * move clearPassportData, markCurrentDocumentAsRegistered, reStorePassportDataWithRightCSCA to SDK (#1041) * Move self app store to mobile sdk (#1040) * chore(mobile-sdk-alpha): remove unused tslib dependency (#1053) * remove tslib -- seems unused * remove deps accidentally added to root * build file * remove unused imports (#1055) * fix: sha256 signed attr tests (#1058) * fix mock screen launch (#1059) * Hotfix: Belgium ID cards (#1061) * feat: parse belgium TD1 mrz android * feat: Parse Belgium TD1 MRZ IOS * fix: OFAC trees not found (#1060) * fix: relax OFAC tree response validation * test: cover OFAC tree edge cases * fix stateless * revert and fix types * fix tests * [SELF-723] feat: add structured NFC and Proof logging (#1048) * feat: add structured NFC logging * fix ci * Fix: add deps * logging fixes. use breadcrumbs * fix android build * update SeverityLevel * [SELF-705] feat: add proof event logging (#1057) * feat: add proof event logging * refactor: unify sentry event logging * fix types * fix mock * simplify * code rabbit feedback * fix tests --------- Co-authored-by: seshanthS <[email protected]> * skip on dev (#1063) * don't get fancy just disable (#1064) * saw it building so gonna try (#1065) * Dev (#1074) * chore: bump v2.6.5 rd2 (#1067) * commit wip version bump * remove from building * chore: update tooling dependencies (#1069) * chore: update tooling dependencies * chore: align react typings and node types * update lock * chore: minor fixes across monorepo (#1068) * small fixes * fixes * fix gesture handler error * ci fixes * fix yarn build; add workflow ci (#1075) * add new workspace ci * disable package version check for now * build before checks * format * fix in future pr * feat: add functions for disclosing aadhaar attributes (#1033) * feat: add functions for disclosing aadhaar attributes * format * chore: update monorepo artifacts (#1079) * remove unneeded artifacts, skip building circuits * update md files * cleans up unused parts of sdk interface, adds inline documentation, (#1078) * cleans up unused parts of sdk interface, adds inline documentation, * fix up build * yolo * Feat/aadhaar sdk (#1082) * feat: add aadhaar support to the ts sdk * feat: aadhaar support to go sdk * chore: refactor * move clearPassportData, markCurrentDocumentAsRegistered, reStorePassportDataWithRightCSCA to SDK (#1041) * Move self app store to mobile sdk (#1040) * chore(mobile-sdk-alpha): remove unused tslib dependency (#1053) * remove tslib -- seems unused * remove deps accidentally added to root * build file * remove unused imports (#1055) * fix: sha256 signed attr tests (#1058) * fix mock screen launch (#1059) * Hotfix: Belgium ID cards (#1061) * feat: parse belgium TD1 mrz android * feat: Parse Belgium TD1 MRZ IOS * fix: OFAC trees not found (#1060) * fix: relax OFAC tree response validation * test: cover OFAC tree edge cases * fix stateless * revert and fix types * fix tests * [SELF-723] feat: add structured NFC and Proof logging (#1048) * feat: add structured NFC logging * fix ci * Fix: add deps * logging fixes. use breadcrumbs * fix android build * update SeverityLevel * [SELF-705] feat: add proof event logging (#1057) * feat: add proof event logging * refactor: unify sentry event logging * fix types * fix mock * simplify * code rabbit feedback * fix tests --------- Co-authored-by: seshanthS <[email protected]> * skip on dev (#1063) * don't get fancy just disable (#1064) * saw it building so gonna try (#1065) * chore: bump v2.6.5 rd2 (#1067) * commit wip version bump * remove from building * chore: update tooling dependencies (#1069) * chore: update tooling dependencies * chore: align react typings and node types * update lock * chore: minor fixes across monorepo (#1068) * small fixes * fixes * fix gesture handler error * ci fixes * fix yarn build; add workflow ci (#1075) * add new workspace ci * disable package version check for now * build before checks * format * fix in future pr * feat: add functions for disclosing aadhaar attributes (#1033) * feat: add functions for disclosing aadhaar attributes * format * chore: update monorepo artifacts (#1079) * remove unneeded artifacts, skip building circuits * update md files * chore: update hub contract address * format * fix: add aadhaar in AllIds * chore: bump to v1.1.0-beta --------- Co-authored-by: vishal <[email protected]> Co-authored-by: Leszek Stachowski <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Seshanth.S🐺 <[email protected]> Co-authored-by: seshanthS <[email protected]> * feat: change to gcp attestation verification (#959) * feat: change to gcp attestation verification * lint * fix e2e test * chore: don't check PCR0 mapping if building the app locally * fmt:fix --------- Co-authored-by: Justin Hernandez <[email protected]> * Mobile SDK: move provingMachine from the app (#1052) * Mobile SDK: move provingMachine from the app * lint, fixes * fix web build? * lint * fix metro build, add deps * update lock files * move the status handlers and proving machine tests * may it be * fix up * yolo --------- Co-authored-by: Justin Hernandez <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]> * Revert "Mobile SDK: move provingMachine from the app (#1052)" (#1084) This reverts commit 8983ac22688f731bca8890cbf9be9c85b4ac2bf…
This was referenced Oct 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
provingMachinedependency on navigation ref in favor of handling navigation changes via events handled inside the SDK client itself.Tested
Added unit tests for event emitting / handling, created a mock passport and observed user being redirected through the event listener.
Summary by CodeRabbit
New Features
Bug Fixes
Tests