#109 Changed AssignedTasks Chron From 6h to 30min. #112
Conversation
|
@criske thank you for your Pull Request. I'll assign someone to review it soon. |
| public void reviewPeriodHasCorrectFormat() { | ||
| MatcherAssert.assertThat( | ||
| Duration.parse(ReviewAssignedTasks.EVERY_30_MINUTES), | ||
| Matchers.equalTo(Duration.ofMinutes(30)) | ||
| ); | ||
| } |
There was a problem hiding this comment.
@amihaiemil Also tested in a local branch if the scheduler works, but is stupidly complicated to test it... with a custom Clock and TaskScheduler :D
https://gist.github.com/criske/92d71eac24a63fbd36ded2e1882fac99
There was a problem hiding this comment.
@criske looks good. Don't worry, we don't have to test the Scheduler. It's part of Spring, which we are supposed to trust... :D
|
@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
|
@rultor merge |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 3min) |
|
@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
Fixes #109