Improve downloading files from Grid #3207
Merged
+236
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
force-pushed
the
tests/investigate-flaky-grid-download-test
branch
2 times, most recently
from
d7e11ca to
5f13db7
Compare
e.g. `WebDriverException: Unable to execute request for an existing session: Failed to get file attributes: /tmp/uuid10303077473612519879bd9e1b7a-d55b-448c-a408-74900b29cc6b/download6602653343356759423/.com.google.Chrome.GhiE6d` The bug: SeleniumHQ/selenium#16720
Use file modification time for detecting if the downloading is completed. * File size + time was added to Grid API in Selenium 4.39.0: SeleniumHQ/selenium#16589 * Also, downloading large files was significantly optimized in Selenium 4.39.0: SeleniumHQ/selenium#16627
asolntsev
force-pushed
the
tests/investigate-flaky-grid-download-test
branch
from
d0744ea to
e1ef6f7
Compare
asolntsev
changed the title
Currently, tests a'la `downloadLargeFile` download a file of size 5MB. But now you can out 2048 or even 4096 instead.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the downloading files from Grid is
Speed
Downloading large files was significantly optimized in Selenium 4.39.0: SeleniumHQ/selenium#16627
Accuracy
Now we check file "last modification time" for detecting if the downloading is completed.
File size + time was added to Grid API in Selenium 4.39.0: SeleniumHQ/selenium#16589