Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't scroll up the dropdown if unnecessary #183

Merged
merged 2 commits into from
Nov 3, 2013

Conversation

dosource
Copy link
Contributor

@dosource dosource commented Nov 3, 2013

Try this: scroll down in the dropdown then press UP repeatedly.

Before fix : dropdown scrolls up even if unnecessary, e.g. the new active option is entirely visible in the dropdown.
After : dropdown scrolls up only if the target option is out of the visible part of the dropdown.

Verified

This commit was signed with the committer’s verified signature.
paulbalandan John Paul E. Balandan, CPA
Scroll down in dropdown then press UP.
Before fix : dropdown scrolls up even if unnecessary, e.g. the new active option is entirely visible in the dropdown.
After : dropdown scrolls up only if the target option is out of the visible part of the dropdown.
brianreavis added a commit that referenced this pull request Nov 3, 2013
Don't scroll up the dropdown if unnecessary
@brianreavis brianreavis merged commit f8f38aa into selectize:master Nov 3, 2013
@brianreavis
Copy link
Member

Thanks! This is part of v0.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants