Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ADL for ostream operator<< overloads. #1696

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Dimi1010
Copy link
Collaborator

No description provided.

@Dimi1010 Dimi1010 requested a review from seladb as a code owner January 22, 2025 12:02
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 27.02703% with 27 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (d60c699) to head (10aad8a).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
Packet++/header/LdapLayer.h 0.00% 24 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1696      +/-   ##
==========================================
- Coverage   83.11%   83.11%   -0.01%     
==========================================
  Files         277      277              
  Lines       48207    48207              
  Branches    10192     9897     -295     
==========================================
- Hits        40069    40067       -2     
+ Misses       7243     7242       -1     
- Partials      895      898       +3     
Flag Coverage Δ
alpine320 75.10% <27.27%> (-0.01%) ⬇️
fedora40 75.12% <27.27%> (-0.04%) ⬇️
macos-13 80.61% <12.12%> (-0.01%) ⬇️
macos-14 80.61% <12.12%> (ø)
macos-15 80.59% <12.12%> (ø)
mingw32 70.84% <27.27%> (-0.03%) ⬇️
mingw64 70.80% <27.27%> (-0.03%) ⬇️
npcap 85.17% <26.66%> (-0.09%) ⬇️
rhel94 74.98% <27.27%> (+<0.01%) ⬆️
ubuntu2004 58.56% <27.27%> (-0.03%) ⬇️
ubuntu2004-zstd 58.68% <27.27%> (ø)
ubuntu2204 74.89% <27.27%> (-0.01%) ⬇️
ubuntu2204-icpx 61.49% <12.12%> (+0.04%) ⬆️
ubuntu2404 75.15% <27.27%> (-0.01%) ⬇️
unittest 83.11% <27.02%> (-0.01%) ⬇️
windows-2019 85.27% <26.66%> (-0.01%) ⬇️
windows-2022 85.30% <26.66%> (-0.01%) ⬇️
winpcap 85.26% <26.66%> (ø)
xdp 50.53% <27.27%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimi1010 Dimi1010 merged commit 2d0fc5a into seladb:dev Jan 23, 2025
41 checks passed
@Dimi1010 Dimi1010 deleted the reafactor/adl-fixes branch January 23, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants