support ubuntu 24 in CI #1486
support ubuntu 24 in CI #1486
Conversation
|
@tigercosmos we need to install venv on all Linux containers to make it work. In Ubuntu the package is |
I see, let me figure out. |
|
blocking by #1384 due to: |
This reverts commit 5f80c36.
| else | ||
| apt-get update | ||
| apt-get install -y python3 python3-venv python3-dev | ||
| fi |
There was a problem hiding this comment.
this should be done in the container
There was a problem hiding this comment.
ya, we can do that as well, @seladb can you update the containers?
There was a problem hiding this comment.
I can do it if you want, but you just need to open a MR here:
https://github.com/seladb/PcapPlusPlus-DockerImages
There was a problem hiding this comment.
cool, I didn't know this.
There was a problem hiding this comment.
@seladb shouldn't /PcapPlusPlus-DockerImages under the organization?
| @@ -31,6 +31,7 @@ jobs: | |||
| apk update && apk add cppcheck python3-dev | |||
| python3 -m pip install cmake-format clang-format==18.1.6 | |||
|
|
|||
| # TODO: investigate how to run pre-commit with `venv` | |||
| - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1 | |||
There was a problem hiding this comment.
Did you try
| - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1 | |
| - name: Activate virtualenv | |
| run: | | |
| ${{ matrix.python }} -m venv ./venv | |
| . .venv/bin/activate | |
| echo PATH=$PATH >> $GITHUB_ENV | |
| - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1 |
| @@ -52,6 +53,9 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| include: | |||
| - image: ubuntu2404 | |||
| python: python3 | |||
There was a problem hiding this comment.
now that everybody use python: python3 maybe we could drop it no ?
| ${{ matrix.python }} -m pip install -U pip | ||
| ${{ matrix.python }} -m venv ./venv | ||
| source ./venv/bin/activate | ||
| ${{ matrix.python }} -m pip install pip |
There was a problem hiding this comment.
| ${{ matrix.python }} -m pip install pip | |
| ${{ matrix.python }} -m pip install -U pip |
Else I think this command do nothing no ?
There was a problem hiding this comment.
not sure, maybe yes, because we use venv now.
There was a problem hiding this comment.
as you're executing
${{ matrix.python }} -m pip -> I supposed it's already installed no?
If you really want to install it
${{ matrix.python }} -m ensurepip
| ${{ matrix.python }} -m pip install -r ci/run_tests/requirements.txt | ||
| ${{ matrix.python }} ci/run_tests/run_tests.py --interface eth0 ${{ matrix.test-flags }} | ||
|
|
||
| - name: Test Examples | ||
| shell: bash |
There was a problem hiding this comment.
the default shell is sh, and to source the venv activator, we need bash.
DON'T MERGE
Blocking by #1489 now
venvfor pip installation