apply clang-format to `Tests` #1456

tigercosmos · 2024-06-21T07:36:43Z

part of #1248

tigercosmos · 2024-06-21T08:29:58Z

It's weird. I checked the modification of LoggerTests.cpp, and it should not cause any error.

TestLogger                         : FAILED (D:\a\PcapPlusPlus\PcapPlusPlus\Tests\Pcap++Test\Tests\LoggerTests.cpp:213). Assert EQUAL failed:
   Actual:   20
   Expected: 21

seladb · 2024-06-25T09:19:21Z

It's weird. I checked the modification of LoggerTests.cpp, and it should not cause any error.
TestLogger                         : FAILED (D:\a\PcapPlusPlus\PcapPlusPlus\Tests\Pcap++Test\Tests\LoggerTests.cpp:213). Assert EQUAL failed:
   Actual:   20
   Expected: 21

Does it work for you locally?

tigercosmos · 2024-06-25T11:04:26Z

It's weird. I checked the modification of LoggerTests.cpp, and it should not cause any error.
TestLogger                         : FAILED (D:\a\PcapPlusPlus\PcapPlusPlus\Tests\Pcap++Test\Tests\LoggerTests.cpp:213). Assert EQUAL failed:
   Actual:   20
   Expected: 21
Does it work for you locally?

No, it doesn't. It's weird, as the code shouldn't make any difference of the logic.

tigercosmos · 2024-06-26T08:12:45Z

Tests/Pcap++Test/Tests/LoggerTests.cpp


+// clang-format off


don't know why, but seems the formatting of this part will break the tests.

What the diference between before and after clang-format ?

like this: #define<tab>SEPARATOR '\\'

Dimi1010 · 2024-07-07T05:42:21Z

Tests/Packet++Test/Tests/Asn1Tests.cpp

@@ -6,343 +6,342 @@
 #include <cstring>
 #include <sstream>

-PTF_TEST_CASE(Asn1DecodingTest)
+PTF_TEST_CASE(Asn1DecodingTest){ // Context specific


Indentation formatting is all messed up here.

true, let me fix it.

tigercosmos · 2024-07-07T14:17:17Z

@seladb ready for review.

This reverts commit 815531e.

seladb

I only reviewed 14 files, but wanted to post my comments so far

Tests/Packet++Test/Tests/IPv4Tests.cpp

Tests/Packet++Test/Tests/NflogTests.cpp

Tests/Packet++Test/Tests/Asn1Tests.cpp

codecov · 2024-07-17T09:08:47Z

Codecov Report

Attention: Patch coverage is 77.02162% with 574 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (add1746) to head (718d14c).

Files	Patch %	Lines
Tests/Packet++Test/Tests/LdapTests.cpp	53.57%	91 Missing ⚠️
Tests/Pcap++Test/main.cpp	18.42%	62 Missing ⚠️
Tests/Pcap++Test/Tests/IpMacTests.cpp	58.97%	48 Missing ⚠️
Tests/Packet++Test/Tests/PacketTests.cpp	56.96%	34 Missing ⚠️
Tests/Packet++Test/main.cpp	12.82%	33 Missing and 1 partial ⚠️
Tests/Packet++Test/Tests/HttpTests.cpp	74.74%	24 Missing and 1 partial ⚠️
Tests/Packet++Test/Tests/SipSdpTests.cpp	85.20%	25 Missing ⚠️
Tests/Packet++Test/Utils/TestUtils.cpp	52.17%	19 Missing and 3 partials ⚠️
Tests/Pcap++Test/Tests/FilterTests.cpp	48.57%	15 Missing and 3 partials ⚠️
Tests/Packet++Test/Tests/DnsTests.cpp	73.84%	16 Missing and 1 partial ⚠️
... and 37 more

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1456      +/-   ##
==========================================
- Coverage   82.09%   80.60%   -1.50%     
==========================================
  Files         273      273              
  Lines       43551    44647    +1096     
  Branches     9340     9305      -35     
==========================================
+ Hits        35755    35987     +232     
- Misses       7207     8069     +862     
- Partials      589      591       +2

Flag	Coverage Δ
fedora39	`74.24% <88.82%> (+0.02%)`	⬆️
macos-12	`80.40% <93.31%> (+0.08%)`	⬆️
macos-13	`79.82% <92.44%> (+0.12%)`	⬆️
macos-14	`79.74% <92.44%> (+0.12%)`	⬆️
mingw32	`70.69% <ø> (-0.02%)`	⬇️
mingw64	`70.69% <ø> (-0.02%)`	⬇️
npcap	`83.92% <ø> (-0.04%)`	⬇️
rhel94	`73.95% <88.27%> (+0.03%)`	⬆️
ubuntu2004	`53.06% <29.40%> (-4.19%)`	⬇️
ubuntu2004-zstd	`53.19% <29.40%> (-4.19%)`	⬇️
ubuntu2204	`73.92% <88.26%> (+0.03%)`	⬆️
ubuntu2204-icpx	`55.88% <ø> (-0.01%)`	⬇️
unittest	`80.60% <77.02%> (-1.50%)`	⬇️
windows-2019	`83.96% <ø> (-0.02%)`	⬇️
windows-2022	`83.97% <ø> (-0.02%)`	⬇️
winpcap	`83.94% <ø> (ø)`
xdp	`48.81% <61.54%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tests/Packet++Test/Tests/IPv4Tests.cpp

Tests/Packet++Test/Tests/Asn1Tests.cpp

seladb

I reviewed 36 / 68 files so far, sharing a few more comments

Tests/Packet++Test/Tests/DhcpV6Tests.cpp

Tests/Packet++Test/Tests/EthAndArpTests.cpp

Tests/Packet++Test/Tests/FtpTests.cpp

Tests/Pcap++Test/Common/GlobalTestArgs.h

Tests/Packet++Test/Tests/IcmpV6Tests.cpp

Tests/Packet++Test/Tests/LdapTests.cpp

seladb · 2024-07-22T07:35:53Z

@tigercosmos CI fails after these changes, can you take a look?

tigercosmos · 2024-07-22T14:44:21Z

@seladb Fixed the test. It seems that includes reordering matters, so I still made a change in 344ff70.

Tests/Packet++Test/Tests/LdapTests.cpp

Tests/Packet++Test/Tests/PacketUtilsTests.cpp

seladb

@tigercosmos I finished reviewing all changes in this PR. Please find a few last comments (plus previous comments that weren't fixed yet). Once we fixed them we should be good to merge this PR

Tests/Pcap++Test/Tests/TcpReassemblyTests.cpp

seladb · 2024-07-25T05:53:03Z

@tigercosmos I have no idea why Codecov includes the test in the test coverage report, I'm sure it wasn't like that before and I'm not sure what's changed 😕

egecetin · 2024-07-25T07:13:14Z

Not checked recent changes but it is possible to add ignore rule to codecov.yml https://docs.codecov.com/docs/ignoring-paths#:~:text=You%20can%20use%20the%20top,will%20be%20skipped%20during%20processing.

tigercosmos · 2024-07-25T13:28:55Z

@seladb Thanks for your patient review!

tigercosmos requested a review from seladb as a code owner June 21, 2024 07:36

tigercosmos changed the base branch from master to dev June 21, 2024 07:36

tigercosmos force-pushed the clang-format0621 branch 2 times, most recently from 61c6d59 to fafe143 Compare June 21, 2024 07:41

egecetin added this to the Augest 2024 Release milestone Jun 21, 2024

tigercosmos added 3 commits June 26, 2024 16:23

first

8e510c5

logger

52a3cb0

other

a32c83d

tigercosmos force-pushed the clang-format0621 branch from bf9a046 to a32c83d Compare June 26, 2024 08:06

tigercosmos commented Jun 26, 2024

View reviewed changes

tigercosmos and others added 2 commits June 26, 2024 17:42

revert header ordering

e512cc5

Merge remote-tracking branch 'origin/dev' into clang-format0621

2c12900

Dimi1010 reviewed Jul 7, 2024

View reviewed changes

tigercosmos mentioned this pull request Jul 7, 2024

introducing clang-format #1248

Closed

9 tasks

some fix

f341b0d

tigercosmos requested a review from Dimi1010 July 7, 2024 14:17

tigercosmos added 2 commits July 7, 2024 23:28

update

815531e

Revert "update"

bc354cd

This reverts commit 815531e.

seladb reviewed Jul 17, 2024

View reviewed changes

Tests/Packet++Test/Tests/IPv4Tests.cpp Outdated Show resolved Hide resolved

Tests/Packet++Test/Tests/NflogTests.cpp Outdated Show resolved Hide resolved

Tests/Packet++Test/Tests/Asn1Tests.cpp Show resolved Hide resolved

fix wrong format

724bf63

seladb reviewed Jul 18, 2024

View reviewed changes

Tests/Packet++Test/Tests/IPv4Tests.cpp Outdated Show resolved Hide resolved

Tests/Packet++Test/Tests/Asn1Tests.cpp Show resolved Hide resolved

seladb reviewed Jul 18, 2024

View reviewed changes

tigercosmos added 2 commits July 18, 2024 18:24

disable width length

68e18e0

format again

c72c47e

tigercosmos added 5 commits July 22, 2024 12:00

fix

c4df19f

includes

e5a16eb

long string

651b95a

fix format for ipmac

9bf2d10

fix break

e666d89

tigercosmos requested a review from seladb July 22, 2024 03:13

tigercosmos added 2 commits July 22, 2024 23:24

fix test

1ddd8f6

fix the include order

344ff70

seladb reviewed Jul 23, 2024

View reviewed changes

Tests/Packet++Test/Tests/LdapTests.cpp Outdated Show resolved Hide resolved

Tests/Packet++Test/Tests/LdapTests.cpp Outdated Show resolved Hide resolved

Tests/Packet++Test/Tests/PacketUtilsTests.cpp Outdated Show resolved Hide resolved

tigercosmos added 4 commits July 23, 2024 18:08

include

ff05fb0

fix

5129199

fix

bbf5092

fix

1b39d7f

seladb reviewed Jul 24, 2024

View reviewed changes

Tests/Pcap++Test/Tests/TcpReassemblyTests.cpp Outdated Show resolved Hide resolved

Tests/Pcap++Test/Tests/TcpReassemblyTests.cpp Outdated Show resolved Hide resolved

Tests/Pcap++Test/Tests/TcpReassemblyTests.cpp Outdated Show resolved Hide resolved

tigercosmos added 5 commits July 24, 2024 18:15

fix

1caa137

revert

75a0b14

comment

74d6aa6

comment

379f334

ignore

718d14c

tigercosmos requested a review from seladb July 24, 2024 09:50

seladb approved these changes Jul 25, 2024

View reviewed changes

seladb mentioned this pull request Jul 25, 2024

Consolidate shared DeviceList functionality under a common base class. #1488

Open

Merge branch 'dev' into clang-format0621

9ba00c7

tigercosmos merged commit 123994c into seladb:dev Jul 25, 2024
38 checks passed

tigercosmos deleted the clang-format0621 branch July 25, 2024 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

apply clang-format to `Tests` #1456

apply clang-format to `Tests` #1456

tigercosmos commented Jun 21, 2024 •

edited

Loading

tigercosmos commented Jun 21, 2024

seladb commented Jun 25, 2024

tigercosmos commented Jun 25, 2024

tigercosmos Jun 26, 2024

clementperon Jul 11, 2024

tigercosmos Jul 11, 2024

Dimi1010 Jul 7, 2024

tigercosmos Jul 7, 2024

tigercosmos commented Jul 7, 2024

seladb left a comment

codecov bot commented Jul 17, 2024 •

edited

Loading

seladb left a comment

seladb commented Jul 22, 2024

tigercosmos commented Jul 22, 2024

seladb left a comment

seladb commented Jul 25, 2024

egecetin commented Jul 25, 2024

tigercosmos commented Jul 25, 2024

apply clang-format to Tests #1456

apply clang-format to Tests #1456

Conversation

tigercosmos commented Jun 21, 2024 • edited Loading

tigercosmos commented Jun 21, 2024

seladb commented Jun 25, 2024

tigercosmos commented Jun 25, 2024

tigercosmos Jun 26, 2024

Choose a reason for hiding this comment

clementperon Jul 11, 2024

Choose a reason for hiding this comment

tigercosmos Jul 11, 2024

Choose a reason for hiding this comment

Dimi1010 Jul 7, 2024

Choose a reason for hiding this comment

tigercosmos Jul 7, 2024

Choose a reason for hiding this comment

tigercosmos commented Jul 7, 2024

seladb left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 17, 2024 • edited Loading

Codecov Report

seladb left a comment

Choose a reason for hiding this comment

seladb commented Jul 22, 2024

tigercosmos commented Jul 22, 2024

seladb left a comment

Choose a reason for hiding this comment

seladb commented Jul 25, 2024

egecetin commented Jul 25, 2024

tigercosmos commented Jul 25, 2024

apply clang-format to `Tests` #1456

apply clang-format to `Tests` #1456

tigercosmos commented Jun 21, 2024 •

edited

Loading

codecov bot commented Jul 17, 2024 •

edited

Loading