Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed release packages using Github artifact attestation #1390

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

egecetin
Copy link
Collaborator

@egecetin egecetin commented May 9, 2024

Recently GitHub release public beta for artifact signing https://github.blog/2024-05-02-introducing-artifact-attestations-now-in-public-beta/. With this PR, generated artifacts should also generate .sigstore.json files to verify packages. It should be ready to review. Since I changed permissions from a PR, looks like write permissions prohibited. I can't find a way to tweak it to get passing result from CI.

Note: Unfortunately requires drop of Ubuntu 18.04 support because of node version

@egecetin egecetin marked this pull request as ready for review May 12, 2024 09:09
@egecetin egecetin requested a review from seladb as a code owner May 12, 2024 09:09
@egecetin egecetin marked this pull request as draft June 2, 2024 17:54
@egecetin
Copy link
Collaborator Author

egecetin commented Jun 27, 2024

@seladb I updated this PR and finished work. Only need (or dependency) is #1408. After the merge of #1408 just need to test with Ubuntu 24.04 and Fedora 39 and it is ready to merge. You can review this PR when you have time for any change you might want.

@seladb
Copy link
Owner

seladb commented Jul 6, 2024

@egecetin we removed Ubuntu 18.04, do you think you can update the PR and resolve conflicts?
If the PR is ready for review I can review it

@egecetin egecetin marked this pull request as ready for review July 9, 2024 14:38
@egecetin
Copy link
Collaborator Author

egecetin commented Jul 9, 2024

@seladb It is ready

@tigercosmos
Copy link
Collaborator

@egecetin seems the CI have some errors?

@egecetin
Copy link
Collaborator Author

egecetin commented Jul 9, 2024

@tigercosmos It is because of permissions. Since the write permissions set from a PR it prohibits the write permission so, it fails. You can check my master branch or run from my test tag https://github.com/egecetin/PcapPlusPlus/actions/runs/9858969300

@tigercosmos
Copy link
Collaborator

@tigercosmos It is because of permissions. Since the write permissions set from a PR it prohibits the write permission so, it fails. You can check my master branch or run from my test tag https://github.com/egecetin/PcapPlusPlus/actions/runs/9858969300

I see. it's cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants