Port https://github.com/ethereum/go-ethereum/pull/32363#66
Merged
Port https://github.com/ethereum/go-ethereum/pull/32363#66
Conversation
The order of the checks was wrong which would have allowed a call to modexp with `baseLen == 0 && modLen == 0` post fusaka. Also handles an edge case where base/mod/exp length >= 2**64 --------- Co-authored-by: Felix Lange <fjl@twurst.com>
stevenlanders
approved these changes
Sep 9, 2025
stevenlanders
left a comment
stevenlanders
left a comment
There was a problem hiding this comment.
do we need to do anything special to ensure c.eip7823 is set so that these are enforced?
Collaborator
Author
yeah that'd have to be tested on the sei-chain PR that integrates with this since the config lives there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of the checks was wrong which would have allowed a call to modexp with
baseLen == 0 && modLen == 0post fusaka.Also handles an edge case where base/mod/exp length >= 2**64