Expose set read limits for websocket server to prevent OOM#62
Merged
Expose set read limits for websocket server to prevent OOM#62
Conversation
kamwithak
approved these changes
Jul 25, 2025
kamwithak
reviewed
Jul 25, 2025
| } | ||
|
|
||
| // SetReadLimits sets the limit for max message size to limit the request message size. | ||
| // |
Author
There was a problem hiding this comment.
was just following the other conventions
codchen
reviewed
Jul 25, 2025
| // SetReadLimits sets the limit for max message size to limit the request message size. | ||
| // | ||
| // This method would be useful to prevent the server from OOM when taking too large messages. | ||
| func (s *Server) SetReadLimits(maxMessageSize int64) { |
Collaborator
There was a problem hiding this comment.
sorry I'm stupid where is this called?
Author
There was a problem hiding this comment.
yeah, will be called in Sei-chain once this is merged
codchen
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will expose SetReadLimits for websocket server so that upstream client can use this method to set max message size to prevent OOM