Limit strcpy_s call to Windows platform
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sources to work with UE5, updated ImGui and ImPlot. Also changed readme.md to reflect this fork's state.
…mGui's internal headers (with required supporting headers) to be public facing so devs have access to ImGui vec math and other luxuries to make their own widgets under the ImGui namespace
…input even though old input API works and is somewhat functional I'd rather be inline with latest standards. Also added all known keys to proxy for passing to ImGui for IsKeyDown/IsKeyPressed/IsKeyReleased routines. Code's a ugly and architecture not exactly perfect but works for the most part, will revisit when I get some time.
…dated it to reflect new change from OP
…date Replace deprecated references to FStringClassReference
|
Unreal has for this purpose FPlatformString::Strcpy which is typedef'd to their own per-platform implementation. Used it myself and found no problems so far. |
|
https://github.com/IDI-Systems/UnrealImGui replaces all instances of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b346fa8 breaks macOS (an likely Linux) compatibility with the use of
strcpy_sinSource/ImGui/Private/ImGuiContextManager.cppon line 275.My proposed merge request simply disables this code on non-Windows platforms. That said, we can probably support the added functionality on Linux and macOS by following this Stack Overflow answer.