Pin variable name for global key #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous release of snippet introduced a new variable named `globalAnalyticsKey`, which after getting mangled by minifier became `i`. Unfortunately, all the documentation now refers to this variable as `i`. It is possible that the when next version of snippet is released, the same variable gets a different mangled name, say `b`. This means that the documentation will be voided. To prevent this, we're now locking the variable name to `i` forever. We can't change it now since the documentation is already in the wild.
silesky
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous release of snippet introduced a new variable named
globalAnalyticsKey, which after getting mangled by minifier becamei. Unfortunately, all the documentation now refers to this variable asi. It is possible that the when next version of snippet is released, the same variable gets a different mangled name, sayb. This means that the documentation will be voided. To prevent this, we're now locking the variable name toiforever. We can't change it now since the documentation is already in the wild.