Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context about batching to destination overview page [DOC-904] #6593

Merged
merged 11 commits into from
May 28, 2024

Conversation

forstisabella
Copy link
Contributor

Proposed changes

Added sections covering stream batching and bulk batching to the Destination overview page.

Merge timing

ASAP

Related issues (optional)

https://segment.atlassian.net/browse/DOC-904

@forstisabella forstisabella added the content-update updates to content that are not new features, includes grammar fixes, added notes label May 22, 2024
@forstisabella forstisabella requested a review from a team as a code owner May 22, 2024 23:20
@forstisabella forstisabella requested review from cmastr and removed request for a team May 22, 2024 23:20
@forstisabella forstisabella changed the title Add context about batching to destination overview page Add context about batching to destination overview page [DOC-904] May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 0048cbd
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/664f5c82550cb30008cd66c5
😎 Deploy Preview https://deploy-preview-6593--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@peterdemartini peterdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I added some suggestions, please change and adjust them as you see fit.


Segment also uses [batching](#batching) to increase deliverability to your destinations. Some destinations have batching enabled by default, and some, like Segment's [Webhook (Actions) Destination](/docs/connections/destinations/catalog/actions-webhook/), let you opt in to batching.

> warning "Event batching might lead to observability loss"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> warning "Event batching might lead to observability loss"
> warning "Event batching might lead to observability loss in some cases, we're actively working on fixing this"

src/connections/destinations/index.md Outdated Show resolved Hide resolved
src/connections/destinations/index.md Outdated Show resolved Hide resolved
src/connections/destinations/index.md Outdated Show resolved Hide resolved
src/connections/destinations/index.md Outdated Show resolved Hide resolved
src/connections/destinations/index.md Outdated Show resolved Hide resolved
@forstisabella forstisabella merged commit 599eb8a into develop May 28, 2024
3 of 4 checks passed
@forstisabella forstisabella deleted the batching-docs branch May 28, 2024 16:54
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants