Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Segment timestamps are in UTC #6408

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Clarify Segment timestamps are in UTC #6408

merged 3 commits into from
Jun 24, 2024

Conversation

joeynmq
Copy link
Contributor

@joeynmq joeynmq commented Apr 18, 2024

Proposed changes

It is not indicated in our documentation where the timezone of the Segment’s timestamps falls. We receive tickets from time to time requesting this information.

Merge timing

ASAP once approved

Related issues (optional)

https://segment.atlassian.net/browse/KCS-1314

@joeynmq joeynmq added the KCS label Apr 18, 2024
@joeynmq joeynmq marked this pull request as ready for review April 30, 2024 00:20
@joeynmq joeynmq requested a review from a team as a code owner April 30, 2024 00:20
@joeynmq joeynmq requested review from pwseg and removed request for a team April 30, 2024 00:20
@cmastr
Copy link
Contributor

cmastr commented Jun 3, 2024

Someone else already fixed this in a separate PR - #6400

@cmastr cmastr closed this Jun 3, 2024
@joeynmq
Copy link
Contributor Author

joeynmq commented Jun 5, 2024

hey @cmastr, I would like to reopen this PR since I will be updating some information regarding timezone in a different page (https://segment.com/docs/connections/spec/common/#timestamps) from the other PR you shared (#6400). Let me know if you need anything from me, thanks!!

@joeynmq joeynmq reopened this Jun 5, 2024
@pwseg pwseg added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jun 24, 2024
@pwseg
Copy link
Contributor

pwseg commented Jun 24, 2024

It's probably not a bad idea to have this info in the Spec, as well. Not everyone will see it in Audiences, necessarily.

@pwseg pwseg merged commit 50df150 into develop Jun 24, 2024
4 checks passed
@pwseg pwseg deleted the joeynmq-patch-4 branch June 24, 2024 15:44
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes KCS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants