Google Consent Mode [DOC-839] #6164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rvadera12
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Looks great! Left a couple of comments. Could we also replace the info banner with, Google is enforcing consent starting March 6th and here are instructions to implement this with a link in the docs to the consent section. We can plan to remove this in the future, but just so it is easier for customers to find it
src/connections/destinations/catalog/google-tag-manager/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/google-ads-classic/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/personas-display-video-360/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-google-analytics-4/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-google-analytics-4-web/index.md
Outdated
Show resolved
Hide resolved
| * **Option 1:** | ||
| 1. Navigate to **Connections > Destinations** and select your Google Analytics 4 Web destination. | ||
| 2. Go to the **mappings** tab of the destination. | ||
| 3. Select the mapping you want to edit.' |
There was a problem hiding this comment.
Suggested change
| 3. Select the mapping you want to edit.' | |
| 3. Select the Set Configuration Mapping to edit.' |
There was a problem hiding this comment.
I disagree with this step, it should be that they select the mapping they want to edit
src/connections/destinations/catalog/actions-google-analytics-4-web/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-google-analytics-4-web/index.md
Outdated
Show resolved
Hide resolved
…4/index.md Co-authored-by: rvadera12 <[email protected]>
Co-authored-by: rvadera12 <[email protected]>
…0/index.md Co-authored-by: rvadera12 <[email protected]>
pwseg
reviewed
Mar 4, 2024
src/connections/destinations/catalog/google-ads-classic/index.md
Outdated
Show resolved
Hide resolved
pwseg
approved these changes
Mar 4, 2024
rvadera12
approved these changes
Mar 4, 2024
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge timing
Related issues (optional)