Skip to content
This repository was archived by the owner on Dec 19, 2025. It is now read-only.

Comments

chore: bump golang.org/x/tools to v0.34.0 for Go 1.25 compatibility#167

Merged
mckern merged 1 commit intosegmentio:masterfrom
chenrui333:go-1.25
Aug 21, 2025
Merged

chore: bump golang.org/x/tools to v0.34.0 for Go 1.25 compatibility#167
mckern merged 1 commit intosegmentio:masterfrom
chenrui333:go-1.25

Conversation

@chenrui333
Copy link
Contributor

chore: bump golang.org/x/tools to v0.34.0 for Go 1.25 compatibility

   # golang.org/x/tools/internal/tokeninternal
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/golang.org/x/tools@v0.17.0/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)

relates to Homebrew/homebrew-core#226636

@samstride
Copy link

@mckern , any chance you can review and approve this PR?

@slhmy
Copy link

slhmy commented Aug 18, 2025

Really need this PR to be merged, 1.25 is a great version for developers to move on.
If no active contributors are available, could you help? @farbodsalimi

@mckern mckern merged commit 2187838 into segmentio:master Aug 21, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants