chore: Upgrade to aws-sdk-go-v2 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion is essentially complete. The only gap is in the implementation of `Rows.Next()`, where a context is not available from the caller for use when fetching more results from Athena, because the function is defined in its interface to not include a context. Related to contexts, the driver does not yet implement `DriverContext`, but should be, separately.
wdbetts
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion is essentially complete. The only gap is in the implementation of
Rows.Next(), where a context is not available from the caller for use when fetching more results from Athena, because the function is defined in its interface to not include a context.Related to contexts, the driver does not yet implement
DriverContext, but should be, separately.