Add --no-warn-conflicts flag #646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlanett
force-pushed
the
add-no-warn-conflicts-flag--PR-1
branch
from
ef93859 to
c3f9137
Compare
When loading secrets from multiple services, chamber will warn about environment
variables that get overwritten. Use the `--no-warn-conflicts` flag to suppress
these warnings when conflicts are expected:
chamber exec --no-warn-conflicts defaults/app production/app -- <your executable>
Add tests to verify the storage systems handle invalid AWS_PROFILE variables.
Fix tests which don't handle invalid profiles.
mlanett
force-pushed
the
add-no-warn-conflicts-flag--PR-1
branch
from
c3f9137 to
d3af627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let us improve the use cases to support inheritance of secrets. For example:
At startup time, a service loads its secrets using chamber with multiple paths, e.g.
chamber exec defaults/myservice staging/myservice -- …. This leads to many warnings of overwritten variables. However we are intentionally overwriting them, so the warnings do not reveal problems but instead pollute service logs. Thus we propose a flag --no-warn-conflicts to suppress these warnings.