Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send RFC 7231 Formatted User Agent #582

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Send RFC 7231 Formatted User Agent #582

merged 1 commit into from
Jun 4, 2018

Conversation

f2prateek
Copy link
Contributor

@f2prateek f2prateek commented Jun 4, 2018

As per the library guidelines, we want to send a custom user agent for all requests from this library.

https://paper.dropbox.com/doc/Analytics-library-guidelines-2trBhLKQD4Soz4VatvuGR#:uid=631141099033910690508560&h2=User-Agent

The header is sent in the format analytics-android/, where version is the same version sent in context.library.version for events.

Ref: https://segment.atlassian.net/browse/LIB-381

    As per the library guidelines, we want to send a custom user agent for all requests from this library.

    https://paper.dropbox.com/doc/Analytics-library-guidelines-2trBhLKQD4Soz4VatvuGR#:uid=631141099033910690508560&h2=User-Agent

    The header is sent in the format analytics-android/<version>, where version is the same version sent in context.library.version for events.

    Ref: https://segment.atlassian.net/browse/LIB-381
@codecov-io
Copy link

Codecov Report

Merging #582 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
- Coverage   83.21%   82.93%   -0.28%     
==========================================
  Files          30       30              
  Lines        2454     2455       +1     
  Branches      282      282              
==========================================
- Hits         2042     2036       -6     
- Misses        329      335       +6     
- Partials       83       84       +1
Impacted Files Coverage Δ
.../java/com/segment/analytics/ConnectionFactory.java 100% <100%> (ø) ⬆️
.../src/main/java/com/segment/analytics/ValueMap.java 86.39% <0%> (-2.73%) ⬇️
...ain/java/com/segment/analytics/internal/Utils.java 74.13% <0%> (-1.15%) ⬇️
...cs/src/main/java/com/segment/analytics/Traits.java 92.3% <0%> (-1.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c8c84...d4f62b9. Read the comment docs.

@f2prateek f2prateek merged commit f92c58c into master Jun 4, 2018
@f2prateek f2prateek deleted the user-agent branch June 4, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants