Support schema defaults for new events. #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 83.22% 83.24% +0.02%
==========================================
Files 30 30
Lines 2444 2453 +9
Branches 278 281 +3
==========================================
+ Hits 2034 2042 +8
- Misses 327 328 +1
Partials 83 83
Continue to review full report at Codecov.
|
f2prateek
force-pushed
the
default-events
branch
from
9c64624 to
943dbfb
Compare
If an event is not present in the tracking plan, we'll now lookup the schema defaults for the project. If the event is disabled in the schema default, it will only be sent to the Segment integration (i.e. api.segment.io). If the event is enabled in the schema default, it will be sent to all integrations. Ref: https://paper.dropbox.com/doc/Schema-Client-Side-Defaults-DufdS8Ej43mnFXvvMqm1b
f2prateek
force-pushed
the
default-events
branch
from
943dbfb to
9cf5714
Compare
|
Made some test updates to get better coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an event is not present in the tracking plan, we'll now lookup the schema defaults for the project.
If the event is disabled in the schema default, it will only be sent to the Segment integration (i.e. api.segment.io).
If the event is enabled in the schema default, it will be sent to all integrations.
Ref: https://paper.dropbox.com/doc/Schema-Client-Side-Defaults-DufdS8Ej43mnFXvvMqm1b