Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send disabled events to Segment #550

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Send disabled events to Segment #550

merged 1 commit into from
Nov 2, 2017

Conversation

f2prateek
Copy link
Contributor

@f2prateek f2prateek commented Oct 24, 2017

@codecov-io
Copy link

codecov-io commented Oct 24, 2017

Codecov Report

Merging #550 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #550     +/-   ##
=========================================
+ Coverage   82.95%   83.25%   +0.3%     
=========================================
  Files          30       30             
  Lines        2441     2443      +2     
  Branches      277      278      +1     
=========================================
+ Hits         2025     2034      +9     
+ Misses        332      326      -6     
+ Partials       84       83      -1
Impacted Files Coverage Δ
...va/com/segment/analytics/IntegrationOperation.java 89.58% <100%> (+0.22%) ⬆️
...cs/src/main/java/com/segment/analytics/Traits.java 93.4% <0%> (+1.09%) ⬆️
...ain/java/com/segment/analytics/internal/Utils.java 75.28% <0%> (+1.14%) ⬆️
.../src/main/java/com/segment/analytics/ValueMap.java 89.11% <0%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd86e8...c9dbd20. Read the comment docs.

@f2prateek
Copy link
Contributor Author

cc @segmentio/gateway

@f2prateek f2prateek merged commit 8b2ee96 into master Nov 2, 2017
@f2prateek f2prateek deleted the send-disabled-events branch November 2, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants