Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling to getInputStream on errors #537

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Fix calling to getInputStream on errors #537

merged 1 commit into from
Oct 23, 2017

Conversation

yoavst
Copy link
Contributor

@yoavst yoavst commented Jul 23, 2017

When the status code is above 300 (Don't know for sure if for all codes, but for some of them for sure), getInputStream() throws FileNotFoundException and the stream is in getErrorStream().

@codecov-io
Copy link

codecov-io commented Jul 23, 2017

Codecov Report

Merging #537 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
+ Coverage   83.22%   83.24%   +0.02%     
==========================================
  Files          30       30              
  Lines        2438     2441       +3     
  Branches      277      277              
==========================================
+ Hits         2029     2032       +3     
  Misses        326      326              
  Partials       83       83
Impacted Files Coverage Δ
...src/main/java/com/segment/analytics/Analytics.java 75.34% <0%> (ø) ⬆️
...ain/java/com/segment/analytics/internal/Utils.java 75.28% <100%> (+0.43%) ⬆️
...cs/src/main/java/com/segment/analytics/Client.java 91.66% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daaa166...ab5add7. Read the comment docs.

@f2prateek
Copy link
Contributor

Is this documented anywhere?

@yoavst
Copy link
Contributor Author

yoavst commented Sep 22, 2017

@f2prateek f2prateek merged commit 325430d into segmentio:master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants