Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Middlewares #515

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Add Middlewares #515

merged 1 commit into from
Mar 8, 2017

Conversation

f2prateek
Copy link
Contributor

@f2prateek f2prateek commented Mar 3, 2017

  • Docs
  • Tests
  • Examples

@codecov-io
Copy link

codecov-io commented Mar 3, 2017

Codecov Report

Merging #515 into dev will increase coverage by 3.01%.
The diff coverage is 92.02%.

@@            Coverage Diff             @@
##              dev     #515      +/-   ##
==========================================
+ Coverage   79.89%   82.91%   +3.01%     
==========================================
  Files          28       30       +2     
  Lines        2099     2417     +318     
  Branches      230      275      +45     
==========================================
+ Hits         1677     2004     +327     
+ Misses        349      330      -19     
- Partials       73       83      +10
Impacted Files Coverage Δ
...om/segment/analytics/integrations/Integration.java 11.76% <ø> (ø)
...m/segment/analytics/integrations/AliasPayload.java 100% <100%> (ø)
...egment/analytics/integrations/IdentifyPayload.java 100% <100%> (ø)
...m/segment/analytics/integrations/GroupPayload.java 100% <100%> (ø)
...m/segment/analytics/integrations/TrackPayload.java 100% <100%> (ø)
...ain/java/com/segment/analytics/internal/Utils.java 74.4% <100%> (+10.64%)
.../segment/analytics/integrations/ScreenPayload.java 100% <100%> (+25%)
...ava/com/segment/analytics/RealMiddlewareChain.java 100% <100%> (ø)
...a/com/segment/analytics/internal/Iso8601Utils.java 81.73% <81.73%> (ø)
...om/segment/analytics/integrations/BasePayload.java 94.18% <92.18%> (+7.08%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1227e...3ff3121. Read the comment docs.

@f2prateek f2prateek force-pushed the middlewares branch 3 times, most recently from c59064d to d3a63cc Compare March 8, 2017 20:48
@f2prateek
Copy link
Contributor Author

Verified no breaking changes:

diff a_35e7775b/com.segment.analytics.Analytics b_80638212/com.segment.analytics.Analytics
8d7
<   public void group(java.lang.String, com.segment.analytics.Traits);
15,16d13
<   public void screen(java.lang.String);
<   public void screen(java.lang.String, com.segment.analytics.Properties);
diff a_35e7775b/com.segment.analytics.Analytics$Builder b_80638212/com.segment.analytics.Analytics$Builder
17d16
<   public com.segment.analytics.Analytics$Builder middleware(com.segment.analytics.Middleware);
diff a_35e7775b/com.segment.analytics.AnalyticsContext$Campaign b_80638212/com.segment.analytics.AnalyticsContext$Campaign
12d11
<   public java.lang.String term();
diff a_35e7775b/com.segment.analytics.AnalyticsContext$Referrer b_80638212/com.segment.analytics.AnalyticsContext$Referrer
14d13
<   public com.segment.analytics.AnalyticsContext$Referrer putUrl(java.lang.String);
Only in a_35e7775b: com.segment.analytics.Cartographer
Only in a_35e7775b: com.segment.analytics.Cartographer$Builder
Only in a_35e7775b: com.segment.analytics.Middleware
Only in a_35e7775b: com.segment.analytics.Middleware$Chain
diff a_35e7775b/com.segment.analytics.Properties b_80638212/com.segment.analytics.Properties
42d41
<   public java.lang.String coupon();
diff a_35e7775b/com.segment.analytics.integrations.AliasPayload b_80638212/com.segment.analytics.integrations.AliasPayload
1a2
>   public com.segment.analytics.integrations.AliasPayload(com.segment.analytics.AnalyticsContext, com.segment.analytics.Options, java.lang.String);
4,5d4
<   public com.segment.analytics.integrations.AliasPayload$Builder toBuilder();
<   public com.segment.analytics.integrations.BasePayload$Builder toBuilder();
Only in a_35e7775b: com.segment.analytics.integrations.AliasPayload$Builder
diff a_35e7775b/com.segment.analytics.integrations.BasePayload b_80638212/com.segment.analytics.integrations.BasePayload
1a2
>   public com.segment.analytics.integrations.BasePayload(com.segment.analytics.integrations.BasePayload$Type, com.segment.analytics.AnalyticsContext, com.segment.analytics.Options);
6d6
<   public java.util.Date timestamp();
10d9
<   public abstract com.segment.analytics.integrations.BasePayload$Builder toBuilder();
Only in a_35e7775b: com.segment.analytics.integrations.BasePayload$Builder<P
diff a_35e7775b/com.segment.analytics.integrations.GroupPayload b_80638212/com.segment.analytics.integrations.GroupPayload
2c2
<   public com.segment.analytics.integrations.GroupPayload(java.lang.String, java.util.Date, java.util.Map<java.lang.String, java.lang.Object>, java.util.Map<java.lang.String, java.lang.Object>, java.lang.String, java.lang.String, java.lang.String, java.util.Map<java.lang.String, java.lang.Object>);
---
>   public com.segment.analytics.integrations.GroupPayload(com.segment.analytics.AnalyticsContext, com.segment.analytics.Options, java.lang.String, com.segment.analytics.Traits);
6,7d5
<   public com.segment.analytics.integrations.GroupPayload$Builder toBuilder();
<   public com.segment.analytics.integrations.BasePayload$Builder toBuilder();
Only in a_35e7775b: com.segment.analytics.integrations.GroupPayload$Builder
diff a_35e7775b/com.segment.analytics.integrations.IdentifyPayload b_80638212/com.segment.analytics.integrations.IdentifyPayload
1a2
>   public com.segment.analytics.integrations.IdentifyPayload(com.segment.analytics.AnalyticsContext, com.segment.analytics.Options, com.segment.analytics.Traits);
4,5d4
<   public com.segment.analytics.integrations.IdentifyPayload$Builder toBuilder();
<   public com.segment.analytics.integrations.BasePayload$Builder toBuilder();
Only in a_35e7775b: com.segment.analytics.integrations.IdentifyPayload$Builder
diff a_35e7775b/com.segment.analytics.integrations.ScreenPayload b_80638212/com.segment.analytics.integrations.ScreenPayload
1a2
>   public com.segment.analytics.integrations.ScreenPayload(com.segment.analytics.AnalyticsContext, com.segment.analytics.Options, java.lang.String, java.lang.String, com.segment.analytics.Properties);
7,8d7
<   public com.segment.analytics.integrations.ScreenPayload$Builder toBuilder();
<   public com.segment.analytics.integrations.BasePayload$Builder toBuilder();
Only in a_35e7775b: com.segment.analytics.integrations.ScreenPayload$Builder
diff a_35e7775b/com.segment.analytics.integrations.TrackPayload b_80638212/com.segment.analytics.integrations.TrackPayload
1a2
>   public com.segment.analytics.integrations.TrackPayload(com.segment.analytics.AnalyticsContext, com.segment.analytics.Options, java.lang.String, com.segment.analytics.Properties);
5,6d5
<   public com.segment.analytics.integrations.TrackPayload$Builder toBuilder();
<   public com.segment.analytics.integrations.BasePayload$Builder toBuilder();
Only in a_35e7775b: com.segment.analytics.integrations.TrackPayload$Builder
diff a_35e7775b/com.segment.analytics.internal.Utils b_80638212/com.segment.analytics.internal.Utils
8,9d7
<   public static java.lang.String toISO8601String(java.util.Date);
<   public static java.util.Date parseISO8601Date(java.lang.String);
19,22d16
<   public static java.lang.String assertNotNullOrEmpty(java.lang.String, java.lang.String);
<   public static <K, V> java.util.Map<K, V> assertNotNullOrEmpty(java.util.Map<K, V>, java.lang.String);
<   public static <T> T assertNotNull(T, java.lang.String);
<   public static <K, V> java.util.Map<K, V> immutableCopyOf(java.util.Map<K, V>);

@f2prateek f2prateek merged commit 9b680b9 into dev Mar 8, 2017
@f2prateek f2prateek deleted the middlewares branch March 8, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants