Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cartographer #495

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Update cartographer #495

merged 1 commit into from
Jan 26, 2017

Conversation

f2prateek
Copy link
Contributor

Includes 2 fixes/improvements:

  1. Make some methods static
    segmentio/cartographer@0a73875

  2. Support array serialization
    Add support for array serialization cartographer#4

Closes #492

@f2prateek
Update cartographer
e1e0d36 
Includes 2 fixes/improvements:

1. Make some methods static
segmentio/cartographer@0a73875

2. Support array serialization
segmentio/cartographer#4
@NightlyNexus
Copy link

To make sure, the tests don't sync, right?
https://github.com/segmentio/analytics-android/blob/eec87aff2bc1d4754a7858d02c014b6409c7820d/analytics-tests/src/test/java/com/segment/analytics/CartographerTest.java

@f2prateek
Copy link
Contributor Author

Ah yup, though maybe I just consider copying those over too.

@f2prateek f2prateek merged commit c8650a4 into dev Jan 26, 2017
@f2prateek f2prateek deleted the update-cartographer branch January 26, 2017 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f2prateek @NightlyNexus