-
Notifications
You must be signed in to change notification settings - Fork 298
Segment Actions and code #3490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment Actions and code #3490
Conversation
|
Hi @joe-ayoub-segment , the destination is now complete and ready for review. It includes two actions (trackEvent, identifyUser) with full test coverage. The catalog documentation PR is also submitted to segment-docs. Thanks! |
|
This PR adds Collab Travel CRM as a new Segment destination. Collab Travel CRM is an all-in-one platform for modern travel agencies, helping them manage bookings, leads, proposals, and client relationships. What's IncludedDestination: Actions:
Presets:
Authentication: Custom scheme using API Key (webhook secret) EndpointAll events are sent to: WhyTravel agencies using Collab Travel CRM want to:
Testing
Unit TestsAll tests pass for both actions:
End-to-End TestingThe webhook endpoint is live and has been tested with actual Segment payloads: # Test authentication
curl -X POST https://wvjaseexkfrcahmzfxkl.supabase.co/functions/v1/segment-destination \
-H "Authorization: Bearer test_api_key" \
-H "Content-Type: application/json" \
-d '{"type":"track","event":"__segment_test__","properties":{"test":true}}'
# Test identify
curl -X POST https://wvjaseexkfrcahmzfxkl.supabase.co/functions/v1/segment-destination \
-H "Authorization: Bearer test_api_key" \
-H "Content-Type: application/json" \
-d '{"type":"identify","userId":"user_123","traits":{"email":"[email protected]","firstName":"John"}}'
# Test track
curl -X POST https://wvjaseexkfrcahmzfxkl.supabase.co/functions/v1/segment-destination \
-H "Authorization: Bearer test_api_key" \
-H "Content-Type: application/json" \
-d '{"type":"track","event":"Trip Booked","properties":{"order_id":"booking_456","revenue":2500}}'
Related PRs
Documentation PR: [segment-docs PR link]
---
**Copy everything between the `---` markers above** and paste it into your GitHub PR description.
**Don't forget to:**
1. Replace `[segment-docs PR link]` with the actual link to your segment-docs PR once you create it
2. After pasting, reply to Joe on the PR with: `@joe-ayoub-segment PR is now complete and ready for review!` |
|
Hi @odyssey2122 looks like this is a duplicate of #3486 |
|
Duplicate of #3486 |
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'