Skip to content

Conversation

joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Oct 3, 2025

Minor change from ?? to || for optional domain field in GA 4 web.

Testing

Tested locally and in stage

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.57%. Comparing base (41a9de1) to head (c2c4390).
⚠️ Report is 9 commits behind head on main.

❌ Your project status has failed because the head coverage (32.57%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3333       +/-   ##
===========================================
- Coverage   80.32%   32.57%   -47.75%     
===========================================
  Files        1257       14     -1243     
  Lines       25159      703    -24456     
  Branches     5217      119     -5098     
===========================================
- Hits        20208      229    -19979     
+ Misses       4163      474     -3689     
+ Partials      788        0      -788     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joe-ayoub-segment joe-ayoub-segment enabled auto-merge (squash) October 14, 2025 11:54
@joe-ayoub-segment joe-ayoub-segment merged commit 5f7d58c into main Oct 14, 2025
13 of 14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the ga4-web-domain-change branch October 14, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants