-
Notifications
You must be signed in to change notification settings - Fork 284
Stratconn 6122 async action #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b64cfec
to
a1e8e7c
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (12.74%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3173 +/- ##
==========================================
+ Coverage 79.97% 80.05% +0.07%
==========================================
Files 1204 1258 +54
Lines 22312 25284 +2972
Branches 4414 5192 +778
==========================================
+ Hits 17845 20241 +2396
- Misses 3685 4253 +568
- Partials 782 790 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… into STRATCONN-6122_async_action
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
… into STRATCONN-6122_async_action
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.