Skip to content

Conversation

monutwilio
Copy link
Contributor

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 12.74510% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.05%. Comparing base (5d96b8a) to head (e850a6b).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...rketing-cloud/contactDataExtensionV2Async/index.ts 15.38% 33 Missing ⚠️
...ions/salesforce-marketing-cloud/sfmc-operations.ts 6.89% 27 Missing ⚠️
packages/core/src/destination-kit/action.ts 18.18% 18 Missing ⚠️
packages/core/src/destination-kit/index.ts 0.00% 9 Missing ⚠️
...ce-marketing-cloud/contactDataExtensionV2/index.ts 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (12.74%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3173      +/-   ##
==========================================
+ Coverage   79.97%   80.05%   +0.07%     
==========================================
  Files        1204     1258      +54     
  Lines       22312    25284    +2972     
  Branches     4414     5192     +778     
==========================================
+ Hits        17845    20241    +2396     
- Misses       3685     4253     +568     
- Partials      782      790       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Salesforce Marketing Cloud (Actions), Action Field(s):keys,values

Add these new fields as optional instead and assume default values in perform or performBatch block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants