Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Google Ads] Change default syncMode to mirror #2659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Google Ads] Change default syncMode to mirror #2659

wants to merge 1 commit into from

Conversation

maryamsharif
Copy link
Contributor

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@maryamsharif maryamsharif changed the title Default to mirror mode [Google Ads] Change default syncMode to mirror Dec 19, 2024
@maryamsharif maryamsharif marked this pull request as ready for review December 20, 2024 18:24
@maryamsharif maryamsharif requested a review from a team as a code owner December 20, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mode:cloud not-partner-eng-review (cloud) team:segment-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryamsharif @joe-ayoub-segment