Updated Session / App Lifecycle logic #21
Conversation
bsneed
commented
May 1, 2024
bsneed
commented
- More accurately replicated Amplitude's Session logic.
- Added support for amplitude lifecycle events.
- Amplitude specific events are blocked from all destinations other than Amplitude.
- Added privacy manifest.
| } | ||
|
|
||
| func write<T: Codable>(key: String, value: T?) { | ||
| if let value, isBasicType(value: value) { |
There was a problem hiding this comment.
Codable says the value can be encoded/decoded somehow, in this case to UserDefaults. BasicType is something like a primitive. whereas if it's not, and it's a dictionary, we need to store it differently.
|
Hi, @bsneed , would you be able to elaborate about the lifecycle event support? I just got a note from someone at my group in the data team, and they were curious why there were seeing these "[Amplitude] Application Opened" events. I can tell them "because that's what the new update does", but was hoping for a better explanation. |
|
Hi @skydivedan, yeah sure! Those application opened events are what the amplitude SDK would do to properly track mobile sessions. I would've preferred that the Action Destination did this on the segment.com side, but that team wasn't going to have any time opening up in the near future to fix it. I'm not entirely sure how amplitude uses those events internally, but we received reports from customers that their stats on amplitude weren't correct because of these missing events. |
| // if it's amp specific stuff, disable all the integrations except for amp. | ||
| if eventName.contains(Constants.ampPrefix) || eventName == Constants.ampSessionStartEvent || eventName == Constants.ampSessionEndEvent { | ||
| var integrations = disableAllIntegrations(integrations: trackEvent.integrations) | ||
| integrations?.setValue(["session_id": sessionID], forKeyPath: KeyPath(key)) |
There was a problem hiding this comment.
Should the session_id be set outside this block for all events being fired? Currently I see that on Amplitude dashboard all my events are not being grouped together because the session iD is being passed as -1. In earlier version, the timestamp was being set to the session Id and it was correctly grouping all related session events.
New sdk
Previous sdk
