Update amplitude destination to retain session ID #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to amplitude docs, a session should include all events within 5 minutes of each other. This changes the previous implementation's behavior of creating a new session ID ever 5 minutes.
|
Tested manually in debugger by setting the time delay to 10 sec and observing the behavior. Session ID changed if no change was sent for longer than 10 sec, but stayed the same as long as events were sent repeatedly under the time limit. |
prayansh
approved these changes
Apr 21, 2022
…d manually on android emulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to amplitude docs, a session should include all events within 5 minutes of each other. This changes the previous implementation's behavior of creating a new session ID ever 5 minutes.