Formats trait values to trim spaces instead of replacing them with underscore #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cem2ran , When building this, we found Firebase referenced using underscores in their documentation. It seems consistently used throughout their documentation, for example here. Did you find evidence that this isn't the case? Thanks! |
|
@ladanazita As far as I can tell there's only evidence for the trait name being underscored. Not the actual value. All values are referenced as variables, which you must presume has whatever format you feel is right. |
|
Make sense, can you also update the tests @cem2ran to coincide with the changes? Thanks! |
|
Sure thing. |
|
Hi @cem2ran I'm sorry for the delay here. I will get this out this week! |
|
@cem2ran This will be live on version 2.1.0. Thanks for the contribution and your patience here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it quite odd behaviour to format values such that spaces are replaced with underscore.
If I were to send the name of the user or similar I would have the following as the value: 'Cem_Turan' instead of 'Cem Turan'.
This PR changes the behaviour such that surrounding whitespaces and new lines are trimmed.