Skip to content

Commit

Permalink
chore: update kfp-kubernetes release scripts and instructions (kubefl…
Browse files Browse the repository at this point in the history
…ow#11191)

Signed-off-by: Chen Sun <[email protected]>
Signed-off-by: sefgsefg <[email protected]>
  • Loading branch information
chensun authored and sefgsefg committed Sep 18, 2024
1 parent aca7549 commit 12642ae
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
3 changes: 1 addition & 2 deletions kubernetes_platform/python/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ Some steps require elevated permissions to push branches, publish the package, a
Follow the instructions printed out by the script in Step 2, which explain how to push the branch to upstream.

By the end, you
should have pushed a modified `__init__.py`, `conf.py`, `.gitignore`, and
two modified `.readthedocs.yml` files to the release branch.
should have pushed a modified `__init__.py`, `conf.py` (from Step 1), and `.gitignore`, `kubernetes_executor_config_pb2.py` and two modified `.readthedocs.yml` files (from Step 2) to the release branch.

4. [Requires credentials] Go to
[readthedocs.org/projects/kfp-kubernetes/](https://readthedocs.org/projects/kfp-kubernetes/),
Expand Down
10 changes: 8 additions & 2 deletions kubernetes_platform/python/create_release_branch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ else
mv $PKG_ROOT/docs/.readthedocs.yml $REPO_ROOT/.readthedocs.yml
rm $REPO_ROOT/kubernetes_platform/.gitignore


echo "\nNext steps:\n\tPush branch using 'git push --set-upstream upstream $BRANCH_NAME'"
git add $PKG_ROOT/docs/.readthedocs.yml
git add $REPO_ROOT/.readthedocs.yml
git add $REPO_ROOT/kubernetes_platform/.gitignore
git add $REPO_ROOT/*_pb2.py

echo "Next steps:"
echo "1. Inspect and commit the modified files."
echo "2. Push branch using 'git push --set-upstream upstream $BRANCH_NAME'"
fi
2 changes: 1 addition & 1 deletion kubernetes_platform/python/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ else
echo "Created package."

echo "Testing install"
pip install $TARGET_TAR_FILE
pip install $TARGET_TAR_FILE --break-system-packages
INSTALLED_VERSION=$(pip list | grep kfp-kubernetes | awk '{print $2}')
if [[ "$INSTALLED_VERSION" != "$KFP_KUBERNETES_VERSION" ]]
then
Expand Down

0 comments on commit 12642ae

Please sign in to comment.