Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: return value instead of index #57

Merged
merged 28 commits into from
Jan 4, 2020

Conversation

seeliang
Copy link
Owner

@seeliang seeliang commented Jan 4, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 4, 2020

Codecov Report

Merging #57 into master will decrease coverage by 1.07%.
The diff coverage is 92.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   96.38%   95.31%   -1.08%     
==========================================
  Files           2        6       +4     
  Lines          83      128      +45     
  Branches       16       27      +11     
==========================================
+ Hits           80      122      +42     
- Misses          3        6       +3
Impacted Files Coverage Δ
src/molecules/checkbox/index.js 81.81% <100%> (ø) ⬆️
src/helpers/mappingSelectedIndexToResult.js 100% <100%> (ø)
src/helpers/initialFormState.js 100% <100%> (ø)
src/index.js 97.46% <83.33%> (-1.15%) ⬇️
src/helpers/rangeToList.js 88.88% <88.88%> (ø)
src/helpers/generatePropsWithData.js 88.88% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d1dc8...23397a1. Read the comment docs.

@seeliang seeliang changed the title Breaking return value instead of index Breaking: return value instead of index Jan 4, 2020
@seeliang seeliang merged commit 4a44169 into master Jan 4, 2020
This was referenced Jan 4, 2020
@seeliang seeliang deleted the breaking-return-value-instead-of-index branch January 6, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants