Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin GitHub action versions #805

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Pin GitHub action versions #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c32f571
Pin GitHub action versions
72636c Mar 22, 2022
1fa5070
Run Prettier
72636c Mar 22, 2022
501e52d
Clean up unnecessary env and LFS
72636c Mar 22, 2022
b89108b
Clean up template workflows too
72636c Mar 22, 2022
7b0799a
Merge branch 'master' into pin-github-action-versions
72636c Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spicy-gifts-smash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"skuba": patch
---

template/oss-npm-package: Pin GitHub action versions
5 changes: 2 additions & 3 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
name: 'CodeQL'
name: CodeQL

on:
push:
branches: [beta, main, master]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should hopefully resolve the following warning:

Analyze (javascript)
1 issue was detected with this workflow: Please make sure that every branch in on.pull_request is also in on.push so that Code Scanning can compare pull requests against the state of the base branch.

https://github.com/seek-oss/skuba/actions/runs/2020191009

pull_request:
schedule:
- cron: '0 22 * * 0'
Expand All @@ -22,7 +21,7 @@ jobs:
matrix:
# Override automatic language detection by changing the below list
# Supported options are ['csharp', 'cpp', 'go', 'java', 'javascript', 'python']
language: ['javascript']
language: [javascript]
# Learn more...
# https://docs.github.com/en/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#overriding-automatic-language-detection

Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,14 @@ jobs:
release:
name: Publish & Deploy
runs-on: ubuntu-latest
env:
CI: true
steps:
- name: Check out repo
uses: actions/checkout@master
uses: actions/checkout@v3
with:
fetch-depth: 0
lfs: true

- name: Set up Node.js 16.x
uses: actions/setup-node@master
uses: actions/setup-node@v2
with:
node-version: 16.x

Expand Down
16 changes: 4 additions & 12 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,12 @@ jobs:
core:
name: Lint & Test
runs-on: ubuntu-latest
env:
CI: true
steps:
- name: Check out repo
uses: actions/checkout@master
with:
lfs: true
uses: actions/checkout@v3

- name: Set up Node.js 16.x
uses: actions/setup-node@master
uses: actions/setup-node@v2
with:
node-version: 16.x

Expand All @@ -52,8 +48,6 @@ jobs:
template:
name: Integrate
runs-on: ubuntu-latest
env:
CI: true
strategy:
matrix:
template:
Expand All @@ -66,12 +60,10 @@ jobs:
- private-npm-package
steps:
- name: Check out repo
uses: actions/checkout@master
with:
lfs: true
uses: actions/checkout@v3

- name: Set up Node.js 16.x
uses: actions/setup-node@master
uses: actions/setup-node@v2
with:
node-version: 16.x

Expand Down
7 changes: 2 additions & 5 deletions template/oss-npm-package/.github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,14 @@ jobs:
release:
name: Publish & Deploy
runs-on: ubuntu-latest
env:
CI: true
steps:
- name: Check out repo
uses: actions/checkout@master
uses: actions/checkout@v3
with:
fetch-depth: 0
lfs: true

- name: Set up Node.js 16.x
uses: actions/setup-node@master
uses: actions/setup-node@v2
with:
node-version: 16.x

Expand Down
8 changes: 2 additions & 6 deletions template/oss-npm-package/.github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,12 @@ jobs:
validate:
name: Lint & Test
runs-on: ubuntu-latest
env:
CI: true
steps:
- name: Check out repo
uses: actions/checkout@master
with:
lfs: true
uses: actions/checkout@v3

- name: Set up Node.js 16.x
uses: actions/setup-node@master
uses: actions/setup-node@v2
with:
node-version: 16.x

Expand Down