Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commitizen to package templates #418

Merged
merged 13 commits into from
Apr 19, 2021
Merged

Add commitizen to package templates #418

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1b34e5e
Add commit script to template
kosanna Apr 16, 2021
b597bd1
alfa-sort scripts
kosanna Apr 16, 2021
492bc23
Add commitizen to oss, update readme
kosanna Apr 16, 2021
c3f9b4a
Merge branch 'add-commitizen' of github.com:seek-oss/skuba into add-c…
kosanna Apr 16, 2021
c74a720
Push
kosanna Apr 17, 2021
610f861
Move commitizen to local dev deps
kosanna Apr 19, 2021
b310610
Move readme section
kosanna Apr 19, 2021
0f2bf30
Tweak changeset
72636c Apr 19, 2021
0b3e5f7
Alphabetise
72636c Apr 19, 2021
95ee906
Alphabetise
72636c Apr 19, 2021
5555abb
Tweak wording
72636c Apr 19, 2021
fd2eaf3
Tweak wording
72636c Apr 19, 2021
905055c
Merge branch 'master' into add-commitizen
72636c Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"babel-plugin-macros": "^3.0.1",
"babel-plugin-module-resolver": "^4.1.0",
"chalk": "^4.1.0",
"commitizen": "^4.2.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not keen on bundling commitizen into skuba itself while it has high-severity security vulnerabilities that have gone unpatched for months. If we're sure this is still the best tool for the job (what does it do besides present ~2 prompts to the user?) I'd place it in the template package.json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, can move it to templates then 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess sec is less of a concern for dev deps on packages

"concurrently": "^6.0.0",
"ejs": "^3.1.6",
"enquirer": "^2.3.6",
Expand Down
6 changes: 6 additions & 0 deletions template/private-npm-package/_package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,17 @@
"scripts": {
"build": "skuba build-package",
"format": "skuba format",
"commit": "cz",
kosanna marked this conversation as resolved.
Show resolved Hide resolved
"lint": "skuba lint",
"release": "yarn build && skuba release",
"test": "skuba test --coverage",
"test:watch": "skuba test --watch"
},
"config": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I believe we can/should do the same to the oss-npm-package template.
  2. Should we add a section to the relevant template READMEs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I was just not sure about the oss, just because you could go either way about it and implement changesets for example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It's definitely easier to get Changesets going in oss, but it should be fine to include this out of the box since the template defaults to using Semantic Release anyway.

"commitizen": {
"path": "cz-conventional-changelog"
}
},
"sideEffects": false,
"types": "./lib-types/index.d.ts",
"version": "0.0.0-semantically-released"
Expand Down
Loading