Move Gantry region config to plugin options (#374)

The next version of the Gantry plugin will start requiring this option.
seek-oss · Mar 2, 2021 · a80fed6 · a80fed6
1 parent a343814
commit a80fed6
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/.changeset/wise-papayas-add.md b/.changeset/wise-papayas-add.md
@@ -0,0 +1,5 @@
+---
+'skuba': patch
+---
+
+**template/\*-rest-api:** Move Gantry region config to plugin options
diff --git a/template/express-rest-api/.buildkite/pipeline.yml b/template/express-rest-api/.buildkite/pipeline.yml
@@ -42,6 +42,7 @@ steps:
       - seek-jobs/gantry#v1.2.11:
           command: build
           file: gantry.build.yml
+          region: ap-southeast-2
           values: .gantry/common.yml
 
   - wait
@@ -57,6 +58,7 @@ steps:
           command: apply
           environment: <%- devGantryEnvironmentName %>
           file: gantry.apply.yml
+          region: ap-southeast-2
           values:
             - .gantry/common.yml
             - .gantry/dev.yml
@@ -73,6 +75,7 @@ steps:
           command: apply
           environment: <%- prodGantryEnvironmentName %>
           file: gantry.apply.yml
+          region: ap-southeast-2
           values:
             - .gantry/common.yml
             - .gantry/prod.yml
diff --git a/template/express-rest-api/gantry.apply.yml b/template/express-rest-api/gantry.apply.yml
@@ -6,8 +6,6 @@ name: '{{values "service"}}'
 
 image: '{{values "image"}}'
 
-region: ap-southeast-2
-
 env:
   # https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html
   AWS_NODEJS_CONNECTION_REUSE_ENABLED: '1'

diff --git a/template/koa-rest-api/.buildkite/pipeline.yml b/template/koa-rest-api/.buildkite/pipeline.yml
@@ -42,6 +42,7 @@ steps:
       - seek-jobs/gantry#v1.2.11:
           command: build
           file: gantry.build.yml
+          region: ap-southeast-2
           values: .gantry/common.yml
 
   - wait
@@ -57,6 +58,7 @@ steps:
           command: apply
           environment: <%- devGantryEnvironmentName %>
           file: gantry.apply.yml
+          region: ap-southeast-2
           values:
             - .gantry/common.yml
             - .gantry/dev.yml
@@ -73,6 +75,7 @@ steps:
           command: apply
           environment: <%- prodGantryEnvironmentName %>
           file: gantry.apply.yml
+          region: ap-southeast-2
           values:
             - .gantry/common.yml
             - .gantry/prod.yml
diff --git a/template/koa-rest-api/gantry.apply.yml b/template/koa-rest-api/gantry.apply.yml
@@ -6,8 +6,6 @@ name: '{{values "service"}}'
 
 image: '{{values "image"}}'
 
-region: ap-southeast-2
-
 env:
   # https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html
   AWS_NODEJS_CONNECTION_REUSE_ENABLED: '1'