Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pnpm #37

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Migrate to pnpm #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
846eee6
Migrate to pnpm
askoufis Mar 25, 2024
a1891fe
Use `seek/base` eslint config
askoufis Mar 25, 2024
794a2ff
Update dev deps
askoufis Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "seek",
"extends": "seek/base",
"rules": {
"no-console": 0
}
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,28 @@ jobs:
env:
CI: true
steps:
- name: Checkout Repo
- name: Check out Repo
uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.SEEK_OSS_CI_GITHUB_TOKEN }}

- uses: pnpm/action-setup@v3

- name: Set up Node.js
uses: actions/setup-node@v4
with:
cache: yarn
cache: pnpm
node-version-file: package.json

- name: Install Dependencies
run: yarn --frozen-lockfile
run: pnpm install --frozen-lockfile

- name: Create Release Pull Request or Publish to npm
uses: changesets/action@v1
with:
version: yarn run version
publish: yarn release
version: pnpm run version
publish: pnpm run release
env:
GITHUB_TOKEN: ${{ secrets.SEEK_OSS_CI_GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.SEEK_OSS_CI_NPM_TOKEN }}
14 changes: 9 additions & 5 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,24 @@ jobs:
env:
CI: true
steps:
- name: Checkout Repo
- name: Check out Repo
uses: actions/checkout@v4
with:
fetch-depth: 0

- uses: pnpm/action-setup@v3

- name: Set up Node.js
uses: actions/setup-node@v4
with:
cache: yarn
cache: pnpm
node-version-file: package.json

- name: Install Dependencies
run: yarn --frozen-lockfile
run: pnpm install --frozen-lockfile

- name: Lint
run: yarn lint
run: pnpm lint

- name: Test
run: yarn test
run: pnpm test
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,16 @@
},
"homepage": "https://github.com/seek-oss/browserslist-config-seek#readme",
"devDependencies": {
"@changesets/changelog-github": "^0.4.0",
"@changesets/cli": "^2.16.0",
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.1",
"browserslist": "^4.23.0",
"eslint": "^8.56.0",
"eslint-config-seek": "^13.0.0",
"typescript": "~5.4.3"
},
"packageManager": "[email protected]",
"volta": {
"node": "18.19.1",
"yarn": "1.22.22"
"pnpm": "8.15.5"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could cause issues with volta users that don't have pnpm support enabled, but very few people make changes to this package so I don't think it's a big deal.

}
}
Loading